Re: Incorrect preadv/pwritev argument parsing on ARM EABI

[Dima K. <di...@se...>]

Dima Kogan <di...@se...> writes:

> Dmitry V. Levin <ld...@al...> writes:
>
>> Unfortunately, your patch breaks all 64-bit architectures because offset
>> is passed as a single argument
>
> Oh yeah. I clearly broke that; sorry about that. We want to parse preadv
> and pwritev in exactly the same way we parse llseek. That syscall does
> the same arg splitting. Its code looks very similar, so after 30 seconds
> of looking at it I'm not yet sure why that works. I'll look more closely
> later tonight.

OK. Never mind on the llseek, actually. I was testing lseek, NOT llseek,
which is why it looked odd. The patch I attached earlier can be fixed
with some #ifdefs probably. I should be pretty trivial. Is it useful for
me to do it, or do you want to?

dima