Re: porting strace to Bionic libc

[Dmitry V. L. <ld...@al...>]

On Thu, Feb 27, 2014 at 11:06:09AM -0800, enh wrote:
> On Wed, Feb 26, 2014 at 3:42 PM, Dmitry V. Levin <ld...@al...> wrote:
> > I've posted a patch that reimplements signal mask decoding without use of
> > sigset_t.  It fixes this issue, but may introduce new bugs.  Please check
> > whether it builds and passes sigaction.test in your environment.
> 
> works for me on arm strace tracing an arm binary and arm64 strace
> tracing an arm64 binary, so please commit.

Thanks.

> (it doesn't work on arm64 when tracing a 32-bit process, but that's a
> separate issue. do you want me to send you patches in the style of
> your stack_t patch from yesterday, or do you prefer to write the
> patches yourself and just want me to let you know when i hit a struct
> that differs between LP32 and LP64?)

If you've stumbled upon a bug and made a patch that fixes it, please do
not hesitate and send the fix to this list.  Of course I prefer patches
that are ready to be applied. :)


-- 
ldv