Re: [PATCH 1/2] Update errno and ioctl definitions for newer Linux

[Steve M. <ste...@li...>]

On Tue, Oct 23, 2012 at 10:22:56PM -0400, Mike Frysinger wrote:
>On Tuesday 23 October 2012 19:58:46 Dmitry V. Levin wrote:
>> On Tue, Oct 23, 2012 at 05:36:58PM +0100, Steve McIntyre wrote:
>> > --- a/linux/ioctlent.h.in
>> > +++ b/linux/ioctlent.h.in
>> > @@ -2,6 +2,7 @@
>> > 
>> >  	{"linux/fs.h",	"FIBMAP",	0x0001},
>> >  	{"linux/fs.h",	"FIGETBSZ",	0x0002},
>> >  	{"linux/fd.h",	"FDGETPRM",	0x0204},
>> > +	{"linux/fd.h",	"FDGETPRM32",	0x0204},
>> 
>> I'm not sure such entries are worth adding.  I know we have these
>> redundant "*32" entries in linux/ioctlent.h.in already, maybe it's time
>> to strip them instead of adding new ones.
>
>if the # is the same as the non-32 version, then yeah, we should omit it.  
>otherwise the output is generally useless:
>	ioctl(1, FDGETPRM or FDGETPRM32, {...}) = 0
>
>the decoder would need to know more info in order to tell which one exactly is 
>being used (based on the active ELF).  but we don't have that, so we should 
>filter it.
>
>i'm guessing Steve just ran the script in the tree to generate this and didn't 
>hand update it.  which means we should update the script to be smarter.

Correct, yes.

Cheers,
-- 
Steve McIntyre                                ste...@li...
<http://www.linaro.org/> Linaro.org | Open source software for ARM SoCs