Menu

#41 stp_timeout.sh

open
nobody
None
3
2006-02-09
2004-02-27
No

* In the comments at the top of the script, it refers to
itself as 'timeout.sh' instead of 'stp_timeout.sh'.

* To get the pid, it calls ps and uses grep and sed to get
the pid. This seems a bit brute force and potentially
brittle, as the default output from ps can vary from distro
to distro. Wouldn't getpid() or a Perl module like
Linux::Pid be a bit more robust?

Discussion

  • Bryce Harrington

    Logged In: YES
    user_id=4782

    * The PID file is getting stored in /tmp. Wouldn't a better
    location for this file be /var/run ?

     
  • Bryce Harrington

    • assigned_to: nobody --> cliffw
     
  • Bryce Harrington

    Logged In: YES
    user_id=4782

    Fixed the first issue

     
  • Bryce Harrington

    • priority: 5 --> 3
     
  • Mark Wong

    Mark Wong - 2006-02-09
    • assigned_to: cliffw --> nobody
     

Log in to post a comment.