Re: [Stlport-devel] ARM toolchain support for STLport-5.2
Brought to you by:
complement
From: Petr O. <pt...@vo...> - 2011-03-05 09:34:45
|
Hi Wojciech, Thanks for patch. On Fri, 4 Mar 2011 13:35:52 -0000 "Wojciech Meyer" <Woj...@ar...> wrote: > > > Since ARM compiler has not been supported by STLport before, and we > > would like to have this support up-stream, we prepared a porting patch > > for armcc compiler. We've decided to stick with 5.2 STLport line, as it > > seems to be most suitable for this purpose. Please find the patch > > attached that implements cross compilation of STLport using ARM > > toolchain. The patch has been tested in our environment and passes unit > > tests. > I have question about this lines (build/test/unit/armcc.mak): +ifeq ($(OSNAME), linux) +release-shared: LDFLAGS += -L${STLPORT_DIR}/build/lib/${OUTPUT_DIR_STLDBG}/libstlportstlg.a +dbg-shared: LDFLAGS += -L${STLPORT_DIR}/build/lib/${OUTPUT_DIR_STLDBG}/libstlportstlg.a +stldbg-shared: LDFLAGS += -L${STLPORT_DIR}/build/lib/${OUTPUT_DIR_STLDBG}/libstlportstlg.a - -L is a path to, not archive itself, isn't it? - do you understand problems of using C++ code in static libraries? If you link with static STLport lib, the behaviour of program will be undefined if you write something like #include <iostream> #include <iomanip> using std; struct f { f(); }; f::f() { cerr << __FILE__ << ':' << __LINE__ << endl; } static f obj; int main() { return 0; } Why you comment this (build/test/unit/armcc.mak): +#-include ${SRCROOT}/Makefiles/gmake/config.mak ? I don't see stl/config/_armgcc.h, but see +# elif defined ( __ARMCC_VERSION) && defined(_GNU_SOURCE) +# include <stl/config/_armgcc.h> +# elif defined ( __ARMCC_VERSION) +# include <stl/config/_armcc.h> Patch should contain 'commit notes', i.e. description of this commit (see 'git log' under STLport-5.2 branch, for example). -- Bests, - Petr |