Re: [Stlport-devel] FstreamTest::offset
Brought to you by:
complement
From: <fra...@fr...> - 2007-08-29 19:45:16
|
Thanks Uli for the additional info. So this test is Posix specific, we could at least check that we are on a Posix platform to use this test. But even for Posix platform I do not see what this test is for. What is it supposed to check ? It is simply duplicating the macro tests done in char_traits.h to define streamoff, someone changing test in char_traits.h will simply have to also change test in fstream_test.cpp, rather annoying. Ulrich Eckhardt wrote: > On Sunday 26 August 2007 23:06, Petr Ovtchenkov wrote: > >> On Sunday 26 August 2007 19:45, François Dumont wrote: >> >>> What is FstreamTest::offset test for ? >>> >> This test is for correct large file support by libstlport, if OS support >> large files by some way. >> >> >>> Under Win32, 32 bits, streamoff is 8 and off_t is 4 so test fails. >>> >> #if (defined(_LARGEFILE_SOURCE) || defined(_LARGEFILE64_SOURCE)) && >> !defined(_STLP_USE_DEFAULT_FILE_OFFSET) CPPUNIT_CHECK( sizeof(streamoff) == >> 8 ); >> #else >> CPPUNIT_CHECK( sizeof(streamoff) == sizeof(off_t) ); >> #endif >> >> Do you confirm that _LARGEFILE_SOURCE or _LARGEFILE64_SOURCE defined under >> Wins? >> > > >From a short search, it turns out that LFS is a POSIX or POSIX-related thing > and thus not applicable for win32. I also did a search for lseek64 and that > is definitely not present in any headers of VC8. > > Uli > > |