[stlport-bugs] [ stlport-Bugs-1634886 ] wrong russian currency name in unittests

[SourceForge.net <no...@so...>]

Bugs item #1634886, was opened at 2007-01-13 22:17
Message generated for change (Comment added) made by tizianomueller
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=766244&aid=1634886&group_id=146814

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: General code
Group: None
>Status: Open
Resolution: Fixed
Priority: 5
Private: No
Submitted By: Tiziano Müller (tizianomueller)
Assigned to: Petr Ovtchenkov (complement)
Summary: wrong russian currency name in unittests

Initial Comment:
In test/unit/locale_test.cpp is "RUR" written as the russian currency name. This should be "RUB" according to my glibc and http://en.wikipedia.org/wiki/ISO_4217#Active_codes_.28sorted_by_code.29


----------------------------------------------------------------------

>Comment By: Tiziano Müller (tizianomueller)
Date: 2007-04-01 13:05

Message:
Logged In: YES 
user_id=935305
Originator: YES

Great, this shows up in 5.1.2 again. I put cout's in the code to print
them.
[...]
LocaleTest::money_put_get
        fr_FR  str_res.substr(index, p): EUR
  rl.money_int_prefix: EUR
  p_old: 4
  str_res.substr(index, p_old): EUR
  rl.money_int_prefix_old:FRF

        ru_RU.koi8r  str_res.substr(index, p): RUB
  rl.money_int_prefix: RUR
  p_old: 0
  str_res.substr(index, p_old):
  rl.money_int_prefix_old:


../../../test/unit/locale_test.cpp(222) :
CPPUNIT_ASSERT((str_res.substr(index, p) == rl.money_int_prefix) || ((p_old
!= 0) && (str_res.substr(index, p_old) == rl.money_int_prefix_old)));
        en_GB  str_res.substr(index, p): GBP
  rl.money_int_prefix: GBP
  p_old: 0
  str_res.substr(index, p_old):
  rl.money_int_prefix_old:

        en_US  str_res.substr(index, p): USD
  rl.money_int_prefix: USD
  p_old: 0
  str_res.substr(index, p_old):
  rl.money_int_prefix_old:

        C
LocaleTest::money_put_X_bug
        fr_FR
        ru_RU.koi8r
        en_GB
        en_US
        C
LocaleTest::time_put_get
        fr_FR
        ru_RU.koi8r
        en_GB
        en_US
        C
LocaleTest::collate_facet
LocaleTest::ctype_facet
        fr_FR
        ru_RU.koi8r
        en_GB
        en_US
        C
LocaleTest::locale_init_problem
        fr_FR
        ru_RU.koi8r
        en_GB
        en_US
        C
LocaleTest::default_locale
LocaleTest::facet_id
LocaleTest::combine
        combining 'ru_RU.koi8r' money facets with 'fr_FR' 
str_res.substr(index, p): RUB
  rl.money_int_prefix: RUR
  p_old: 0
  str_res.substr(index, p_old):
  rl.money_int_prefix_old:


../../../test/unit/locale_test.cpp(222) :
CPPUNIT_ASSERT((str_res.substr(index, p) == rl.money_int_prefix) || ((p_old
!= 0) && (str_res.substr(index, p_old) == rl.money_int_prefix_old))); 
str_res.substr(index, p): EUR
  rl.money_int_prefix: EUR
  p_old: 4
  str_res.substr(index, p_old): EUR
  rl.money_int_prefix_old:FRF
  str_res.substr(index, p): RUB
  rl.money_int_prefix: RUR
  p_old: 0
  str_res.substr(index, p_old):
  rl.money_int_prefix_old:


../../../test/unit/locale_test.cpp(222) :
CPPUNIT_ASSERT((str_res.substr(index, p) == rl.money_int_prefix) || ((p_old
!= 0) && (str_res.substr(index, p_old) == rl.money_int_prefix_old))); 
str_res.substr(index, p): RUB
  rl.money_int_prefix: RUR
  p_old: 0
  str_res.substr(index, p_old):
  rl.money_int_prefix_old:


../../../test/unit/locale_test.cpp(222) :
CPPUNIT_ASSERT((str_res.substr(index, p) == rl.money_int_prefix) || ((p_old
!= 0) && (str_res.substr(index, p_old) == rl.money_int_prefix_old))); 
str_res.substr(index, p): EUR
  rl.money_int_prefix: EUR
  p_old: 4
  str_res.substr(index, p_old): EUR
  rl.money_int_prefix_old:FRF
  str_res.substr(index, p): RUB
  rl.money_int_prefix: RUR
  p_old: 0
  str_res.substr(index, p_old):
  rl.money_int_prefix_old:


../../../test/unit/locale_test.cpp(222) :
CPPUNIT_ASSERT((str_res.substr(index, p) == rl.money_int_prefix) || ((p_old
!= 0) && (str_res.substr(index, p_old) == rl.money_int_prefix_old)));
        combining 'en_GB' money facets with 'ru_RU.koi8r' 
str_res.substr(index, p): GBP
  rl.money_int_prefix: GBP
  p_old: 0
  str_res.substr(index, p_old):
  rl.money_int_prefix_old:
  str_res.substr(index, p): RUB
  rl.money_int_prefix: RUR
  p_old: 0
  str_res.substr(index, p_old):
  rl.money_int_prefix_old:


../../../test/unit/locale_test.cpp(222) :
CPPUNIT_ASSERT((str_res.substr(index, p) == rl.money_int_prefix) || ((p_old
!= 0) && (str_res.substr(index, p_old) == rl.money_int_prefix_old))); 
str_res.substr(index, p): GBP
  rl.money_int_prefix: GBP
  p_old: 0
  str_res.substr(index, p_old):
  rl.money_int_prefix_old:
  str_res.substr(index, p): GBP
  rl.money_int_prefix: GBP
  p_old: 0
  str_res.substr(index, p_old):
  rl.money_int_prefix_old:
  str_res.substr(index, p): RUB
  rl.money_int_prefix: RUR
  p_old: 0
  str_res.substr(index, p_old):
  rl.money_int_prefix_old:


../../../test/unit/locale_test.cpp(222) :
CPPUNIT_ASSERT((str_res.substr(index, p) == rl.money_int_prefix) || ((p_old
!= 0) && (str_res.substr(index, p_old) == rl.money_int_prefix_old))); 
str_res.substr(index, p): GBP
  rl.money_int_prefix: GBP
  p_old: 0
  str_res.substr(index, p_old):
  rl.money_int_prefix_old:

        combining 'en_US' money facets with 'en_GB'  str_res.substr(index,
p): USD
  rl.money_int_prefix: USD
  p_old: 0
  str_res.substr(index, p_old):
  rl.money_int_prefix_old:
  str_res.substr(index, p): GBP
  rl.money_int_prefix: GBP
  p_old: 0
  str_res.substr(index, p_old):
  rl.money_int_prefix_old:
  str_res.substr(index, p): USD
  rl.money_int_prefix: USD
  p_old: 0
  str_res.substr(index, p_old):
  rl.money_int_prefix_old:
  str_res.substr(index, p): USD
  rl.money_int_prefix: USD
  p_old: 0
  str_res.substr(index, p_old):
  rl.money_int_prefix_old:
  str_res.substr(index, p): GBP
  rl.money_int_prefix: GBP
  p_old: 0
  str_res.substr(index, p_old):
  rl.money_int_prefix_old:
  str_res.substr(index, p): USD
  rl.money_int_prefix: USD
  p_old: 0
  str_res.substr(index, p_old):
  rl.money_int_prefix_old:

        combining 'C' money facets with 'en_US'  str_res.substr(index, p):
USD
  rl.money_int_prefix: USD
  p_old: 0
  str_res.substr(index, p_old):
  rl.money_int_prefix_old:
  str_res.substr(index, p): USD
  rl.money_int_prefix: USD
  p_old: 0
  str_res.substr(index, p_old):
  rl.money_int_prefix_old:
[...]

----------------------------------------------------------------------

Comment By: Petr Ovtchenkov (complement)
Date: 2007-01-16 08:21

Message:
Logged In: YES 
user_id=615813
Originator: NO

My inadvertence, tests fine. Francois' fix good. Resolved.

----------------------------------------------------------------------

Comment By: Petr Ovtchenkov (complement)
Date: 2007-01-16 02:44

Message:
Logged In: YES 
user_id=615813
Originator: NO

BTW, see the second table in initial ref.

Seeing on this I found problem with unit tests---investigating.

----------------------------------------------------------------------

Comment By: Petr Ovtchenkov (complement)
Date: 2007-01-16 00:49

Message:
Logged In: YES 
user_id=615813
Originator: NO

Not all so good. glibc 2.3.6 and before has RUR here, while glibc 2.5
already has correct RUB. Something between this.

----------------------------------------------------------------------

Comment By: Francois Dumont (dums)
Date: 2007-01-15 21:45

Message:
Logged In: YES 
user_id=1096600
Originator: NO

Fixed in SVN trunk, thanks for the report.

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=766244&aid=1634886&group_id=146814