[Stepmania-devs] Oni Modifier Fix

[Angela S <pw...@ho...>]

I've been looking into fixing the issue with Oni song modifiers from a 
course file sticking around between songs. (Bug entered in BTS, 632058)

First, I wanted to confirm with the knowledgable about why it's occuring, to 
make sure I understand it.  It appears that when you select Options from the 
Options screen before the oni course, they're all tossed into 
GAMESTATE->m_PlayerOptions[player number], and that's used to implement 
them. It appears that when an Oni song with modifiers is loaded from a .CRS 
file, the modifiers are parsed, and applied to that same variable.

So you can't just clear out GAMESTATE->m_PlayerOptions[] without wiping out 
the original options between songs, but once it's modified for a specific 
song, there's no way to get the original options back.  Do I understand this 
correctly, guys?

Now, if this is the case, I see two fixes.

1) Remove the ability to select options on Courses, and wipe PlayerOptions 
between songs.

2) Add an additional field, such as GAMESTATE->m_SelectedOptions[], and copy 
from that to PlayerOptions between songs.

I ask because I know there are some people who want the first method done, 
since DDR doesn't support options for a course.  However, I prefer the 
second - no need to remove features just because DDR doesn't have them, 
since we're not making DDR after all.  Which do you prefer?

-Angela

_________________________________________________________________
Protect your PC - get McAfee.com VirusScan Online 
http://clinic.mcafee.com/clinic/ibuy/campaign.asp?cid=3963