Re: [Stellarium-pubdevel] renaming of members in the core

[Reaves, T. <tr...@si...>]

I think the changes do add value.  isXXXDisplayed will let you know if XXX
is displayed.  getFlagXXX  -especially getFlagNames - tells you nothing.
As far as the scripting API goes, the uses should have been updated too.
But the scripting API should have insulated any scripts from the names of
methods, regardless of if they are in the 'core' or not.  That they do not
shows a very poor implementation decision on someones part.  It leads to
fragile scripts.

API's change. They improve; if not, they end up like Java.  Consistency for
the sake of consistency is not a good idea, as much as people like to
banter it about.  getFlagNames is bad.  isNamesDisplayed is better.  That
this change will cause some scripts to need to be updated may be
unfortunate, but that's progress.

I do not think the names should be changed back.  Providing a release
document with the name changes is reasonable.  Users would just need to
look at the document, and update their scripts accordingly.

As an aside, Stellarium does not - and probably never will - use QT.  QT is
a technology used for playing audio & video.

On Sun, Feb 19, 2012 at 7:50 PM, Matthew Gates <mat...@gm...> wrote:

> Recent changes to use the QT properties system have included the
> renaming of many core class member functions.  In the case of public
> slots, this directly changes the scripting API.  I also don't think
> the replacements offer any real improvement over the previous names
> (e.g. getFlagNames vs. isNamesDisplayed).
>
> Please change the names back.
>
> M
>
>
> ------------------------------------------------------------------------------
> Try before you buy = See our experts in action!
> The most comprehensive online learning library for Microsoft developers
> is just $99.99! Visual Studio, SharePoint, SQL - plus HTML5, CSS3, MVC3,
> Metro Style Apps, more. Free future releases when you subscribe now!
> http://p.sf.net/sfu/learndevnow-dev2
> _______________________________________________
> Stellarium-pubdevel mailing list
> Ste...@li...
> https://lists.sourceforge.net/lists/listinfo/stellarium-pubdevel
>