From: Bogdan M. <dag...@gm...> - 2010-09-05 12:58:15
|
Hello to all. I've merged my experimental AddRemoveLandscapes plug-in to the core code. The branch is here: https://code.launchpad.net/~daggerstab/stellarium/add-remove-landscapes The code went to the LandscapeMgr class and a sub-window of the Sky and viewing options window (ViewDialog), with minimal changes to ViewDialog itself. Now there is a "Add/remove landscapes..." button in the Landscapes tab that opens the sub-window. It's not ready for merging yet (there is some more work on my other computer that I need to merge), but comments and suggestions are welcome. Bug reports too. :) A minor issue that I am unsure about is line 315 (now 322) in ViewDialog.cpp (see this diff link: http://bazaar.launchpad.net/~daggerstab/stellarium/add-remove-landscapes/revision/4746#src/gui/ViewDialog.cpp ). It seems to work OK with my changes. At the moment, LandscapeMgr does not protect the default landscapes from being deleted. They are excluded from the list in the GUI, but I don't think that this is enough protection. Also, the list of default landscapes needs to be updated manually. I'll try to have it generated by CMake. Regards, Bogdan Marinov |