From: Timothy R. <tr...@si...> - 2010-05-27 22:16:03
|
On May 27, 2010, at 5:40 PM, Fabien Chéreau wrote: >> >> The rest of the code does need to be changed. How else do you define what >> the default key bindings are? A GUI for editing should show what the >> default is, as well as being able to reset to default. > > Well when you call StelGuiBase::addGuiActions you define the default > key binding. Only if you want to override it, you need to add > something. > > It's not as simple as that. Again, defaults have to be handled. Next - and this as what I was going to be working on next - there needs to be a way of updating bindings at run time. You shouldn't need to restart the app for new keybindings to take effect. I've looked at StelGuiBase, and agree that the bulk of the logic can reside here. We'll still want the JSON file for binding defaults. We could just have a single one, but, that seems to me to be counter to the plugin idea. >> It sounds like you've got some way of doing it planned already. I'm curious >> as to why you haven't implemented it, given the large amount of strife it's >> causing users, and to a lesser extent developers. I'll forgo any additional >> effort on m part, to give you the opportunity to get it done your way. > > I never thought at how to do it before, but now that I see your patch > it's getting clearer that we can do simpler. I don't plan to code > that, so please go on! The hardest part which was blocking me was to > make a nice GUI for controlling this. O.K. Let's see if we can reach agreement on the design, and then to code it up won't take but a couple of hours. |