Re: [Stellarium-pubdevel] Legacy TelescopeMgr

[Fabien C. <fab...@go...>]

On Tue, May 11, 2010 at 21:03, Bogdan Marinov <dag...@gm...> wrote:
> On Tue, May 11, 2010 at 3:59 PM, Fabien Chéreau
> <fab...@go...> wrote:
>> Bogdan,
>> Is there anything that the previous "legacy" TelescopeMgr code can do
>> and that your plugin cannot do?
>
> Supposedly, no. It provides an option that avoids using the GUI and
> the button in the bottom toolbar.* I'm not sure how "heavy" is my
> plug-in - I haven't compared FPS values or done any other kind of
> performance testing.
>
> It also keeps both the feature's and Stellarium's settings in the same
> file, which makes setting up Stellarium with identical settings on a
> large number of computers easier.
>
> (* Something needs to be done about that toolbar - when enough plug-in
> buttons are added, it becomes too wide for the screen and the Quit
> button becomes unaccessible. This is especially true for window mode.)
>
>> If not I propose that we simply get
>> rid of the legacy code. Users will have to migrate but they will get
>> better support with you now than with the previous code.
>
> Removing TelescopeMgr removes a feature from the core and delegates it
> to a plug-in, but the reason I've been uneasy about removing
> TelescopeMgr so far has been backwards compatibility, especially with
> third party applications like StellariumScope that rely on writing to
> the configuration file to work. (There's a new version of
> StellariumScope that takes the Telescope Control plug-in into account,
> so this point may be moot.)  I don't have any strong arguments for
> keeping it, though. Do as you wish.

OK, then in this case it's clear: we don't need to maintain duplicate
features, and I realized that TelescopeMgr draw() and update() methods
actually do things even if unused, so it even decreases performances.

I will do that now.

> Regards,
> Bogdan Marinov
>
> ------------------------------------------------------------------------------
>
> _______________________________________________
> Stellarium-pubdevel mailing list
> Ste...@li...
> https://lists.sourceforge.net/lists/listinfo/stellarium-pubdevel
>