#3982 Use read only LedgerTxn

[Anonymous]

Originally created by: sisuresh

Description

Resolves https://github.com/stellar/stellar-core/issues/3716

Checklist

• [ ] Reviewed the contributing document
• [ ] Rebased on top of master (no merge commits)
• [ ] Ran clang-format v8.0.0 (via make format or the Visual Studio extension)
• [ ] Compiles
• [ ] Ran all tests
• [ ] If change impacts performance, include supporting evidence per the performance document

[Anonymous]

Originally posted by: dmkozh

Thinking about why we have some many LedgerTxns throughout the code, I'm wondering: will these changes clash with what @dmkozh is working on, i.e. stop using LedgerTxn for network config retrieval? IIUC, the reason we have so many RO LedgerTxns in the code now is to support Soroban config loading in v20.

Given that this PR is really small, I think we don't need to block it on my changes. Also some of ltxs are also used for something else besides the config getter. But if we're going to do a larger scale refactoring, then I'd say let's wait for my changes.

[Anonymous]

Originally posted by: sisuresh

Yeah we can hold off on this and any refactoring since it's just a perf change and not high priority. I had a few minutes before standup so decided to do this, but we have other issues that are higher priority so we shouldn't be spending more time on this.