#3957 Cleanup BucketList Access

[Anonymous]

Originally created by: SirTyson

Description

Resolves [#3842]

This PR adds additional checks for MODE_ENABLES_BUCKETLIST. I don't think it is actually possible to access some of the modified code paths when MODE_ENABLES_BUCKETLIST == false, but I wanted to stay on the safe side since changes later on could cause these asserts to hit.

Checklist

• [x] Reviewed the contributing document
• [x] Rebased on top of master (no merge commits)
• [x] Ran clang-format v8.0.0 (via make format or the Visual Studio extension)
• [x] Compiles
• [x] Ran all tests
• [ ] If change impacts performance, include supporting evidence per the performance document

[Anonymous]

Ticket changed by: SirTyson

• status: open --> closed