Menu

#3954 Fix bug 3952 by normalizing LedgerCloseMeta on meta stream

open
nobody
None
2023-10-05
2023-09-27
Anonymous
No

Originally created by: graydon

We weren't normalizing LedgerCloseMeta when writing to the meta stream. This should (I think) mostly do so.

I had to add some normalization logic to the outer structure -- it's worth careful review by a second pair of eyes that I got everything. Also I'm slightly surprised that the test-vector regeneration only updated one .json file (I did run with --all-versions). It passes tests though!

Fixes [#3952]

Related

Tickets: #3952

Discussion

  • Anonymous

    Anonymous - 2023-10-03

    Originally posted by: MonsieurNicolas

    I am not sure I understand why we'd want this change in the first place (issues in historical data already emitted). See conversation in https://github.com/stellar/go/pull/5070

     
  • Anonymous

    Anonymous - 2023-10-05

    Originally posted by: MonsieurNicolas

    circling back here: probably not worth doing at the core layer at this time, so no need to chase right now what is wrong with the normalize function that we implemented here (worth opening an issue about this though)

     

Log in to post a comment.