Look into using read only LedgerTxns for the LedgerTxns that were introduced...

stellar-core is the reference implementation for the peer to peer agent that manages the Stellar network

Brought to you by: liefstorer

#3716 Look into using read only LedgerTxns for the LedgerTxns that were introduced in the config upgrade change.

Status: open

Owner: nobody

Labels: None

Updated: 2023-10-13

Created: 2023-04-21

Creator: Anonymous

Private: No

Originally created by: sisuresh

The LedgerTxns added in the config upgrade PR should be using READ_ONLY_WITHOUT_SQL_TXN since they should all be read only. If we do this, we should make sure there are no concurrent writers present.

Discussion

Anonymous - 2023-05-15

assigned_to: sisuresh
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2023-06-28

Originally posted by: marta-lokhova

I would suggest a broader audit of LedgerTxn usage in vNext outside of application phase. I'm seeing more recently added instances that should be switched to read-only:
https://github.com/stellar/stellar-core/blob/e38ee728dcc47deb7e4cc68b82ce43dbd5b321d1/src/overlay/OverlayManagerImpl.cpp#L1209
https://github.com/stellar/stellar-core/blob/e38ee728dcc47deb7e4cc68b82ce43dbd5b321d1/src/herder/TransactionQueue.cpp#L1339
https://github.com/stellar/stellar-core/blob/e38ee728dcc47deb7e4cc68b82ce43dbd5b321d1/src/herder/TransactionQueue.cpp#L1544

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Look into using read only LedgerTxns for the LedgerTxns that were introduced...

stellar-core is the reference implementation for the peer to peer agent that manages the Stellar network

Milestone

Searches

Help

#3716 Look into using read only LedgerTxns for the LedgerTxns that were introduced in the config upgrade change.

Discussion