Re: [SSI-devel] [PATCH] OpenSSI clusterproc module

[John B. <joh...@hp...>]

Aneesh Kumar wrote:
> Hi Laura,
> 
> 
> On Thu, 17 Feb 2005 12:21:27 -0800 (PST), Laura Ramirez
> <lra...@ka...> wrote:
> 
>>Hi Aneesh,
>>
>>As John stated, the current intent for clusterproc hooks is not to
>>have cluster directory in the kernel tree, which is why we cant
>>have cluster/Kconfig or cluster/dummy.c files.  Actually, the
>>dummy routines in cproc_init.c are just temporary, place holders
>>to know which hooks need to be implemented.  In the end, when all
>>the hooks are finished there shouldnt be any dummy routines in the
>>cproc_init.c file.
>>
>>
> 
> 
> The idea of the patch was to enable other cproc modules to start
> working. I guess we should not implement dummy_clusterproc routines
> inside openssi cproc. Rather they should go in dummy.c and then use
> the set_to_dummy_if_null macro to set all the null operations to dummy
> operations. Also we don't want to export the clusterproc_operations
> structure. I guess we should GPL export register_clusterproc.
> 
> BTW all the above was derived looking at how security ( LSM ) module is done. 

Given what Bruce heard at LinuxWorld, we will probably use this.

I note the selinux directory in the security directory is empty in the 
vanilla kernel tree.

> 
> Regarding the file location. I guess we should aim at having a place
> holder inside the vanilla kernel tree. But yes we should place the
> code in side the vanilla tree and aim at building as module.
> Arraingnig the code outside the tree and then building it as module
> will set a notion that we like to remain outside the vanilla tree
> which i believe is not the intent.

I disagree. The goal at the moment is to sell the hooks to the Linux 
community, not SSI. Bruce is busily trying to get other clustering 
groups interested in supporting them. What Bruce would like to see are 
all distro kernels shipped with the hooks enabled and being able to 
install SSI without having to reinstall the kernel.

> 
> I would say we need to say we are going to sit under linux/cluster  as
> 
> linux/cluster/cproc/dummy.c
> linux/cluster/cproc/openssi/<openssi cproc module>
> linux/cluster/ci
> linux/cluster/clms 
> 
> And you can build openssi_cproc ci and clms all as module 
> 
> If you are interested i can rearrange the code to get everything build
> as above.

If you can convince Bruce, fine. I see no benefit in doing anything in 
the base tree except the "dummy" ops at this time.


John