[sserver-bugs] [ sserver-Bugs-566473 ] minor bug in tackle

[<no...@so...>]

Bugs item #566473, was opened at 2002-06-09 16:01
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=380760&aid=566473&group_id=24184

Category: Server
Group: None
Status: Open
Resolution: Later
Priority: 5
Submitted By: Ken Nguyen (kennguyen)
>Assigned to: Michael Gollin (michaelgollin)
Summary: minor bug in tackle

Initial Comment:
this is a minor "bug" in the server code implementing
the tackle.

In player.cc, in the Player::tackle( const double&
power ) function, the calculation for the fail
probability is:

double prob = ( pow( player_2_ball.x / tackle_dist, 
ServerParam::instance().tackleExponent() ) 
                      + pow( fabs( player_2_ball.y ) /
ServerParam::instance().tackleWidth(),
ServerParam::instance().tackleExponent() ) );

If player_2_ball.x < 0 and tackleExponent() is odd,
then pow( player_2_ball.x / tackle_dist, 
ServerParam::instance().tackleExponent() ) will be < 0.

forutnately, tackleExponent() == 6, so there is no
problem at the moment. But if tackleExponent() is ever
an odd number (say, in the future), then the first bit
of the fail probability will be negative, which could
mean the fail prob could might be negative.

Solution: like player_2_ball.y, you should fabs
player_2_ball.x, ie. have:

pow( fabs( player_2_ball.x ) / tackle_dist, 
ServerParam::instance().tackleExponent() )

----------------------------------------------------------------------

Comment By: Tom Howard (tomhoward)
Date: 2002-06-20 11:49

Message:
Logged In: YES 
user_id=189676

Sorry.  Update wrong bug report


----------------------------------------------------------------------

Comment By: Tom Howard (tomhoward)
Date: 2002-06-20 11:41

Message:
Logged In: YES 
user_id=189676

Fixed and commited.  8.05.10 will be avaialble ASAP.


----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=380760&aid=566473&group_id=24184