#94 Leftbox_Items Inconsistency

open-accepted
Squishdot (86)
5
2003-04-30
2003-04-28
Alex Harden
No

In Squishdot 1.5.0, the default index_html parses each
record in the leftbox_items table with these statements:
<dtml-in leftbox_items>
 <A href="<dtml-if relurl><dtml-var site_url
></dtml-if><dtml-var urlname>"><dtml-var
name></A><BR>
</dtml-in>

In addPostingForm and posting_html, the table is
parsed this way:
<dtml-in leftbox_items>
 <A href="<dtml-if relurl><dtml-var site_url
></dtml-if><dtml-var urlname url_quote>"><dtml-var
name></A><BR>
</dtml-in>

The extra "url_quote" present in the second example
produces incorrect URLs for records where the relurl is
0. It appends the base site URL onto the full URL
located in the urlname field of the record.

I think the code in the addPostingForm and
posting_html methods should be altered to work like the
related code in the index_html method. I have applied
these changes to my site (http://alexharden.org/) and it
has worked.

Discussion

  • Chris Withers

    Chris Withers - 2003-04-30
    • milestone: 102099 -->
    • assigned_to: nobody --> fresh
    • status: open --> open-accepted
     
  • Chris Withers

    Chris Withers - 2003-04-30

    Logged In: YES
    user_id=24723

    Can you provide diff -u patches for these problems?

    If so, I'd be happy to apply them :-)

    Chris

     

Log in to post a comment.