#353 Various notices when viewing messages

closed-out-of-date
nobody
5
2005-02-08
2004-12-01
Anonymous
No

Submitted by : Rob Sterenborg / rob@sterenborg.info.

When viewing singlepart messages, I got notices on screen :
"Notice: Trying to get property of non-object in
/<path-to>/class/mime/Message.class.php". This about
$this->header->disposition->name.

Also, in $ent->header->parameters['filename'] and
$ent->header->parameters['name'], $ent was not defined.
Modifying it to $this should solve that.

Of course it's possible to suppress those messages but
since that's ugly I changed $ent to $this where $ent
was not defined and put in extra checks to see if
$this->header->disposition->name exists. If it doesn't
it won't be checked by the following if statement.

The attached file works for me.

Discussion

  • Nobody/Anonymous

    Fixed Message.class.php

     
  • Thijs Kinkhorst

    Thijs Kinkhorst - 2005-02-06

    Logged In: YES
    user_id=285765

    Thank you for your report, although we need a bit more
    information in order to fix it:

    - Which SquirrelMail version are you using?
    - Which PHP version are you using?
    - Can you please provide a patch (diff -u) instead of the
    complete file?
    - If possible, can you paste the complete and exact notices
    you get?

     
  • Thijs Kinkhorst

    Thijs Kinkhorst - 2005-02-08

    Logged In: YES
    user_id=285765

    Reporter says errors have disappeared after upgrading, closing.

     
  • Thijs Kinkhorst

    Thijs Kinkhorst - 2005-02-08
    • status: open --> closed-out-of-date
     

Log in to post a comment.

Get latest updates about Open Source Projects, Conferences and News.

Sign up for the SourceForge newsletter:





No, thanks