squirrelmail-users — SquirrelMail Users Mailing List

Re: [SM-USERS] Images not being displayed

[Paul L. <pa...@sq...>]

Harold,

On Mon, May 1, 2023 5:18 pm, Harold Hallikainen wrote:
> It looks like I've been using SquirrelMail for a little over 20 years. I
> am currently using version 1.4.23. Recently I have noticed that images in
> emails do not show up when "display unsafe images" (or similar) is
> selected. This seems to be the case on bulk emails. Most of the time,
> images show properly, but for a couple senders, they have stopped being
> displayed.

You'll probably need to share a sample of said message source, since it's
hard to guess otherwise.

[SM-USERS] Images not being displayed

[Harold H. <ha...@ha...>]

It looks like I've been using SquirrelMail for a little over 20 years. I
am currently using version 1.4.23. Recently I have noticed that images in
emails do not show up when "display unsafe images" (or similar) is
selected. This seems to be the case on bulk emails. Most of the time,
images show properly, but for a couple senders, they have stopped being
displayed.

Ideas?

Thanks!

Harold

Re: [SM-USERS] Which version of squirrelmail?

[Paul L. <pa...@sq...>]

On Sat, February 18, 2023 3:21 am, Alex wrote:
> Hi, I'm sorry for the continuous emails - I'm trying to do this in
> real-time.
>
> The session_regenerate_id() errors I reported above appear to be only
> related to the lockout plugin.
>
> I've had to disable it for now. Please let me know if there's something I
> can do to troubleshoot it further.

The warning: "Warning: session_regenerate_id(): Session ID cannot be
regenerated after headers have already been sent" is a byproduct of you
having display_errors turned on and is not a problem itself.  The prefs
questions I asked earlier should be all you need to respond to pending
what we find out from there.

-- 
Paul Lesniewski
SquirrelMail Team
Please support Open Source Software by donating to SquirrelMail!
http://squirrelmail.org/donate_paul_lesniewski.php


> On Fri, Feb 17, 2023 at 10:15 PM Alex <mys...@gm...> wrote:
>
>> Here is a collection of other errors, most of which appear to be related
>> to problems with plugins
>>
>> Deprecated: Automatic conversion of false to array is deprecated in
>> /usr/share/squirrelmail-stable-1.4.23-svn-021723/functions/file_prefs.php
>> on line 74
>> Warning: session_regenerate_id(): Session ID cannot be regenerated after
>> headers have already been sent in
>> /usr/share/squirrelmail-stable-1.4.23-svn-021723/src/redirect.php on
>> line
>> 123
>> Warning: Cannot modify header information - headers already sent by
>> (output started at
>> /usr/share/squirrelmail-stable-1.4.23-svn-021723/functions/file_prefs.php:74)
>> in /usr/share/squirrelmail-stable-1.4.23-svn-021723/functions/global.php
>> on
>> line 600
>> Deprecated: Automatic conversion of false to array is deprecated in
>> /usr/share/squirrelmail-stable-1.4.23-svn-021723/functions/file_prefs.php
>> on line 74
>> Deprecated: Automatic conversion of false to array is deprecated in
>> /usr/share/squirrelmail-stable-1.4.23-svn-021723/functions/file_prefs.php
>> on line 74
>> Warning: Cannot modify header information - headers already sent by
>> (output started at
>> /usr/share/squirrelmail-stable-1.4.23-svn-021723/functions/file_prefs.php:74)
>> in /usr/share/squirrelmail-stable-1.4.23-svn-021723/src/redirect.php on
>> line 233
>>
>> Thanks,
>> Alex
>>
>>
>>
>>
>> On Fri, Feb 17, 2023 at 9:49 PM Alex <mys...@gm...> wrote:
>>
>>> This looks to fix the previous error (it's an error, as it prevents the
>>> saving of the new chosen theme)
>>>
>>> --- functions/options.php-str_replace   2023-02-17 21:29:06.106629935
>>> -0500
>>> +++ functions/options.php       2023-02-17 21:43:35.453838437 -0500
>>> @@ -1236,7 +1236,7 @@
>>>      // all other widgets except TEXTAREAs should never be allowed to
>>> have newlines
>>>      //
>>>      else if ($option->type != SMOPT_TYPE_TEXTAREA)
>>> -        $option->new_value = str_replace(array("\r", "\n"), '',
>>> $option->new_value);
>>> +        $option->new_value = str_replace(array("\r", "\n"), '',
>>> (string)
>>> $option->new_value);
>>>
>>>
>>>      global $data_dir;
>>>
>>>
>>>
>>> On Fri, Feb 17, 2023 at 9:25 PM Alex <mys...@gm...> wrote:
>>>
>>>> Hi Paul, thanks so much for your help. Here is one of the warnings I'm
>>>> receiving with the latest 1.4.23-svn, even after making sure
>>>> display_errors
>>>> is disabled (it always was) and now also disabled
>>>> display_startup_errors.
>>>>
>>>> Deprecated: str_replace(): Passing null to parameter #3 ($subject) of
>>>> type array|string is deprecated in
>>>> /usr/share/squirrelmail-021223/functions/options.php on line 1239
>>>> Warning: Cannot modify header information - headers already sent by
>>>> (output started at
>>>> /usr/share/squirrelmail-021223/functions/options.php:1239) in
>>>> /usr/share/squirrelmail-021223/functions/page_header.php on line 69
>>>>
>>>> This happened when I chose a different theme.
>>>>
>>>>
>>>> On Fri, Feb 17, 2023 at 9:25 AM Paul Lesniewski
>>>> <pa...@sq...>
>>>> wrote:
>>>>
>>>>> Alex,
>>>>>
>>>>> On Fri, February 17, 2023 2:14 pm, Alex wrote:
>>>>> > Hi, I'm struggling with getting SM working properly. I previously
>>>>> reported
>>>>> > that I started using the version from SVN:
>>>>> >
>>>>> > Does the 1.4 tree have support for php-8.1 (yet)?
>>>>>
>>>>> So far, you've posted deprecation warnings.  Please note that those
>>>>> are
>>>>> *not* incompatibilities.  The actual problem is that you appear to
>>>>> have
>>>>> enabled display_errors in a production environment, which is not
>>>>> something
>>>>> you should be using.
>>>>>
>>>>> Of course, we do want to see deprecation warnings and we will fix
>>>>> those,
>>>>> so please send us whatever you see, and they'll be fixed as soon as
>>>>> time
>>>>> allows.
>>>>>
>>>>> --
>>>>> Paul Lesniewski
>>>>> SquirrelMail Team
>>>>> Please support Open Source Software by donating to SquirrelMail!
>>>>> http://squirrelmail.org/donate_paul_lesniewski.php
>>>>>
>>>>>

Re: [SM-USERS] Which version of squirrelmail?

[Paul L. <pa...@sq...>]

On Sat, February 18, 2023 3:15 am, Alex wrote:
> Here is a collection of other errors, most of which appear to be related
> to
> problems with plugins

I see no references to any plugins here, can you explain what you mean? 
These are all just repeats of this:

> Deprecated: Automatic conversion of false to array is deprecated in
> /usr/share/squirrelmail-stable-1.4.23-svn-021723/functions/file_prefs.php
> on line 74

Which was addressed in my earlier email.  Unless there are other notices,
then these are considered tentatively solved.

-- 
Paul Lesniewski
SquirrelMail Team
Please support Open Source Software by donating to SquirrelMail!
http://squirrelmail.org/donate_paul_lesniewski.php


> Warning: session_regenerate_id(): Session ID cannot be regenerated after
> headers have already been sent in
> /usr/share/squirrelmail-stable-1.4.23-svn-021723/src/redirect.php on line
> 123
> Warning: Cannot modify header information - headers already sent by
> (output
> started at
> /usr/share/squirrelmail-stable-1.4.23-svn-021723/functions/file_prefs.php:74)
> in /usr/share/squirrelmail-stable-1.4.23-svn-021723/functions/global.php
> on
> line 600
> Deprecated: Automatic conversion of false to array is deprecated in
> /usr/share/squirrelmail-stable-1.4.23-svn-021723/functions/file_prefs.php
> on line 74
> Deprecated: Automatic conversion of false to array is deprecated in
> /usr/share/squirrelmail-stable-1.4.23-svn-021723/functions/file_prefs.php
> on line 74
> Warning: Cannot modify header information - headers already sent by
> (output
> started at
> /usr/share/squirrelmail-stable-1.4.23-svn-021723/functions/file_prefs.php:74)
> in /usr/share/squirrelmail-stable-1.4.23-svn-021723/src/redirect.php on
> line 233
>
> Thanks,
> Alex
>
>
>
>
> On Fri, Feb 17, 2023 at 9:49 PM Alex <mys...@gm...> wrote:
>
>> This looks to fix the previous error (it's an error, as it prevents the
>> saving of the new chosen theme)
>>
>> --- functions/options.php-str_replace   2023-02-17 21:29:06.106629935
>> -0500
>> +++ functions/options.php       2023-02-17 21:43:35.453838437 -0500
>> @@ -1236,7 +1236,7 @@
>>      // all other widgets except TEXTAREAs should never be allowed to
>> have
>> newlines
>>      //
>>      else if ($option->type != SMOPT_TYPE_TEXTAREA)
>> -        $option->new_value = str_replace(array("\r", "\n"), '',
>> $option->new_value);
>> +        $option->new_value = str_replace(array("\r", "\n"), '',
>> (string)
>> $option->new_value);
>>
>>
>>      global $data_dir;
>>
>>
>>
>> On Fri, Feb 17, 2023 at 9:25 PM Alex <mys...@gm...> wrote:
>>
>>> Hi Paul, thanks so much for your help. Here is one of the warnings I'm
>>> receiving with the latest 1.4.23-svn, even after making sure
>>> display_errors
>>> is disabled (it always was) and now also disabled
>>> display_startup_errors.
>>>
>>> Deprecated: str_replace(): Passing null to parameter #3 ($subject) of
>>> type array|string is deprecated in
>>> /usr/share/squirrelmail-021223/functions/options.php on line 1239
>>> Warning: Cannot modify header information - headers already sent by
>>> (output started at
>>> /usr/share/squirrelmail-021223/functions/options.php:1239) in
>>> /usr/share/squirrelmail-021223/functions/page_header.php on line 69
>>>
>>> This happened when I chose a different theme.
>>>
>>>
>>> On Fri, Feb 17, 2023 at 9:25 AM Paul Lesniewski <pa...@sq...>
>>> wrote:
>>>
>>>> Alex,
>>>>
>>>> On Fri, February 17, 2023 2:14 pm, Alex wrote:
>>>> > Hi, I'm struggling with getting SM working properly. I previously
>>>> reported
>>>> > that I started using the version from SVN:
>>>> >
>>>> > Does the 1.4 tree have support for php-8.1 (yet)?
>>>>
>>>> So far, you've posted deprecation warnings.  Please note that those
>>>> are
>>>> *not* incompatibilities.  The actual problem is that you appear to
>>>> have
>>>> enabled display_errors in a production environment, which is not
>>>> something
>>>> you should be using.
>>>>
>>>> Of course, we do want to see deprecation warnings and we will fix
>>>> those,
>>>> so please send us whatever you see, and they'll be fixed as soon as
>>>> time
>>>> allows.
>>>>
>>>> --
>>>> Paul Lesniewski
>>>> SquirrelMail Team
>>>> Please support Open Source Software by donating to SquirrelMail!
>>>> http://squirrelmail.org/donate_paul_lesniewski.php
>>>>
>>>>
>>>>
>>>>
>>>> -----
>>>> squirrelmail-users mailing list
>>>> Posting guidelines: http://squirrelmail.org/postingguidelines
>>>> List address: squ...@li...
>>>> List archives: http://news.gmane.org/gmane.mail.squirrelmail.user
>>>> List info (subscribe/unsubscribe/change options):
>>>> https://lists.sourceforge.net/lists/listinfo/squirrelmail-users
>>>>
>>>
>

Re: [SM-USERS] Which version of squirrelmail?

[Paul L. <pa...@sq...>]

On Sat, February 18, 2023 2:25 am, Alex wrote:
> Hi Paul, thanks so much for your help. Here is one of the warnings I'm
> receiving with the latest 1.4.23-svn, even after making sure
> display_errors
> is disabled (it always was) and now also disabled display_startup_errors.

I can't know how you set up PHP, but the only way for you to get the
warning messages (about headers) you've shown is for display_errors to be
turned on.  Production sites should never show their PHP errors on screen.
 For development and debugging, it can be helpful (though not as much as
logs).

> Deprecated: str_replace(): Passing null to parameter #3 ($subject) of type
> array|string is deprecated in
> /usr/share/squirrelmail-021223/functions/options.php on line 1239

This should now be fixed

-- 
Paul Lesniewski
SquirrelMail Team
Please support Open Source Software by donating to SquirrelMail!
http://squirrelmail.org/donate_paul_lesniewski.php



> Warning: Cannot modify header information - headers already sent by
> (output
> started at /usr/share/squirrelmail-021223/functions/options.php:1239) in
> /usr/share/squirrelmail-021223/functions/page_header.php on line 69
>
> This happened when I chose a different theme.
>
>
> On Fri, Feb 17, 2023 at 9:25 AM Paul Lesniewski <pa...@sq...>
> wrote:
>
>> Alex,
>>
>> On Fri, February 17, 2023 2:14 pm, Alex wrote:
>> > Hi, I'm struggling with getting SM working properly. I previously
>> reported
>> > that I started using the version from SVN:
>> >
>> > Does the 1.4 tree have support for php-8.1 (yet)?
>>
>> So far, you've posted deprecation warnings.  Please note that those are
>> *not* incompatibilities.  The actual problem is that you appear to have
>> enabled display_errors in a production environment, which is not
>> something
>> you should be using.
>>
>> Of course, we do want to see deprecation warnings and we will fix those,
>> so please send us whatever you see, and they'll be fixed as soon as time
>> allows.
>>
>> --
>> Paul Lesniewski
>> SquirrelMail Team
>> Please support Open Source Software by donating to SquirrelMail!
>> http://squirrelmail.org/donate_paul_lesniewski.php
>>
>>
>>
>>
>> -----
>> squirrelmail-users mailing list
>> Posting guidelines: http://squirrelmail.org/postingguidelines
>> List address: squ...@li...
>> List archives: http://news.gmane.org/gmane.mail.squirrelmail.user
>> List info (subscribe/unsubscribe/change options):
>> https://lists.sourceforge.net/lists/listinfo/squirrelmail-users
>>
>

Re: [SM-USERS] Deprecated: Automatic conversion of false to array is deprecated

[Paul L. <pa...@sq...>]

Alex,

I just added a small change to file_prefs.php that might address this
problem.  The odd part about your seeing these notices is that the proper
initialization should have taken place in prefs.php line 32.  If you'd
like to help us, you can do one or both of the following:

* Test the next build of 1.4.23-svn (without your patches)
* On line 25 you can dump out $_SESSION and $prefs_cache at least under
circumstances when you are sure the error will happen (first login?)...
ideally use var_dump() but sm_print_r() might be helpful too

Also, it helps to know what actions are needed to reproduce the notices.

-- 
Paul Lesniewski
SquirrelMail Team
Please support Open Source Software by donating to SquirrelMail!
http://squirrelmail.org/donate_paul_lesniewski.php


On Tue, February 14, 2023 12:24 pm, Alex wrote:
> Hi, this appears to be another issue related to php-8.1 compatibility. I
> think this fixes it.
>
> --- functions/file_prefs.php-foreach    2023-02-13 19:09:58.956959936
> -0500
> +++ functions/file_prefs.php    2023-02-13 19:10:10.975099888 -0500
> @@ -125,7 +125,7 @@
>          logout_error( sprintf( _("Preference file, %s, could not be
> opened. Contact your system administrator to resolve this issue."),
> $filename.'.tmp') );
>          exit;
>      }
> -    foreach ($prefs_cache as $Key => $Value) {
> +    foreach ((array) $prefs_cache as $Key => $Value) {
>          if (isset($Value)) {
>              if ( sq_fwrite($file, $Key . '=' . $Value . "\n") === FALSE )
> {
>                 logout_error( sprintf( _("Preference file, %s, could not
> be
> written. Contact your system administrator to resolve this issue.") ,
> $filename . '.tmp') );
>
>
> On Sun, Feb 12, 2023 at 2:12 PM Alex <mys...@gm...> wrote:
>
>> Hi, I think this is all that's necessary to fix the problem, but I'm not
>> a
>> php developer, so I don't know if it's complete:
>>
>> diff -u squirrelmail.stable/functions/file_prefs.php
>> squirrelmail-021223/functions/file_prefs.php
>> --- squirrelmail.stable/functions/file_prefs.php        2023-01-02
>> 20:22:36.000000000 -0500
>> +++ squirrelmail-021223/functions/file_prefs.php        2023-02-12
>> 14:08:13.590538709 -0500
>> @@ -71,6 +71,7 @@
>>              }
>>
>>              if ($value != '') {
>> +               $prefs_cache = [];
>>                  $prefs_cache[$key] = $value;
>>              }
>>          }
>>
>>
>>
>> On Sun, Feb 12, 2023 at 12:13 PM Alex <mys...@gm...> wrote:
>>
>>> Hi, following up with my previous email -
>>>
>>> It does look like there's still a problem. After installing the lockout
>>> and compatibility plugin, it produces these deprecated errors:
>>>
>>> Deprecated: Automatic conversion of false to array is deprecated in
>>> /usr/share/squirrelmail/functions/file_prefs.php on line 74
>>> Warning: session_regenerate_id(): Session ID cannot be regenerated
>>> after
>>> headers have already been sent in
>>> /usr/share/squirrelmail/src/redirect.php
>>> on line 123
>>> Warning: Cannot modify header information - headers already sent by
>>> (output started at /usr/share/squirrelmail/functions/file_prefs.php:74)
>>> in
>>> /usr/share/squirrelmail/functions/global.php on line 600
>>> Deprecated: Automatic conversion of false to array is deprecated in
>>> /usr/share/squirrelmail/functions/file_prefs.php on line 74
>>> Deprecated: Automatic conversion of false to array is deprecated in
>>> /usr/share/squirrelmail/functions/file_prefs.php on line 74
>>> Warning: Cannot modify header information - headers already sent by
>>> (output started at /usr/share/squirrelmail/functions/file_prefs.php:74)
>>> in
>>> /usr/share/squirrelmail/src/redirect.php on line 233
>>>
>>> Thanks,
>>> Alex
>>>
>>>
>>> On Sun, Feb 12, 2023 at 11:36 AM Alex <mys...@gm...> wrote:
>>>
>>>> Hi, okay, I figured it out, thankfully. While I had a recent svn
>>>> 1.4.23
>>>> snapshot, apparently it wasn't recent enough. The one from today (Feb
>>>> 12,
>>>> 2023) works.
>>>>
>>>> What is the proper way to upgrade squirrelmail? I've just been
>>>> building
>>>> two separate trees and manually going through each to identify
>>>> differences
>>>> using diff or entire directories at a time, but is there a better way?
>>>> I
>>>> don't think I've properly migrated all the plugins, for example,
>>>> including
>>>> the configuration of each...
>>>>
>>>>
>>>>
>>>> On Sun, Feb 12, 2023 at 11:02 AM Alex <mys...@gm...> wrote:
>>>>
>>>>> Hi, I'm using 1.4.22 on fedora36 with php-8.1 and receiving the
>>>>> following errors. I thought SM supported php-8? Or is it a different
>>>>> problem? This happens after logging in and redirect.php being loaded.
>>>>>
>>>>> I shouldn't have done this on a production machine, so I'm really
>>>>> hoping there's an easy fix :-(
>>>>>
>>>>> Deprecated: Automatic conversion of false to array is deprecated in
>>>>> /usr/share/squirrelmail/functions/file_prefs.php on line 74
>>>>>
>>>>> Warning: session_regenerate_id(): Session ID cannot be regenerated
>>>>> after headers have already been sent in
>>>>> /usr/share/squirrelmail/src/redirect.php on line 123
>>>>>
>>>>> Warning: Cannot modify header information - headers already sent by
>>>>> (output started at
>>>>> /usr/share/squirrelmail/functions/file_prefs.php:74) in
>>>>> /usr/share/squirrelmail/functions/global.php on line 600
>>>>>
>>>>> Deprecated: Automatic conversion of false to array is deprecated in
>>>>> /usr/share/squirrelmail/functions/file_prefs.php on line 74
>>>>>
>>>>> Deprecated: Automatic conversion of false to array is deprecated in
>>>>> /usr/share/squirrelmail/functions/file_prefs.php on line 74
>>>>>
>>>>> Warning: Cannot modify header information - headers already sent by
>>>>> (output started at
>>>>> /usr/share/squirrelmail/functions/file_prefs.php:74) in
>>>>> /usr/share/squirrelmail/src/redirect.php on line 233
>>>>>
>>>>
>
> -----
> squirrelmail-users mailing list
> Posting guidelines: http://squirrelmail.org/postingguidelines
> List address: squ...@li...
> List archives: http://news.gmane.org/gmane.mail.squirrelmail.user
> List info (subscribe/unsubscribe/change options):
> https://lists.sourceforge.net/lists/listinfo/squirrelmail-users
>

[SM-USERS] Migrating v1.4 themes to v1.5?

[Alex <mys...@gm...>]

Hi, does there exist a basic migration tool to convert existing v1.4 themes
to v1.5? Something that would convert the $color[0] to their CSS
equivalents and create the new directory structure?

How hard would this be to automate? It seems an awful shame to have 20+
different themes for v1.4 and only a small handful by default for v1.5.
Certainly v1.5 has a lot more flexibility for creating themes, but
something basic would be fine to start.

I just can't take away functionality from users with an upgrade.

Re: [SM-USERS] Which version of squirrelmail?

[Alex <mys...@gm...>]

Hi, I'm sorry for the continuous emails - I'm trying to do this in
real-time.

The session_regenerate_id() errors I reported above appear to be only
related to the lockout plugin.

I've had to disable it for now. Please let me know if there's something I
can do to troubleshoot it further.



On Fri, Feb 17, 2023 at 10:15 PM Alex <mys...@gm...> wrote:

> Here is a collection of other errors, most of which appear to be related
> to problems with plugins
>
> Deprecated: Automatic conversion of false to array is deprecated in
> /usr/share/squirrelmail-stable-1.4.23-svn-021723/functions/file_prefs.php
> on line 74
> Warning: session_regenerate_id(): Session ID cannot be regenerated after
> headers have already been sent in
> /usr/share/squirrelmail-stable-1.4.23-svn-021723/src/redirect.php on line
> 123
> Warning: Cannot modify header information - headers already sent by
> (output started at
> /usr/share/squirrelmail-stable-1.4.23-svn-021723/functions/file_prefs.php:74)
> in /usr/share/squirrelmail-stable-1.4.23-svn-021723/functions/global.php on
> line 600
> Deprecated: Automatic conversion of false to array is deprecated in
> /usr/share/squirrelmail-stable-1.4.23-svn-021723/functions/file_prefs.php
> on line 74
> Deprecated: Automatic conversion of false to array is deprecated in
> /usr/share/squirrelmail-stable-1.4.23-svn-021723/functions/file_prefs.php
> on line 74
> Warning: Cannot modify header information - headers already sent by
> (output started at
> /usr/share/squirrelmail-stable-1.4.23-svn-021723/functions/file_prefs.php:74)
> in /usr/share/squirrelmail-stable-1.4.23-svn-021723/src/redirect.php on
> line 233
>
> Thanks,
> Alex
>
>
>
>
> On Fri, Feb 17, 2023 at 9:49 PM Alex <mys...@gm...> wrote:
>
>> This looks to fix the previous error (it's an error, as it prevents the
>> saving of the new chosen theme)
>>
>> --- functions/options.php-str_replace   2023-02-17 21:29:06.106629935
>> -0500
>> +++ functions/options.php       2023-02-17 21:43:35.453838437 -0500
>> @@ -1236,7 +1236,7 @@
>>      // all other widgets except TEXTAREAs should never be allowed to
>> have newlines
>>      //
>>      else if ($option->type != SMOPT_TYPE_TEXTAREA)
>> -        $option->new_value = str_replace(array("\r", "\n"), '',
>> $option->new_value);
>> +        $option->new_value = str_replace(array("\r", "\n"), '', (string)
>> $option->new_value);
>>
>>
>>      global $data_dir;
>>
>>
>>
>> On Fri, Feb 17, 2023 at 9:25 PM Alex <mys...@gm...> wrote:
>>
>>> Hi Paul, thanks so much for your help. Here is one of the warnings I'm
>>> receiving with the latest 1.4.23-svn, even after making sure display_errors
>>> is disabled (it always was) and now also disabled display_startup_errors.
>>>
>>> Deprecated: str_replace(): Passing null to parameter #3 ($subject) of
>>> type array|string is deprecated in
>>> /usr/share/squirrelmail-021223/functions/options.php on line 1239
>>> Warning: Cannot modify header information - headers already sent by
>>> (output started at
>>> /usr/share/squirrelmail-021223/functions/options.php:1239) in
>>> /usr/share/squirrelmail-021223/functions/page_header.php on line 69
>>>
>>> This happened when I chose a different theme.
>>>
>>>
>>> On Fri, Feb 17, 2023 at 9:25 AM Paul Lesniewski <pa...@sq...>
>>> wrote:
>>>
>>>> Alex,
>>>>
>>>> On Fri, February 17, 2023 2:14 pm, Alex wrote:
>>>> > Hi, I'm struggling with getting SM working properly. I previously
>>>> reported
>>>> > that I started using the version from SVN:
>>>> >
>>>> > Does the 1.4 tree have support for php-8.1 (yet)?
>>>>
>>>> So far, you've posted deprecation warnings.  Please note that those are
>>>> *not* incompatibilities.  The actual problem is that you appear to have
>>>> enabled display_errors in a production environment, which is not
>>>> something
>>>> you should be using.
>>>>
>>>> Of course, we do want to see deprecation warnings and we will fix those,
>>>> so please send us whatever you see, and they'll be fixed as soon as time
>>>> allows.
>>>>
>>>> --
>>>> Paul Lesniewski
>>>> SquirrelMail Team
>>>> Please support Open Source Software by donating to SquirrelMail!
>>>> http://squirrelmail.org/donate_paul_lesniewski.php
>>>>
>>>>
>>>>
>>>>
>>>> -----
>>>> squirrelmail-users mailing list
>>>> Posting guidelines: http://squirrelmail.org/postingguidelines
>>>> List address: squ...@li...
>>>> List archives: http://news.gmane.org/gmane.mail.squirrelmail.user
>>>> List info (subscribe/unsubscribe/change options):
>>>> https://lists.sourceforge.net/lists/listinfo/squirrelmail-users
>>>>
>>>

Re: [SM-USERS] Which version of squirrelmail?

[Alex <mys...@gm...>]

Here is a collection of other errors, most of which appear to be related to
problems with plugins

Deprecated: Automatic conversion of false to array is deprecated in
/usr/share/squirrelmail-stable-1.4.23-svn-021723/functions/file_prefs.php
on line 74
Warning: session_regenerate_id(): Session ID cannot be regenerated after
headers have already been sent in
/usr/share/squirrelmail-stable-1.4.23-svn-021723/src/redirect.php on line
123
Warning: Cannot modify header information - headers already sent by (output
started at
/usr/share/squirrelmail-stable-1.4.23-svn-021723/functions/file_prefs.php:74)
in /usr/share/squirrelmail-stable-1.4.23-svn-021723/functions/global.php on
line 600
Deprecated: Automatic conversion of false to array is deprecated in
/usr/share/squirrelmail-stable-1.4.23-svn-021723/functions/file_prefs.php
on line 74
Deprecated: Automatic conversion of false to array is deprecated in
/usr/share/squirrelmail-stable-1.4.23-svn-021723/functions/file_prefs.php
on line 74
Warning: Cannot modify header information - headers already sent by (output
started at
/usr/share/squirrelmail-stable-1.4.23-svn-021723/functions/file_prefs.php:74)
in /usr/share/squirrelmail-stable-1.4.23-svn-021723/src/redirect.php on
line 233

Thanks,
Alex




On Fri, Feb 17, 2023 at 9:49 PM Alex <mys...@gm...> wrote:

> This looks to fix the previous error (it's an error, as it prevents the
> saving of the new chosen theme)
>
> --- functions/options.php-str_replace   2023-02-17 21:29:06.106629935 -0500
> +++ functions/options.php       2023-02-17 21:43:35.453838437 -0500
> @@ -1236,7 +1236,7 @@
>      // all other widgets except TEXTAREAs should never be allowed to have
> newlines
>      //
>      else if ($option->type != SMOPT_TYPE_TEXTAREA)
> -        $option->new_value = str_replace(array("\r", "\n"), '',
> $option->new_value);
> +        $option->new_value = str_replace(array("\r", "\n"), '', (string)
> $option->new_value);
>
>
>      global $data_dir;
>
>
>
> On Fri, Feb 17, 2023 at 9:25 PM Alex <mys...@gm...> wrote:
>
>> Hi Paul, thanks so much for your help. Here is one of the warnings I'm
>> receiving with the latest 1.4.23-svn, even after making sure display_errors
>> is disabled (it always was) and now also disabled display_startup_errors.
>>
>> Deprecated: str_replace(): Passing null to parameter #3 ($subject) of
>> type array|string is deprecated in
>> /usr/share/squirrelmail-021223/functions/options.php on line 1239
>> Warning: Cannot modify header information - headers already sent by
>> (output started at
>> /usr/share/squirrelmail-021223/functions/options.php:1239) in
>> /usr/share/squirrelmail-021223/functions/page_header.php on line 69
>>
>> This happened when I chose a different theme.
>>
>>
>> On Fri, Feb 17, 2023 at 9:25 AM Paul Lesniewski <pa...@sq...>
>> wrote:
>>
>>> Alex,
>>>
>>> On Fri, February 17, 2023 2:14 pm, Alex wrote:
>>> > Hi, I'm struggling with getting SM working properly. I previously
>>> reported
>>> > that I started using the version from SVN:
>>> >
>>> > Does the 1.4 tree have support for php-8.1 (yet)?
>>>
>>> So far, you've posted deprecation warnings.  Please note that those are
>>> *not* incompatibilities.  The actual problem is that you appear to have
>>> enabled display_errors in a production environment, which is not
>>> something
>>> you should be using.
>>>
>>> Of course, we do want to see deprecation warnings and we will fix those,
>>> so please send us whatever you see, and they'll be fixed as soon as time
>>> allows.
>>>
>>> --
>>> Paul Lesniewski
>>> SquirrelMail Team
>>> Please support Open Source Software by donating to SquirrelMail!
>>> http://squirrelmail.org/donate_paul_lesniewski.php
>>>
>>>
>>>
>>>
>>> -----
>>> squirrelmail-users mailing list
>>> Posting guidelines: http://squirrelmail.org/postingguidelines
>>> List address: squ...@li...
>>> List archives: http://news.gmane.org/gmane.mail.squirrelmail.user
>>> List info (subscribe/unsubscribe/change options):
>>> https://lists.sourceforge.net/lists/listinfo/squirrelmail-users
>>>
>>

Re: [SM-USERS] Which version of squirrelmail?

[Alex <mys...@gm...>]

This looks to fix the previous error (it's an error, as it prevents the
saving of the new chosen theme)

--- functions/options.php-str_replace   2023-02-17 21:29:06.106629935 -0500
+++ functions/options.php       2023-02-17 21:43:35.453838437 -0500
@@ -1236,7 +1236,7 @@
     // all other widgets except TEXTAREAs should never be allowed to have
newlines
     //
     else if ($option->type != SMOPT_TYPE_TEXTAREA)
-        $option->new_value = str_replace(array("\r", "\n"), '',
$option->new_value);
+        $option->new_value = str_replace(array("\r", "\n"), '', (string)
$option->new_value);


     global $data_dir;



On Fri, Feb 17, 2023 at 9:25 PM Alex <mys...@gm...> wrote:

> Hi Paul, thanks so much for your help. Here is one of the warnings I'm
> receiving with the latest 1.4.23-svn, even after making sure display_errors
> is disabled (it always was) and now also disabled display_startup_errors.
>
> Deprecated: str_replace(): Passing null to parameter #3 ($subject) of type
> array|string is deprecated in
> /usr/share/squirrelmail-021223/functions/options.php on line 1239
> Warning: Cannot modify header information - headers already sent by
> (output started at
> /usr/share/squirrelmail-021223/functions/options.php:1239) in
> /usr/share/squirrelmail-021223/functions/page_header.php on line 69
>
> This happened when I chose a different theme.
>
>
> On Fri, Feb 17, 2023 at 9:25 AM Paul Lesniewski <pa...@sq...>
> wrote:
>
>> Alex,
>>
>> On Fri, February 17, 2023 2:14 pm, Alex wrote:
>> > Hi, I'm struggling with getting SM working properly. I previously
>> reported
>> > that I started using the version from SVN:
>> >
>> > Does the 1.4 tree have support for php-8.1 (yet)?
>>
>> So far, you've posted deprecation warnings.  Please note that those are
>> *not* incompatibilities.  The actual problem is that you appear to have
>> enabled display_errors in a production environment, which is not something
>> you should be using.
>>
>> Of course, we do want to see deprecation warnings and we will fix those,
>> so please send us whatever you see, and they'll be fixed as soon as time
>> allows.
>>
>> --
>> Paul Lesniewski
>> SquirrelMail Team
>> Please support Open Source Software by donating to SquirrelMail!
>> http://squirrelmail.org/donate_paul_lesniewski.php
>>
>>
>>
>>
>> -----
>> squirrelmail-users mailing list
>> Posting guidelines: http://squirrelmail.org/postingguidelines
>> List address: squ...@li...
>> List archives: http://news.gmane.org/gmane.mail.squirrelmail.user
>> List info (subscribe/unsubscribe/change options):
>> https://lists.sourceforge.net/lists/listinfo/squirrelmail-users
>>
>

Re: [SM-USERS] Which version of squirrelmail?

[Alex <mys...@gm...>]

Hi Paul, thanks so much for your help. Here is one of the warnings I'm
receiving with the latest 1.4.23-svn, even after making sure display_errors
is disabled (it always was) and now also disabled display_startup_errors.

Deprecated: str_replace(): Passing null to parameter #3 ($subject) of type
array|string is deprecated in
/usr/share/squirrelmail-021223/functions/options.php on line 1239
Warning: Cannot modify header information - headers already sent by (output
started at /usr/share/squirrelmail-021223/functions/options.php:1239) in
/usr/share/squirrelmail-021223/functions/page_header.php on line 69

This happened when I chose a different theme.


On Fri, Feb 17, 2023 at 9:25 AM Paul Lesniewski <pa...@sq...>
wrote:

> Alex,
>
> On Fri, February 17, 2023 2:14 pm, Alex wrote:
> > Hi, I'm struggling with getting SM working properly. I previously
> reported
> > that I started using the version from SVN:
> >
> > Does the 1.4 tree have support for php-8.1 (yet)?
>
> So far, you've posted deprecation warnings.  Please note that those are
> *not* incompatibilities.  The actual problem is that you appear to have
> enabled display_errors in a production environment, which is not something
> you should be using.
>
> Of course, we do want to see deprecation warnings and we will fix those,
> so please send us whatever you see, and they'll be fixed as soon as time
> allows.
>
> --
> Paul Lesniewski
> SquirrelMail Team
> Please support Open Source Software by donating to SquirrelMail!
> http://squirrelmail.org/donate_paul_lesniewski.php
>
>
>
>
> -----
> squirrelmail-users mailing list
> Posting guidelines: http://squirrelmail.org/postingguidelines
> List address: squ...@li...
> List archives: http://news.gmane.org/gmane.mail.squirrelmail.user
> List info (subscribe/unsubscribe/change options):
> https://lists.sourceforge.net/lists/listinfo/squirrelmail-users
>

Re: [SM-USERS] Deprecated: Automatic conversion of false to array is deprecated

[Paul L. <pa...@sq...>]

On Tue, February 14, 2023 12:24 pm, Alex wrote:
> Hi, this appears to be another issue related to php-8.1 compatibility. I
> think this fixes it.
>
> --- functions/file_prefs.php-foreach    2023-02-13 19:09:58.956959936
> -0500
> +++ functions/file_prefs.php    2023-02-13 19:10:10.975099888 -0500
> @@ -125,7 +125,7 @@
>          logout_error( sprintf( _("Preference file, %s, could not be
> opened. Contact your system administrator to resolve this issue."),
> $filename.'.tmp') );
>          exit;
>      }
> -    foreach ($prefs_cache as $Key => $Value) {
> +    foreach ((array) $prefs_cache as $Key => $Value) {
>          if (isset($Value)) {
>              if ( sq_fwrite($file, $Key . '=' . $Value . "\n") === FALSE )
> {
>                 logout_error( sprintf( _("Preference file, %s, could not
> be
> written. Contact your system administrator to resolve this issue.") ,
> $filename . '.tmp') );

We appreciate that you are submitting your proposed changes, but please
post the PHP notice that you are seeing and trying to resolve for this (as
you did with the previous one), as well as any data points that will help
us reproduce the issue.

-- 
Paul Lesniewski
SquirrelMail Team
Please support Open Source Software by donating to SquirrelMail!
http://squirrelmail.org/donate_paul_lesniewski.php





> On Sun, Feb 12, 2023 at 2:12 PM Alex <mys...@gm...> wrote:
>
>> Hi, I think this is all that's necessary to fix the problem, but I'm not
>> a
>> php developer, so I don't know if it's complete:
>>
>> diff -u squirrelmail.stable/functions/file_prefs.php
>> squirrelmail-021223/functions/file_prefs.php
>> --- squirrelmail.stable/functions/file_prefs.php        2023-01-02
>> 20:22:36.000000000 -0500
>> +++ squirrelmail-021223/functions/file_prefs.php        2023-02-12
>> 14:08:13.590538709 -0500
>> @@ -71,6 +71,7 @@
>>              }
>>
>>              if ($value != '') {
>> +               $prefs_cache = [];
>>                  $prefs_cache[$key] = $value;
>>              }
>>          }
>>
>>
>>
>> On Sun, Feb 12, 2023 at 12:13 PM Alex <mys...@gm...> wrote:
>>
>>> Hi, following up with my previous email -
>>>
>>> It does look like there's still a problem. After installing the lockout
>>> and compatibility plugin, it produces these deprecated errors:
>>>
>>> Deprecated: Automatic conversion of false to array is deprecated in
>>> /usr/share/squirrelmail/functions/file_prefs.php on line 74
>>> Warning: session_regenerate_id(): Session ID cannot be regenerated
>>> after
>>> headers have already been sent in
>>> /usr/share/squirrelmail/src/redirect.php
>>> on line 123
>>> Warning: Cannot modify header information - headers already sent by
>>> (output started at /usr/share/squirrelmail/functions/file_prefs.php:74)
>>> in
>>> /usr/share/squirrelmail/functions/global.php on line 600
>>> Deprecated: Automatic conversion of false to array is deprecated in
>>> /usr/share/squirrelmail/functions/file_prefs.php on line 74
>>> Deprecated: Automatic conversion of false to array is deprecated in
>>> /usr/share/squirrelmail/functions/file_prefs.php on line 74
>>> Warning: Cannot modify header information - headers already sent by
>>> (output started at /usr/share/squirrelmail/functions/file_prefs.php:74)
>>> in
>>> /usr/share/squirrelmail/src/redirect.php on line 233
>>>
>>> Thanks,
>>> Alex
>>>
>>>
>>> On Sun, Feb 12, 2023 at 11:36 AM Alex <mys...@gm...> wrote:
>>>
>>>> Hi, okay, I figured it out, thankfully. While I had a recent svn
>>>> 1.4.23
>>>> snapshot, apparently it wasn't recent enough. The one from today (Feb
>>>> 12,
>>>> 2023) works.
>>>>
>>>> What is the proper way to upgrade squirrelmail? I've just been
>>>> building
>>>> two separate trees and manually going through each to identify
>>>> differences
>>>> using diff or entire directories at a time, but is there a better way?
>>>> I
>>>> don't think I've properly migrated all the plugins, for example,
>>>> including
>>>> the configuration of each...
>>>>
>>>>
>>>>
>>>> On Sun, Feb 12, 2023 at 11:02 AM Alex <mys...@gm...> wrote:
>>>>
>>>>> Hi, I'm using 1.4.22 on fedora36 with php-8.1 and receiving the
>>>>> following errors. I thought SM supported php-8? Or is it a different
>>>>> problem? This happens after logging in and redirect.php being loaded.
>>>>>
>>>>> I shouldn't have done this on a production machine, so I'm really
>>>>> hoping there's an easy fix :-(
>>>>>
>>>>> Deprecated: Automatic conversion of false to array is deprecated in
>>>>> /usr/share/squirrelmail/functions/file_prefs.php on line 74
>>>>>
>>>>> Warning: session_regenerate_id(): Session ID cannot be regenerated
>>>>> after headers have already been sent in
>>>>> /usr/share/squirrelmail/src/redirect.php on line 123
>>>>>
>>>>> Warning: Cannot modify header information - headers already sent by
>>>>> (output started at
>>>>> /usr/share/squirrelmail/functions/file_prefs.php:74) in
>>>>> /usr/share/squirrelmail/functions/global.php on line 600
>>>>>
>>>>> Deprecated: Automatic conversion of false to array is deprecated in
>>>>> /usr/share/squirrelmail/functions/file_prefs.php on line 74
>>>>>
>>>>> Deprecated: Automatic conversion of false to array is deprecated in
>>>>> /usr/share/squirrelmail/functions/file_prefs.php on line 74
>>>>>
>>>>> Warning: Cannot modify header information - headers already sent by
>>>>> (output started at
>>>>> /usr/share/squirrelmail/functions/file_prefs.php:74) in
>>>>> /usr/share/squirrelmail/src/redirect.php on line 233
>>>>>
>>>>
>
> -----
> squirrelmail-users mailing list
> Posting guidelines: http://squirrelmail.org/postingguidelines
> List address: squ...@li...
> List archives: http://news.gmane.org/gmane.mail.squirrelmail.user
> List info (subscribe/unsubscribe/change options):
> https://lists.sourceforge.net/lists/listinfo/squirrelmail-users
>

Re: [SM-USERS] Deprecated: Automatic conversion of false to array is deprecated

[Paul L. <pa...@sq...>]

> I'm learning that the SVN version available as a tarball is different than
> the "svn checkout" trunk version available on sf.net. I somehow missed
> that
> the SVN development version of 1.4.23 was different than the stable
> version
> of 1.4.23. This is the version that works:
>
> svn checkout
> https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail

Not clear what your question is.  The 1.4.23-svn tarballs on the website
are the same code as can be pulled directly from svn on a daily basis
(those are snapshots built every 24 hours).

-- 
Paul Lesniewski
SquirrelMail Team
Please support Open Source Software by donating to SquirrelMail!
http://squirrelmail.org/donate_paul_lesniewski.php

Re: [SM-USERS] Which version of squirrelmail?

[Paul L. <pa...@sq...>]

Alex,

On Fri, February 17, 2023 2:14 pm, Alex wrote:
> Hi, I'm struggling with getting SM working properly. I previously reported
> that I started using the version from SVN:
>
> Does the 1.4 tree have support for php-8.1 (yet)?

So far, you've posted deprecation warnings.  Please note that those are
*not* incompatibilities.  The actual problem is that you appear to have
enabled display_errors in a production environment, which is not something
you should be using.

Of course, we do want to see deprecation warnings and we will fix those,
so please send us whatever you see, and they'll be fixed as soon as time
allows.

-- 
Paul Lesniewski
SquirrelMail Team
Please support Open Source Software by donating to SquirrelMail!
http://squirrelmail.org/donate_paul_lesniewski.php

[SM-USERS] Which version of squirrelmail?

[Alex <mys...@gm...>]

Hi, I'm struggling with getting SM working properly. I previously reported
that I started using the version from SVN:

$ svn checkout
https://svn.code.sf.net/p/squirrelmail/code/branches/SM-1_4-STABLE/squirrelmail

but that appears to not be supported by php-8.1, so I tried the development
version:

$ svn checkout
https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail

which I didn't realize was v1.5.2-SVN, not v1.4.23-SVN.

Does the 1.4 tree have support for php-8.1 (yet)?

The problem I'm having with v1.5 is that the existing theme support seems
to have changed substantially, and I don't have the resources to convert
all of the v1.4 themes, which appears to amount to nothing more than
defining the colors, vs the v1.5 themes which are entire CSS stylesheets.

Then there's of course some of the plugins that don't work with v1.5.

Ideas greatly appreciated.

Re: [SM-USERS] Deprecated: Automatic conversion of false to array is deprecated

[Alex <mys...@gm...>]

Hi,

I'm learning that the SVN version available as a tarball is different than
the "svn checkout" trunk version available on sf.net. I somehow missed that
the SVN development version of 1.4.23 was different than the stable version
of 1.4.23. This is the version that works:

svn checkout https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail



On Tue, Feb 14, 2023 at 7:24 AM Alex <mys...@gm...> wrote:

> Hi, this appears to be another issue related to php-8.1 compatibility. I
> think this fixes it.
>
> --- functions/file_prefs.php-foreach    2023-02-13 19:09:58.956959936 -0500
> +++ functions/file_prefs.php    2023-02-13 19:10:10.975099888 -0500
> @@ -125,7 +125,7 @@
>          logout_error( sprintf( _("Preference file, %s, could not be
> opened. Contact your system administrator to resolve this issue."),
> $filename.'.tmp') );
>          exit;
>      }
> -    foreach ($prefs_cache as $Key => $Value) {
> +    foreach ((array) $prefs_cache as $Key => $Value) {
>          if (isset($Value)) {
>              if ( sq_fwrite($file, $Key . '=' . $Value . "\n") === FALSE )
> {
>                 logout_error( sprintf( _("Preference file, %s, could not
> be written. Contact your system administrator to resolve this issue.") ,
> $filename . '.tmp') );
>
>
>
> On Sun, Feb 12, 2023 at 2:12 PM Alex <mys...@gm...> wrote:
>
>> Hi, I think this is all that's necessary to fix the problem, but I'm not
>> a php developer, so I don't know if it's complete:
>>
>> diff -u squirrelmail.stable/functions/file_prefs.php
>> squirrelmail-021223/functions/file_prefs.php
>> --- squirrelmail.stable/functions/file_prefs.php        2023-01-02
>> 20:22:36.000000000 -0500
>> +++ squirrelmail-021223/functions/file_prefs.php        2023-02-12
>> 14:08:13.590538709 -0500
>> @@ -71,6 +71,7 @@
>>              }
>>
>>              if ($value != '') {
>> +               $prefs_cache = [];
>>                  $prefs_cache[$key] = $value;
>>              }
>>          }
>>
>>
>>
>> On Sun, Feb 12, 2023 at 12:13 PM Alex <mys...@gm...> wrote:
>>
>>> Hi, following up with my previous email -
>>>
>>> It does look like there's still a problem. After installing the lockout
>>> and compatibility plugin, it produces these deprecated errors:
>>>
>>> Deprecated: Automatic conversion of false to array is deprecated in
>>> /usr/share/squirrelmail/functions/file_prefs.php on line 74
>>> Warning: session_regenerate_id(): Session ID cannot be regenerated after
>>> headers have already been sent in /usr/share/squirrelmail/src/redirect.php
>>> on line 123
>>> Warning: Cannot modify header information - headers already sent by
>>> (output started at /usr/share/squirrelmail/functions/file_prefs.php:74) in
>>> /usr/share/squirrelmail/functions/global.php on line 600
>>> Deprecated: Automatic conversion of false to array is deprecated in
>>> /usr/share/squirrelmail/functions/file_prefs.php on line 74
>>> Deprecated: Automatic conversion of false to array is deprecated in
>>> /usr/share/squirrelmail/functions/file_prefs.php on line 74
>>> Warning: Cannot modify header information - headers already sent by
>>> (output started at /usr/share/squirrelmail/functions/file_prefs.php:74) in
>>> /usr/share/squirrelmail/src/redirect.php on line 233
>>>
>>> Thanks,
>>> Alex
>>>
>>>
>>> On Sun, Feb 12, 2023 at 11:36 AM Alex <mys...@gm...> wrote:
>>>
>>>> Hi, okay, I figured it out, thankfully. While I had a recent svn 1.4.23
>>>> snapshot, apparently it wasn't recent enough. The one from today (Feb 12,
>>>> 2023) works.
>>>>
>>>> What is the proper way to upgrade squirrelmail? I've just been building
>>>> two separate trees and manually going through each to identify differences
>>>> using diff or entire directories at a time, but is there a better way? I
>>>> don't think I've properly migrated all the plugins, for example, including
>>>> the configuration of each...
>>>>
>>>>
>>>>
>>>> On Sun, Feb 12, 2023 at 11:02 AM Alex <mys...@gm...> wrote:
>>>>
>>>>> Hi, I'm using 1.4.22 on fedora36 with php-8.1 and receiving the
>>>>> following errors. I thought SM supported php-8? Or is it a different
>>>>> problem? This happens after logging in and redirect.php being loaded.
>>>>>
>>>>> I shouldn't have done this on a production machine, so I'm really
>>>>> hoping there's an easy fix :-(
>>>>>
>>>>> Deprecated: Automatic conversion of false to array is deprecated in
>>>>> /usr/share/squirrelmail/functions/file_prefs.php on line 74
>>>>>
>>>>> Warning: session_regenerate_id(): Session ID cannot be regenerated
>>>>> after headers have already been sent in
>>>>> /usr/share/squirrelmail/src/redirect.php on line 123
>>>>>
>>>>> Warning: Cannot modify header information - headers already sent by
>>>>> (output started at /usr/share/squirrelmail/functions/file_prefs.php:74) in
>>>>> /usr/share/squirrelmail/functions/global.php on line 600
>>>>>
>>>>> Deprecated: Automatic conversion of false to array is deprecated in
>>>>> /usr/share/squirrelmail/functions/file_prefs.php on line 74
>>>>>
>>>>> Deprecated: Automatic conversion of false to array is deprecated in
>>>>> /usr/share/squirrelmail/functions/file_prefs.php on line 74
>>>>>
>>>>> Warning: Cannot modify header information - headers already sent by
>>>>> (output started at /usr/share/squirrelmail/functions/file_prefs.php:74) in
>>>>> /usr/share/squirrelmail/src/redirect.php on line 233
>>>>>
>>>>

Re: [SM-USERS] Deprecated: Automatic conversion of false to array is deprecated

[Alex <mys...@gm...>]

Hi, this appears to be another issue related to php-8.1 compatibility. I
think this fixes it.

--- functions/file_prefs.php-foreach    2023-02-13 19:09:58.956959936 -0500
+++ functions/file_prefs.php    2023-02-13 19:10:10.975099888 -0500
@@ -125,7 +125,7 @@
         logout_error( sprintf( _("Preference file, %s, could not be
opened. Contact your system administrator to resolve this issue."),
$filename.'.tmp') );
         exit;
     }
-    foreach ($prefs_cache as $Key => $Value) {
+    foreach ((array) $prefs_cache as $Key => $Value) {
         if (isset($Value)) {
             if ( sq_fwrite($file, $Key . '=' . $Value . "\n") === FALSE ) {
                logout_error( sprintf( _("Preference file, %s, could not be
written. Contact your system administrator to resolve this issue.") ,
$filename . '.tmp') );



On Sun, Feb 12, 2023 at 2:12 PM Alex <mys...@gm...> wrote:

> Hi, I think this is all that's necessary to fix the problem, but I'm not a
> php developer, so I don't know if it's complete:
>
> diff -u squirrelmail.stable/functions/file_prefs.php
> squirrelmail-021223/functions/file_prefs.php
> --- squirrelmail.stable/functions/file_prefs.php        2023-01-02
> 20:22:36.000000000 -0500
> +++ squirrelmail-021223/functions/file_prefs.php        2023-02-12
> 14:08:13.590538709 -0500
> @@ -71,6 +71,7 @@
>              }
>
>              if ($value != '') {
> +               $prefs_cache = [];
>                  $prefs_cache[$key] = $value;
>              }
>          }
>
>
>
> On Sun, Feb 12, 2023 at 12:13 PM Alex <mys...@gm...> wrote:
>
>> Hi, following up with my previous email -
>>
>> It does look like there's still a problem. After installing the lockout
>> and compatibility plugin, it produces these deprecated errors:
>>
>> Deprecated: Automatic conversion of false to array is deprecated in
>> /usr/share/squirrelmail/functions/file_prefs.php on line 74
>> Warning: session_regenerate_id(): Session ID cannot be regenerated after
>> headers have already been sent in /usr/share/squirrelmail/src/redirect.php
>> on line 123
>> Warning: Cannot modify header information - headers already sent by
>> (output started at /usr/share/squirrelmail/functions/file_prefs.php:74) in
>> /usr/share/squirrelmail/functions/global.php on line 600
>> Deprecated: Automatic conversion of false to array is deprecated in
>> /usr/share/squirrelmail/functions/file_prefs.php on line 74
>> Deprecated: Automatic conversion of false to array is deprecated in
>> /usr/share/squirrelmail/functions/file_prefs.php on line 74
>> Warning: Cannot modify header information - headers already sent by
>> (output started at /usr/share/squirrelmail/functions/file_prefs.php:74) in
>> /usr/share/squirrelmail/src/redirect.php on line 233
>>
>> Thanks,
>> Alex
>>
>>
>> On Sun, Feb 12, 2023 at 11:36 AM Alex <mys...@gm...> wrote:
>>
>>> Hi, okay, I figured it out, thankfully. While I had a recent svn 1.4.23
>>> snapshot, apparently it wasn't recent enough. The one from today (Feb 12,
>>> 2023) works.
>>>
>>> What is the proper way to upgrade squirrelmail? I've just been building
>>> two separate trees and manually going through each to identify differences
>>> using diff or entire directories at a time, but is there a better way? I
>>> don't think I've properly migrated all the plugins, for example, including
>>> the configuration of each...
>>>
>>>
>>>
>>> On Sun, Feb 12, 2023 at 11:02 AM Alex <mys...@gm...> wrote:
>>>
>>>> Hi, I'm using 1.4.22 on fedora36 with php-8.1 and receiving the
>>>> following errors. I thought SM supported php-8? Or is it a different
>>>> problem? This happens after logging in and redirect.php being loaded.
>>>>
>>>> I shouldn't have done this on a production machine, so I'm really
>>>> hoping there's an easy fix :-(
>>>>
>>>> Deprecated: Automatic conversion of false to array is deprecated in
>>>> /usr/share/squirrelmail/functions/file_prefs.php on line 74
>>>>
>>>> Warning: session_regenerate_id(): Session ID cannot be regenerated
>>>> after headers have already been sent in
>>>> /usr/share/squirrelmail/src/redirect.php on line 123
>>>>
>>>> Warning: Cannot modify header information - headers already sent by
>>>> (output started at /usr/share/squirrelmail/functions/file_prefs.php:74) in
>>>> /usr/share/squirrelmail/functions/global.php on line 600
>>>>
>>>> Deprecated: Automatic conversion of false to array is deprecated in
>>>> /usr/share/squirrelmail/functions/file_prefs.php on line 74
>>>>
>>>> Deprecated: Automatic conversion of false to array is deprecated in
>>>> /usr/share/squirrelmail/functions/file_prefs.php on line 74
>>>>
>>>> Warning: Cannot modify header information - headers already sent by
>>>> (output started at /usr/share/squirrelmail/functions/file_prefs.php:74) in
>>>> /usr/share/squirrelmail/src/redirect.php on line 233
>>>>
>>>

Re: [SM-USERS] Deprecated: Automatic conversion of false to array is deprecated

[Alex <mys...@gm...>]

Hi, I think this is all that's necessary to fix the problem, but I'm not a
php developer, so I don't know if it's complete:

diff -u squirrelmail.stable/functions/file_prefs.php
squirrelmail-021223/functions/file_prefs.php
--- squirrelmail.stable/functions/file_prefs.php        2023-01-02
20:22:36.000000000 -0500
+++ squirrelmail-021223/functions/file_prefs.php        2023-02-12
14:08:13.590538709 -0500
@@ -71,6 +71,7 @@
             }

             if ($value != '') {
+               $prefs_cache = [];
                 $prefs_cache[$key] = $value;
             }
         }



On Sun, Feb 12, 2023 at 12:13 PM Alex <mys...@gm...> wrote:

> Hi, following up with my previous email -
>
> It does look like there's still a problem. After installing the lockout
> and compatibility plugin, it produces these deprecated errors:
>
> Deprecated: Automatic conversion of false to array is deprecated in
> /usr/share/squirrelmail/functions/file_prefs.php on line 74
> Warning: session_regenerate_id(): Session ID cannot be regenerated after
> headers have already been sent in /usr/share/squirrelmail/src/redirect.php
> on line 123
> Warning: Cannot modify header information - headers already sent by
> (output started at /usr/share/squirrelmail/functions/file_prefs.php:74) in
> /usr/share/squirrelmail/functions/global.php on line 600
> Deprecated: Automatic conversion of false to array is deprecated in
> /usr/share/squirrelmail/functions/file_prefs.php on line 74
> Deprecated: Automatic conversion of false to array is deprecated in
> /usr/share/squirrelmail/functions/file_prefs.php on line 74
> Warning: Cannot modify header information - headers already sent by
> (output started at /usr/share/squirrelmail/functions/file_prefs.php:74) in
> /usr/share/squirrelmail/src/redirect.php on line 233
>
> Thanks,
> Alex
>
>
> On Sun, Feb 12, 2023 at 11:36 AM Alex <mys...@gm...> wrote:
>
>> Hi, okay, I figured it out, thankfully. While I had a recent svn 1.4.23
>> snapshot, apparently it wasn't recent enough. The one from today (Feb 12,
>> 2023) works.
>>
>> What is the proper way to upgrade squirrelmail? I've just been building
>> two separate trees and manually going through each to identify differences
>> using diff or entire directories at a time, but is there a better way? I
>> don't think I've properly migrated all the plugins, for example, including
>> the configuration of each...
>>
>>
>>
>> On Sun, Feb 12, 2023 at 11:02 AM Alex <mys...@gm...> wrote:
>>
>>> Hi, I'm using 1.4.22 on fedora36 with php-8.1 and receiving the
>>> following errors. I thought SM supported php-8? Or is it a different
>>> problem? This happens after logging in and redirect.php being loaded.
>>>
>>> I shouldn't have done this on a production machine, so I'm really hoping
>>> there's an easy fix :-(
>>>
>>> Deprecated: Automatic conversion of false to array is deprecated in
>>> /usr/share/squirrelmail/functions/file_prefs.php on line 74
>>>
>>> Warning: session_regenerate_id(): Session ID cannot be regenerated after
>>> headers have already been sent in /usr/share/squirrelmail/src/redirect.php
>>> on line 123
>>>
>>> Warning: Cannot modify header information - headers already sent by
>>> (output started at /usr/share/squirrelmail/functions/file_prefs.php:74) in
>>> /usr/share/squirrelmail/functions/global.php on line 600
>>>
>>> Deprecated: Automatic conversion of false to array is deprecated in
>>> /usr/share/squirrelmail/functions/file_prefs.php on line 74
>>>
>>> Deprecated: Automatic conversion of false to array is deprecated in
>>> /usr/share/squirrelmail/functions/file_prefs.php on line 74
>>>
>>> Warning: Cannot modify header information - headers already sent by
>>> (output started at /usr/share/squirrelmail/functions/file_prefs.php:74) in
>>> /usr/share/squirrelmail/src/redirect.php on line 233
>>>
>>

Re: [SM-USERS] Deprecated: Automatic conversion of false to array is deprecated

[Alex <mys...@gm...>]

Hi, following up with my previous email -

It does look like there's still a problem. After installing the lockout and
compatibility plugin, it produces these deprecated errors:

Deprecated: Automatic conversion of false to array is deprecated in
/usr/share/squirrelmail/functions/file_prefs.php on line 74
Warning: session_regenerate_id(): Session ID cannot be regenerated after
headers have already been sent in /usr/share/squirrelmail/src/redirect.php
on line 123
Warning: Cannot modify header information - headers already sent by (output
started at /usr/share/squirrelmail/functions/file_prefs.php:74) in
/usr/share/squirrelmail/functions/global.php on line 600
Deprecated: Automatic conversion of false to array is deprecated in
/usr/share/squirrelmail/functions/file_prefs.php on line 74
Deprecated: Automatic conversion of false to array is deprecated in
/usr/share/squirrelmail/functions/file_prefs.php on line 74
Warning: Cannot modify header information - headers already sent by (output
started at /usr/share/squirrelmail/functions/file_prefs.php:74) in
/usr/share/squirrelmail/src/redirect.php on line 233

Thanks,
Alex


On Sun, Feb 12, 2023 at 11:36 AM Alex <mys...@gm...> wrote:

> Hi, okay, I figured it out, thankfully. While I had a recent svn 1.4.23
> snapshot, apparently it wasn't recent enough. The one from today (Feb 12,
> 2023) works.
>
> What is the proper way to upgrade squirrelmail? I've just been building
> two separate trees and manually going through each to identify differences
> using diff or entire directories at a time, but is there a better way? I
> don't think I've properly migrated all the plugins, for example, including
> the configuration of each...
>
>
>
> On Sun, Feb 12, 2023 at 11:02 AM Alex <mys...@gm...> wrote:
>
>> Hi, I'm using 1.4.22 on fedora36 with php-8.1 and receiving the following
>> errors. I thought SM supported php-8? Or is it a different problem? This
>> happens after logging in and redirect.php being loaded.
>>
>> I shouldn't have done this on a production machine, so I'm really hoping
>> there's an easy fix :-(
>>
>> Deprecated: Automatic conversion of false to array is deprecated in
>> /usr/share/squirrelmail/functions/file_prefs.php on line 74
>>
>> Warning: session_regenerate_id(): Session ID cannot be regenerated after
>> headers have already been sent in /usr/share/squirrelmail/src/redirect.php
>> on line 123
>>
>> Warning: Cannot modify header information - headers already sent by
>> (output started at /usr/share/squirrelmail/functions/file_prefs.php:74) in
>> /usr/share/squirrelmail/functions/global.php on line 600
>>
>> Deprecated: Automatic conversion of false to array is deprecated in
>> /usr/share/squirrelmail/functions/file_prefs.php on line 74
>>
>> Deprecated: Automatic conversion of false to array is deprecated in
>> /usr/share/squirrelmail/functions/file_prefs.php on line 74
>>
>> Warning: Cannot modify header information - headers already sent by
>> (output started at /usr/share/squirrelmail/functions/file_prefs.php:74) in
>> /usr/share/squirrelmail/src/redirect.php on line 233
>>
>

Re: [SM-USERS] Deprecated: Automatic conversion of false to array is deprecated

[Alex <mys...@gm...>]

Hi, okay, I figured it out, thankfully. While I had a recent svn 1.4.23
snapshot, apparently it wasn't recent enough. The one from today (Feb 12,
2023) works.

What is the proper way to upgrade squirrelmail? I've just been building two
separate trees and manually going through each to identify differences
using diff or entire directories at a time, but is there a better way? I
don't think I've properly migrated all the plugins, for example, including
the configuration of each...



On Sun, Feb 12, 2023 at 11:02 AM Alex <mys...@gm...> wrote:

> Hi, I'm using 1.4.22 on fedora36 with php-8.1 and receiving the following
> errors. I thought SM supported php-8? Or is it a different problem? This
> happens after logging in and redirect.php being loaded.
>
> I shouldn't have done this on a production machine, so I'm really hoping
> there's an easy fix :-(
>
> Deprecated: Automatic conversion of false to array is deprecated in
> /usr/share/squirrelmail/functions/file_prefs.php on line 74
>
> Warning: session_regenerate_id(): Session ID cannot be regenerated after
> headers have already been sent in /usr/share/squirrelmail/src/redirect.php
> on line 123
>
> Warning: Cannot modify header information - headers already sent by
> (output started at /usr/share/squirrelmail/functions/file_prefs.php:74) in
> /usr/share/squirrelmail/functions/global.php on line 600
>
> Deprecated: Automatic conversion of false to array is deprecated in
> /usr/share/squirrelmail/functions/file_prefs.php on line 74
>
> Deprecated: Automatic conversion of false to array is deprecated in
> /usr/share/squirrelmail/functions/file_prefs.php on line 74
>
> Warning: Cannot modify header information - headers already sent by
> (output started at /usr/share/squirrelmail/functions/file_prefs.php:74) in
> /usr/share/squirrelmail/src/redirect.php on line 233
>

[SM-USERS] Deprecated: Automatic conversion of false to array is deprecated

[Alex <mys...@gm...>]

Hi, I'm using 1.4.22 on fedora36 with php-8.1 and receiving the following
errors. I thought SM supported php-8? Or is it a different problem? This
happens after logging in and redirect.php being loaded.

I shouldn't have done this on a production machine, so I'm really hoping
there's an easy fix :-(

Deprecated: Automatic conversion of false to array is deprecated in
/usr/share/squirrelmail/functions/file_prefs.php on line 74

Warning: session_regenerate_id(): Session ID cannot be regenerated after
headers have already been sent in /usr/share/squirrelmail/src/redirect.php
on line 123

Warning: Cannot modify header information - headers already sent by (output
started at /usr/share/squirrelmail/functions/file_prefs.php:74) in
/usr/share/squirrelmail/functions/global.php on line 600

Deprecated: Automatic conversion of false to array is deprecated in
/usr/share/squirrelmail/functions/file_prefs.php on line 74

Deprecated: Automatic conversion of false to array is deprecated in
/usr/share/squirrelmail/functions/file_prefs.php on line 74

Warning: Cannot modify header information - headers already sent by (output
started at /usr/share/squirrelmail/functions/file_prefs.php:74) in
/usr/share/squirrelmail/src/redirect.php on line 233

Re: [SM-USERS] email header in message body

[Johannes P. <rt...@yo...>]

I did quite some testing and come up with some interesting results, shown further down.


On Thu, 26 Jan 2023 23:54:54 -0000, "Paul Lesniewski" <pa...@sq...> wrote:
>
>
>
>On Thu, January 26, 2023 7:37 pm, rtc--- via squirrelmail-users wrote:
>> Hello All,
>> I am new here on the list but not new to SM. Using SM 1.4.4 with php5.4
> on
>> Win
>> with Apache is working just fine.  Thought is time for a new install, d
>id
>> that
>> and ran into one major problem. Working and looking into it for a few
>> days,
>> but can't solve the problem. Config test shows my current install and
>> results.
>> Webserver is Sambar with php running as/under cgi.IMAP server is Sambar
>..
>
>There's a good chance the problem is to do with this IMAP server, for
>which SquirrelMail has no default settings given it is shareware that
>stopped development 15 years(!) ago.

I have no shareware version running, it is the full fletched Sambar All-in-One Pro version.
The shareware runs only the webserver. I have this running since 2005. And yes, there is no development. But it's still a good product.

>There's every reason in the world
>that you should run something more up to date.  You could enable the
>"info" plugin and inspect how the server responds to some standard
>commands.

I did install SM 1.4.23 and installed the "info" plugin.
Here is the output. Just shortened the list of emails to 2.

Server Capability response:
* CAPABILITY IMAP4 IMAP4rev1 QUOTA IDLE X-MOVE X-EXPN AUTH=CRAM-MD5 STARTTLS
folder_prefix =
default_charset = ISO-8859-1

TEST_0
Request:
A003 SELECT INBOX
Response:
* 93 EXISTS
* 0 RECENT
* OK [UNSEEN 48] Message 2 is first unseen
* OK [UIDVALIDITY 1449535965] UIDs valid
* OK [UIDNEXT 1449536359]
* FLAGS (\Answered \Flagged \Draft \Deleted \Seen \Recent)
[READ-WRITE] SELECT completed

TEST_1
Request:
A004 STATUS INBOX (MESSAGES RECENT)
Response:
* STATUS INBOX (MESSAGES 93 RECENT 0)
STATUS completed

TEST_2
Request:
A005 EXAMINE INBOX
Response:
* 93 EXISTS
* 0 RECENT
* OK [UNSEEN 48] Message 2 is first unseen
* OK [UIDVALIDITY 1449535965] UIDs valid
* OK [UIDNEXT 1449536359]
* FLAGS (\Answered \Flagged \Draft \Deleted \Seen \Recent)
[READ-ONLY] EXAMINE completed

TEST_3
Request:
A006 SEARCH CHARSET "ISO-8859-1" ALL *
Response:
Invalid search criteria.

TEST_4
Request:
A007 THREAD REFERENCES ISO-8859-1 ALL
Response:
command: 'THREAD'

TEST_5
Request:
A008 SORT (DATE) ISO-8859-1 ALL
Response:
------ does not support SORT

TEST_6
Request:
A009 FETCH 1:* (FLAGS BODY[HEADER.FIELDS (FROM DATE TO)])
Response:
* 1 FETCH (FLAGS (\Seen) BODY[HEADER.FIELDS (FROM DATE TO)] {121}
From: "Johannes Prost" <xx...@yy...>
To: rt...@yo...
Date: Fri, 22 Feb 2019 11:44:47 -0600

)
* 2 FETCH (FLAGS (\Seen) BODY[HEADER.FIELDS (FROM DATE TO)] {176}
Date: Thu, 26 Jan 2023 23:54:54 -0000
From: "Paul Lesniewski" <xx...@yy...>
To: "Squirrelmail User Support Mailing List" <squ...@li...>


)
FETCH completed

TEST_7
Request:
A010 LSUB "" "*%"
Response:
* LSUB (\Unmarked) "/" "Drafts"
* LSUB (\Unmarked) "/" "facebook"
* LSUB (\Unmarked) "/" "INBOX"
* LSUB (\Unmarked) "/" "others"
* LSUB (\Unmarked) "/" "parts"
* LSUB (\Unmarked) "/" "sent"
* LSUB (\Unmarked) "/" "spam"
* LSUB (\Unmarked) "/" "sprinter"
* LSUB (\Unmarked) "/" "sprinterforum"
* LSUB (\Unmarked) "/" "squirrel"
* LSUB (\Unmarked) "/" "trash"
* LSUB (\Unmarked) "/" "videos"
LSUB completed

TEST_8
Request:
A011 LIST "*" "*"
Response:
* LIST (\Unmarked) "/" "Drafts"
* LIST (\Unmarked) "/" "facebook"
* LIST (\Unmarked) "/" "INBOX"
* LIST (\Unmarked) "/" "others"
* LIST (\Unmarked) "/" "parts"
* LIST (\Unmarked) "/" "sent"
* LIST (\Unmarked) "/" "spam"
* LIST (\Unmarked) "/" "sprinter"
* LIST (\Unmarked) "/" "sprinterforum"
* LIST (\Unmarked) "/" "squirrel"
* LIST (\Unmarked) "/" "trash"
* LIST (\Unmarked) "/" "videos"
LIST completed



>
>>  SquirrelMail version:1.4.22 Config file version:1.4.0 Config file last
>> modified:24 January 2023 19:41:26
>>   Checking PHP configuration...
>>      PHP version 5.6.40-0+deb8u12 OK.
>>      Running as sambar(1002) / sambar(1002)
>>      display_errors:
>>      error_reporting: 22527
>>      variables_order OK: GPCS.
>>      PHP extensions OK. Dynamic loading is disabled.
>>  Checking IMAP service....
>>      IMAP server ready (* OK IMAP4 Server ready )
>>      Capabilities: * CAPABILITY IMAP4 IMAP4rev1 QUOTA IDLE X-MOVE X-EXP
>N
>> AUTH=CRAM-MD5 STARTTLS
>>
>> My problem:
>> email headers are shown in the message body, either in html or plain-te
>xt
>> view.Sample from the Welcome message of this list:
>>
>> X-UID32: 1449536338 X-DATE: 1674576292 Return-path:
>> squ...@li... X-Spam-Checker-Version
>:
>> SpamAssassin 3.4.2 (2018-09-13) on         mars.yorktondigital.ca
>> X-Spam-Level: X-Spam-Status: No, score=-3.9 required=5.0
>> tests=ALL_TRUSTED,BAYES_00,
>> MAILING_LIST_MULTI,TVD_RCVD_IP,TVD_RCVD_IP4 shortcircuit=no
>> autolearn=ham autolearn_force=no version=3.4.2 Received: from 216
>..105.38.7
>> by
>> mail.xxxxxxxxx.ca (SMTPD);         id s20230124100451.1798; Tue, 24 Jan
>> 2023
>> 10:04:51 Received: from [127.0.0.1] (helo=sfs-ml-2.v29.lw.sourceforge
>..com)
>>     by sfs-ml-2.v29.lw.sourceforge.com with esmtp (Exim 4.95)
>> (envelope-from )         id 1pKLmv-0000Dg-1p         for user@xxxxxxxx.
>ca;
>>     Tue, 24 Jan 2023 16:04:44 +0000 MIME-Version: 1.0 Content-Type:
>> text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Subjec
>t:
>> Welcome to the "squirrelmail-users" mailing list From:
>> squ...@li... To: us...@xx...
>> X-No-Archive: yes Message-ID:  Date: Tue, 24 Jan 2023 16:04:42 +0000
>> Precedence: bulk X-BeenThere: squ...@li...
>> X-Mailman-Version: 2.1.21 List-Id: Squirrelmail User Support Mailing Li
>st
>> X-List-Administrivia: yes Errors-To:
>> squ...@li... Status: R   Welcome to
>> the
>> squ...@li... mailing list! Thank you for
>> joining
>> the SquirrelMail community.    If you have a question, you should check
> if
>> it's already answered in our documentation:
>>
>> ------
>> And here are the php error messages when viewing:
>>
>> PHP Warning: Variable passed to each() is not an array or object in
>> /home/sambar/sambar/vhosts/dev2/functions/mime.php on line 1594
>
>There is at least one fix related to this in version 1.4.23-svn, which is
>available to download and which I recommend.  However, it is questionable
>whether this would solve the problem of headers being shown in the
>message.
>
>> PHP Warning: Creating default object from empty value in
>> /home/sambar/sambar/vhosts/dev2/class/mime/Message.class.php on line 36
>7
>

Since SM1.4.23 those php-error messages are not shown.


>This is probably where SquirrelMail is choking on an unexpected
>BODYSTRUCTURE response.  You can inspect it using the IMAP info plugin --
>for example, I created a new folder called "test" and put a single messag
>e
>in the folder.  In the "IMAP server information" (found under "Options") 
>
>I
>enabled the SELECT command and changed it to "SELECT test" and enabled a
>new test (the first blank space) and filled in the command as "FETCH 1
>(FLAGS BODYSTRUCTURE)" (since the single message in that folder is ID 1).
> 
>Your commands may differ depending on the folder structure and ID
>assignment of your server... you'll have to look at the commands yourself
>,
>though the URLs of the message view page will give you a good indication
>of what they should be.
>
>A typical response to that command will look like:
>
>* 1 FETCH (FLAGS (\Seen) BODYSTRUCTURE (("text" "plain" ("charset"
>
>"us-ascii") NIL NIL "quoted-printable" 2040 54 NIL NIL NIL NIL)("text"
>
>"html" ("charset" "us-ascii") NIL NIL "quoted-printable" 
>9059 254 NIL NIL
>NIL NIL) "alternative" ("boundary" "gpcjbbGTVCmBXtPBPDUX") NIL 
>NIL NIL))

I did also this test with 2 different emails. Fetch1 is my problematic (header in body) email  and Fetch2 is an proper email. The result is

TEST_0
Request:
A003 SELECT test
Response:
* 2 EXISTS
* 2 RECENT
* OK [UIDVALIDITY 1449535965] UIDs valid
* OK [UIDNEXT 1449536361]
* FLAGS (\Answered \Flagged \Draft \Deleted \Seen \Recent)
[READ-WRITE] SELECT completed

TEST_6
Request:
A004 FETCH 1,2:* (FLAGS BODYSTRUCTURE)
Response:
* 1 FETCH (FLAGS (\Seen) BODYSTRUCTURE ("text" "plain" ("charset" "iso-8859-1") NIL NIL "8bit" 42 1 NIL NIL NIL))
* 2 FETCH (FLAGS (\Seen) BODYSTRUCTURE (("text" "plain" NIL NIL NIL {5}
7bit
483 1 NIL NIL NIL)("text" "html" NIL NIL NIL {5}
7bit
332 1 NIL NIL NIL) "alternative" NIL NIL NIL))
FETCH completed

I hope I did understand it correctly.

>
>> I really would appreciate some help, as I had tried already 2 different
>> installs 1.4.20, 1.4.21  and all have the same issue.
>
>I'd recommend you stick with 1.4.23-svn

Did install that on both on my test systems, (a: WIN,Apache b: Debian 8 ,Sambar) to have a proper comparison. There is no difference when contacting the same IMAP Server.
There is a difference when contacting Sambar IMAP and Mercury/32 IMAP
With Mercury/32 I have not these problems as I have with Sambar.

Said that, I have a difference in presenting the email when contacting Sambar IMAP, and that depends on email client and mostly ? content-type of email sent. Here are my findings:

Thunderbird > text/plain > header in body
Pegasus Mail > text/plain > header in body
Sambar Mail > text/html > header in body
Zimbra Mail > multipart/alternative > no problem
Java Mail > multipart/mixed > no problem
Canadian Tire promo email > multipart/alternative > no problem
JES2Mail listemail client > multipart/mix > no problem
Canada Post > text/html > header in body
Source Forge > text/plain > header in body

and here really strange with both IMAP servers, Sambar and/or Mercury/32
Samsung Android > Squirrel > message source
Sambar mail client > no problem

As you can see I did quite some tests to circle the source of the problem. I still think it is somewhere in the code of the mime-php files in folder /class/mime. 
Depending on the client but mostly on the content-type messages are shown proper or with header in the body.

I know I have an "outdated" system, but if you are willing to spent some time, I can setup an account on my test system for you if this will help. If you give me some advise what I can do from my end, as a non programmer :), I try to dig-in further. Just let me know

Thank you for your patience

Hans

>
>-- 
>Paul Lesniewski
>SquirrelMail Team
>Please support Open Source Software by donating to SquirrelMail!
>http://squirrelmail.org/donate_paul_lesniewski.php
>
>
>> What else on information would be needed ?
>> Where/what should I look for ?
>>
>> Emails created with the Zimbra client and received don't have this
>> problem.
>> Emails created by a shopping cart (shopify) don't show this problem.I c
>an
>> provide images if it is easier to understand. Images are better than
>> words. :)
>>
>> My old WIN install mentioned at the beginning does not have this, no
>> matter
>> which email client was used.
>> I really would like to get this fixed to be able to use SM with this ne
>w
>> install. Thank you for reading this long post, as I wanted to give as m
>uch
>> detail as possible.
>>
>> Hans
>
>
>
>
	

Re: [SM-USERS] email header in message body

[Paul L. <pa...@sq...>]

On Thu, January 26, 2023 7:37 pm, rtc--- via squirrelmail-users wrote:
> Hello All,
> I am new here on the list but not new to SM. Using SM 1.4.4 with php5.4 on
> Win
> with Apache is working just fine.  Thought is time for a new install, did
> that
> and ran into one major problem. Working and looking into it for a few
> days,
> but can't solve the problem. Config test shows my current install and
> results.
> Webserver is Sambar with php running as/under cgi.IMAP server is Sambar.

There's a good chance the problem is to do with this IMAP server, for
which SquirrelMail has no default settings given it is shareware that
stopped development 15 years(!) ago.  There's every reason in the world
that you should run something more up to date.  You could enable the
"info" plugin and inspect how the server responds to some standard
commands.

>  SquirrelMail version:1.4.22 Config file version:1.4.0 Config file last
> modified:24 January 2023 19:41:26
>   Checking PHP configuration...
>      PHP version 5.6.40-0+deb8u12 OK.
>      Running as sambar(1002) / sambar(1002)
>      display_errors:
>      error_reporting: 22527
>      variables_order OK: GPCS.
>      PHP extensions OK. Dynamic loading is disabled.
>  Checking IMAP service....
>      IMAP server ready (* OK IMAP4 Server ready )
>      Capabilities: * CAPABILITY IMAP4 IMAP4rev1 QUOTA IDLE X-MOVE X-EXPN
> AUTH=CRAM-MD5 STARTTLS
>
> My problem:
> email headers are shown in the message body, either in html or plain-text
> view.Sample from the Welcome message of this list:
>
> X-UID32: 1449536338 X-DATE: 1674576292 Return-path:
> squ...@li... X-Spam-Checker-Version:
> SpamAssassin 3.4.2 (2018-09-13) on         mars.yorktondigital.ca
> X-Spam-Level: X-Spam-Status: No, score=-3.9 required=5.0
> tests=ALL_TRUSTED,BAYES_00,
> MAILING_LIST_MULTI,TVD_RCVD_IP,TVD_RCVD_IP4 shortcircuit=no
> autolearn=ham autolearn_force=no version=3.4.2 Received: from 216.105.38.7
> by
> mail.xxxxxxxxx.ca (SMTPD);         id s20230124100451.1798; Tue, 24 Jan
> 2023
> 10:04:51 Received: from [127.0.0.1] (helo=sfs-ml-2.v29.lw.sourceforge.com)
>     by sfs-ml-2.v29.lw.sourceforge.com with esmtp (Exim 4.95)
> (envelope-from )         id 1pKLmv-0000Dg-1p         for us...@xx...;
>     Tue, 24 Jan 2023 16:04:44 +0000 MIME-Version: 1.0 Content-Type:
> text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Subject:
> Welcome to the "squirrelmail-users" mailing list From:
> squ...@li... To: us...@xx...
> X-No-Archive: yes Message-ID:  Date: Tue, 24 Jan 2023 16:04:42 +0000
> Precedence: bulk X-BeenThere: squ...@li...
> X-Mailman-Version: 2.1.21 List-Id: Squirrelmail User Support Mailing List
> X-List-Administrivia: yes Errors-To:
> squ...@li... Status: R   Welcome to
> the
> squ...@li... mailing list! Thank you for
> joining
> the SquirrelMail community.    If you have a question, you should check if
> it's already answered in our documentation:
>
> ------
> And here are the php error messages when viewing:
>
> PHP Warning: Variable passed to each() is not an array or object in
> /home/sambar/sambar/vhosts/dev2/functions/mime.php on line 1594

There is at least one fix related to this in version 1.4.23-svn, which is
available to download and which I recommend.  However, it is questionable
whether this would solve the problem of headers being shown in the
message.

> PHP Warning: Creating default object from empty value in
> /home/sambar/sambar/vhosts/dev2/class/mime/Message.class.php on line 367

This is probably where SquirrelMail is choking on an unexpected
BODYSTRUCTURE response.  You can inspect it using the IMAP info plugin --
for example, I created a new folder called "test" and put a single message
in the folder.  In the "IMAP server information" (found under "Options") I
enabled the SELECT command and changed it to "SELECT test" and enabled a
new test (the first blank space) and filled in the command as "FETCH 1
(FLAGS BODYSTRUCTURE)" (since the single message in that folder is ID 1). 
Your commands may differ depending on the folder structure and ID
assignment of your server... you'll have to look at the commands yourself,
though the URLs of the message view page will give you a good indication
of what they should be.

A typical response to that command will look like:

* 1 FETCH (FLAGS (\Seen) BODYSTRUCTURE (("text" "plain" ("charset"
"us-ascii") NIL NIL "quoted-printable" 2040 54 NIL NIL NIL NIL)("text"
"html" ("charset" "us-ascii") NIL NIL "quoted-printable" 9059 254 NIL NIL
NIL NIL) "alternative" ("boundary" "gpcjbbGTVCmBXtPBPDUX") NIL NIL NIL))

> I really would appreciate some help, as I had tried already 2 different
> installs 1.4.20, 1.4.21  and all have the same issue.

I'd recommend you stick with 1.4.23-svn

-- 
Paul Lesniewski
SquirrelMail Team
Please support Open Source Software by donating to SquirrelMail!
http://squirrelmail.org/donate_paul_lesniewski.php


> What else on information would be needed ?
> Where/what should I look for ?
>
> Emails created with the Zimbra client and received don't have this
> problem.
> Emails created by a shopping cart (shopify) don't show this problem.I can
> provide images if it is easier to understand. Images are better than
> words. :)
>
> My old WIN install mentioned at the beginning does not have this, no
> matter
> which email client was used.
> I really would like to get this fixed to be able to use SM with this new
> install. Thank you for reading this long post, as I wanted to give as much
> detail as possible.
>
> Hans

[SM-USERS] email header in message body

[<rt...@yo...>]

Hello All,
I am new here on the list but not new to SM. Using SM 1.4.4 with php5.4 on Win
with Apache is working just fine.  Thought is time for a new install, did that
and ran into one major problem. Working and looking into it for a few days,
but can't solve the problem. Config test shows my current install and results.
Webserver is Sambar with php running as/under cgi.IMAP server is Sambar.

SquirrelMail configtest:
This script will try to check some aspects of your SquirrelMail configuration
and point you to errors whereever it can find them. You need to go run conf.pl
in the config/ directory first before you run this script.
 SquirrelMail version:1.4.22 Config file version:1.4.0 Config file last
modified:24 January 2023 19:41:26
  Checking PHP configuration...
     PHP version 5.6.40-0+deb8u12 OK.
     Running as sambar(1002) / sambar(1002)
     display_errors:
     error_reporting: 22527
     variables_order OK: GPCS.
     PHP extensions OK. Dynamic loading is disabled.
 Checking paths...
     Data dir OK.
     Attachment dir OK.
     Plugins OK.
     Themes OK.
     Default language OK.
     Base URL detected as: http://dev2.xxxx.ca/src (location base autodetected)
 Checking outgoing mail service....
     SMTP server OK (220 mail.xxxxx.ca ESMTP Server Tue, 24 Jan 2023 19:50:05)
 Checking IMAP service....
     IMAP server ready (* OK IMAP4 Server ready )
     Capabilities: * CAPABILITY IMAP4 IMAP4rev1 QUOTA IDLE X-MOVE X-EXPN
AUTH=CRAM-MD5 STARTTLS
 Checking internationalization (i18n) settings...
      gettext - Gettext functions are available. On some systems you must have
appropriate system locales compiled. mbstring - Mbstring functions are
available.
      recode - Recode functions are available.
      iconv - Iconv functions are available.
      timezone - Webmail users can change their time zone settings.
 Checking database functions...
     not using database functionality.

Congratulations, your SquirrelMail setup looks fine to me!
--------------------------------------
Installed plugins:
Calendar

My problem:
email headers are shown in the message body, either in html or plain-text
view.Sample from the Welcome message of this list:

X-UID32: 1449536338 X-DATE: 1674576292 Return-path:
squ...@li... X-Spam-Checker-Version:
SpamAssassin 3.4.2 (2018-09-13) on         mars.yorktondigital.ca
X-Spam-Level: X-Spam-Status: No, score=-3.9 required=5.0
tests=ALL_TRUSTED,BAYES_00,        
MAILING_LIST_MULTI,TVD_RCVD_IP,TVD_RCVD_IP4 shortcircuit=no        
autolearn=ham autolearn_force=no version=3.4.2 Received: from 216.105.38.7 by
mail.xxxxxxxxx.ca (SMTPD);         id s20230124100451.1798; Tue, 24 Jan 2023
10:04:51 Received: from [127.0.0.1] (helo=sfs-ml-2.v29.lw.sourceforge.com)    
    by sfs-ml-2.v29.lw.sourceforge.com with esmtp (Exim 4.95)        
(envelope-from )         id 1pKLmv-0000Dg-1p         for us...@xx...;    
    Tue, 24 Jan 2023 16:04:44 +0000 MIME-Version: 1.0 Content-Type:
text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Subject:
Welcome to the "squirrelmail-users" mailing list From:
squ...@li... To: us...@xx...
X-No-Archive: yes Message-ID:  Date: Tue, 24 Jan 2023 16:04:42 +0000
Precedence: bulk X-BeenThere: squ...@li...
X-Mailman-Version: 2.1.21 List-Id: Squirrelmail User Support Mailing List  
X-List-Administrivia: yes Errors-To:
squ...@li... Status: R   Welcome to the
squ...@li... mailing list! Thank you for joining
the SquirrelMail community.    If you have a question, you should check if
it's already answered in our documentation:

------
And here are the php error messages when viewing:

PHP Warning: Variable passed to each() is not an array or object in
/home/sambar/sambar/vhosts/dev2/functions/mime.php on line 1594

PHP Warning: Creating default object from empty value in
/home/sambar/sambar/vhosts/dev2/class/mime/Message.class.php on line 367



I really would appreciate some help, as I had tried already 2 different
installs 1.4.20, 1.4.21  and all have the same issue.
What else on information would be needed ?
Where/what should I look for ?

Emails created with the Zimbra client and received don't have this problem.
Emails created by a shopping cart (shopify) don't show this problem.I can
provide images if it is easier to understand. Images are better than words. :)

My old WIN install mentioned at the beginning does not have this, no matter
which email client was used.
I really would like to get this fixed to be able to use SM with this new
install. Thank you for reading this long post, as I wanted to give as much
detail as possible.

Hans

Re: [SM-USERS] Uncaught TypeError: Unsupported operand types: string * int in date.php

[Paul L. <pa...@sq...>]

On Tue, December 6, 2022 7:07 pm, Alex wrote:
> Hi,
>
>> Most recent 1.4.23-svn appears to have a problem with emails with
>> corrupt
>> > date fields?
>>
>> Yes, unexpected timezone specifiers like "+UT" ... not sure what kind of
>> system is claiming to be date-stamping its email messages to atomic
>> clocks.
>>
>> I just put a patch for this into our repository.  The fix will be
>> available in tarball format within the next 24 hours.
>>
>
> Thanks so much.
>
> I'll diff this version with the one I currently have installed, as I've
> made a few local changes that I don't want to overwrite.

https://sourceforge.net/p/squirrelmail/code/14978/

-- 
Paul Lesniewski
SquirrelMail Team
Please support Open Source Software by donating to SquirrelMail!
http://squirrelmail.org/donate_paul_lesniewski.php