From: Paul D. <pau...@su...> - 2005-02-04 20:00:13
|
Hi All, Jon, I have the header info from the email that was an issue. I have been following the da bug tracker on this one. [ 855320 ] invalid img html tag causes logout. If you want me to post the header info just let me know and I will. Thanks PaulD |
From: Jonathan A. <jo...@sq...> - 2005-02-04 20:31:05
|
> Hi All, > Jon, I have the header info from the email that was an issue. I have be= en > following the da bug tracker on this one. [ 855320 ] invalid img html t= ag > causes logout. Would it be possible to forward the whole email as an attachment? It's a little more than just the headers I need to look at. --=20 Jonathan Angliss <jo...@sq...> |
From: paultest <pau...@su...> - 2005-02-05 19:49:28
Attachments:
sqheader.txt
|
Hi Jon, I tried to send the email to me as an attachment and it logged me off, anything I did with that email logged me out. the only thing I could was to set it up in IMAP and get the header info. If I tried to forward it thru IMAP on Outlook Express, Outlook Express crashed. sqheader.txt is attached. PaulD ----- Original Message ----- From: "Jonathan Angliss" <jo...@sq...> To: "Paul Dembro" <pau...@su...> Cc: <squ...@li...>; <squ...@li...>; <jo...@sq...> Sent: Friday, February 04, 2005 3:30 PM Subject: [SM-DEVEL] Re: [ 855320 ] invalid img html tag causes logout > Hi All, > Jon, I have the header info from the email that was an issue. I have been > following the da bug tracker on this one. [ 855320 ] invalid img html tag > causes logout. Would it be possible to forward the whole email as an attachment? It's a little more than just the headers I need to look at. -- Jonathan Angliss <jo...@sq...> ------------------------------------------------------- This SF.Net email is sponsored by: IntelliVIEW -- Interactive Reporting Tool for open source databases. Create drag-&-drop reports. Save time by over 75%! Publish reports on the web. Export to DOC, XLS, RTF, etc. Download a FREE copy at http://www.intelliview.com/go/osdn_nl -- squirrelmail-devel mailing list Posting Guidelines: http://squirrelmail.org/wiki/wiki.php?MailingListPostingGuidelines List Address: squ...@li... List Archives: http://news.gmane.org/thread.php?group=ane.mail.squirrelmail.devel List Archives: http://sourceforge.net/mailarchive/forum.php?forum_idq39 List Info: https://lists.sourceforge.net/lists/listinfo/squirrelmail-devel |
From: Marc G. K. <ma...@sq...> - 2005-02-05 19:57:38
|
> Hi Jon, > I tried to send the email to me as an attachment and it logged me off, > anything I did with that email logged me out. the only thing I could was to > set it up in IMAP and get the header info. If I tried to forward it thru > IMAP on Outlook Express, Outlook Express > crashed. > You can send messages as attachment from the messages list and check the message to "forward as attachment' or from the message view and check the "as attachment" checkbox and press forward (in the devel version). The message you forward will not be displayed so it cannot log you out. Marc. |
From: Brad D. <buc...@us...> - 2005-02-05 20:41:21
|
paultest wrote: > Hi Jon, > I tried to send the email to me as an attachment and it logged me off, > anything I did with that email logged me out. > the only thing I could was to set it up in IMAP and get the header info. > If I tried to forward it thru IMAP on Outlook Express, Outlook Express > crashed. You should be able to view the message and then forward it as an attachment if you do the following FIRST: 1) go to the Display Preferences 2) look for the item "Show HTML Version by Default" 3) set it to No 4) save yer prefs Then you should be able to go back to the message in question and forward it as an attachment. Hope this helps, Brad -- Last time I had this much fun was, ... uh ... |
From: Jonathan A. <jo...@sq...> - 2005-02-06 03:58:07
Attachments:
cidurl_mime.diff
|
> Here is the email as an attachment. I've attached a test fix. The fix code is against SM 1.4.4-cvs as of about nowish, and will work against 1.4.4, and should be okay against 1.4.3a. To apply this fix, drop the file into your Squirrelmail directory, and us= e the patch command like this: patch -p0 < cidurl_mime.diff If you do not have shell access to the server running SquirrelMail, or yo= u do not have linux, let me know, and I'll send you my mime.php file for yo= u to use. Side note, I tested this against the email you had sent, and it worked fine, no more logouts. I don't believe there should be any issues with other files that might be attached. I tag this fix as a "hack" until I can bug Marc about the message body structure to try and work out the cause of one issue that was part of this bug. --=20 Jonathan Angliss <jo...@sq...> |
From: Marc G. K. <ma...@gr...> - 2005-02-06 14:24:55
|
>> Here is the email as an attachment. >> > > I've attached a test fix. The fix code is against SM 1.4.4-cvs as of > about nowish, and will work against 1.4.4, and should be okay against > 1.4.3a. > > > To apply this fix, drop the file into your Squirrelmail directory, and > use the patch command like this: > > patch -p0 < cidurl_mime.diff > > If you do not have shell access to the server running SquirrelMail, or > you do not have linux, let me know, and I'll send you my mime.php file for > you to use. > > Side note, I tested this against the email you had sent, and it worked > fine, no more logouts. I don't believe there should be any issues with > other files that might be attached. I tag this fix as a "hack" until I > can bug Marc about the message body structure to try and work out the > cause of one issue that was part of this bug. > Okey, the problem is clear. The mime part containing the image does not have a content-id so there is no "body id" set in the bodystructure. Multipart/related html mail with embedded images must have mathching cid <-> content-id values. In the problem mail case you match by looking at the filename. It will work but it's not how multipart/related mail work so I don't think we should try to find a match by looking at the filename. Probably a better way is to fallback to a transparant image in our images dir which will stop the auto logout "feature". This will also solve the case where you can't match against filename. Possible fix in the function sq_cid2http: init $httpurl as: $httplurl = $quotchar . SM_PATH . "images/blank.png" . $quotchar; instead of an empty string. (nb: blank.png is an examle and does not exist yet) The disabled code where you can provide a whitelist with allowed image extensions will also work again ;) Regards, Marc Groot Koerkamp. |
From: Jonathan A. <jo...@sq...> - 2005-02-06 16:35:36
|
>>> Here is the email as an attachment. >> I've attached a test fix. The fix code is against SM 1.4.4-cvs as of >> about nowish, and will work against 1.4.4, and should be okay against >> 1.4.3a. > Okey, the problem is clear. The mime part containing the image does not > have a content-id so there is no "body id" set in the bodystructure. That is part of the problem. The other part is that the emails that have this bug use a different kind of cid: string. Normally this cid: string looks like this: cid:myimage.jpg The ones from this look like this: cid:{some-guid}/myimage.png It includes the { }, so I stripped them out as they have no affect on the actual finding of the image. > Multipart/related html mail with embedded images must have mathching ci= d > <-> content-id values. In the problem mail case you match by looking at > the filename. It will work but it's not how multipart/related mail work= so > I don't think we should try to find a match by looking at the filename. Eh... guess that is what you'd say... in the meantime people complain tha= t the images show up fine in other clients, but not squirrelmail so it must be a squirrelmail bug :) > Probably a better way is to fallback to a transparant image in our imag= es > dir which will stop the auto logout "feature". This will also solve the > case where you can't match against filename. > > Possible fix in the function sq_cid2http: > init $httpurl as: > $httplurl =3D $quotchar . SM_PATH . "images/blank.png" . $quotchar; > instead of an empty string. (nb: blank.png is an examle and does not ex= ist > yet) Eh, I think we should do that anyway, but leave the code change I put in there. --=20 Jonathan Angliss <jo...@sq...> |
From: Marc G. K. <ma...@sq...> - 2005-02-06 17:53:37
|
>>>> Here is the email as an attachment. >>>> > >>> I've attached a test fix. The fix code is against SM 1.4.4-cvs as of >>> about nowish, and will work against 1.4.4, and should be okay >>> against 1.4.3a. >>> > >> Okey, the problem is clear. The mime part containing the image does not >> have a content-id so there is no "body id" set in the bodystructure. > > That is part of the problem. The other part is that the emails that have > this bug use a different kind of cid: string. Normally this cid: string > looks like this: > > cid:myimage.jpg > > > The ones from this look like this: > > > cid:{some-guid}/myimage.png > > > It includes the { }, so I stripped them out as they have no affect on the > actual finding of the image. It doesn't matter in what format the cid is provided. As long as it match the mime header Content-Id, it's detected by, and part of the bodystructure. A cid in a bodystructure is inside double quotes so other characters then a non escaped double quote has no effect on parsing. In other words, If you added an content-id mimeheader which looked like this: Content-id: <{some-guid}/myimage.png> everything would have just worked fine. If you strip them out then valid cid's with a matching content-id cannot be found. Unless you strip them out after you did the regular comparation and didn't found a match. > >> Multipart/related html mail with embedded images must have mathching >> cid <-> content-id values. In the problem mail case you match by looking >> at the filename. It will work but it's not how multipart/related mail >> work so I don't think we should try to find a match by looking at the >> filename. > > Eh... guess that is what you'd say... in the meantime people complain > that the images show up fine in other clients, but not squirrelmail so it > must be a squirrelmail bug :) > There are not many people with this problem. We have millions of users and looking at the mailinglists only 3 people has the same problem. It's a problem because of the logout. Not displaying non compliant multipart/related images is probably enough. But hey, I like to follow rfc standard and if every client is tolerant in displaying broken messages we never get rid of the broken email clients. Marc. |
From: Jonathan A. <jo...@sq...> - 2005-02-07 03:21:38
|
>>> Multipart/related html mail with embedded images must have mathching >>> cid <-> content-id values. In the problem mail case you match by >>> looking at the filename. It will work but it's not how multipart/rela= ted >>> mail work so I don't think we should try to find a match by looking a= t >>> the filename. >> Eh... guess that is what you'd say... in the meantime people complain >> that the images show up fine in other clients, but not squirrelmail so >> it must be a squirrelmail bug :) > There are not many people with this problem. We have millions of users = and > looking at the mailinglists only 3 people has the same problem. It's a > problem because of the logout. 3 people that reported it on the lists. There are 3 people on the same bug I believe, and I had a report from a few other people. > Not displaying non compliant multipart/related images is probably enoug= h. > But hey, I like to follow rfc standard and if every client is tolerant = in > displaying broken messages we never get rid of the broken email clients= . Then start dropping your IMAP server with it's option to support non-rfc compliant requests, because I'm pretty sure nearly every imap server has options for that in there too. While I don't disgree it'd be nice to dro= p it, it is Outlook Express, what do you think the posibilities of Microsof= t for fixing that really are? Unlikely. But give it a shot if you want :) --=20 Jonathan Angliss <jo...@sq...> |
From: Marc G. K. <ma...@sq...> - 2005-02-07 08:59:13
|
> >>>> Multipart/related html mail with embedded images must have >>>> mathching cid <-> content-id values. In the problem mail case you >>>> match by looking at the filename. It will work but it's not how >>>> multipart/related mail work so I don't think we should try to find a >>>> match by looking at the filename. > >>> Eh... guess that is what you'd say... in the meantime people complain >>> that the images show up fine in other clients, but not squirrelmail >>> so it must be a squirrelmail bug :) > >> There are not many people with this problem. We have millions of users >> and looking at the mailinglists only 3 people has the same problem. It's >> a problem because of the logout. > > 3 people that reported it on the lists. There are 3 people on the same > bug I believe, and I had a report from a few other people. > >> Not displaying non compliant multipart/related images is probably >> enough. But hey, I like to follow rfc standard and if every client is >> tolerant in displaying broken messages we never get rid of the broken >> email clients. > > Then start dropping your IMAP server with it's option to support non-rfc > compliant requests, because I'm pretty sure nearly every imap server has > options for that in there too. I don't know what you mean. What does this have to do with imap and which non-compliant rfc requests are you refering at? > While I don't disgree it'd be nice to > drop it, it is Outlook Express, what do you think the posibilities of > Microsoft > for fixing that really are? Unlikely. But give it a shot if you want :) > Ah okey, it's outlook express. I searched for it and it looks like outlook express generates those cid expressions to show attached images. Those images are NOT part of the multipart/related mail. This means we can drop the images. The view images option should take care of displaying attached images. This strengten my opinion not to show those images as embedded images in html. Marc. |
From: Jonathan A. <jo...@sq...> - 2005-02-07 15:45:51
|
[..] >>> Not displaying non compliant multipart/related images is probably >>> enough. But hey, I like to follow rfc standard and if every client is >>> tolerant in displaying broken messages we never get rid of the broken >>> email clients. >> Then start dropping your IMAP server with it's option to support non-r= fc >> compliant requests, because I'm pretty sure nearly every imap server h= as >> options for that in there too. > I don't know what you mean. What does this have to do with imap and whi= ch > non-compliant rfc requests are you refering at? You're saying we should drop support for RFC ignorant/incompliant clients right? Well I dare say your IMAP server has support for them too, so are you going to stop supporting and using it because of that? >> While I don't disgree it'd be nice to drop it, it is Outlook Express, >> what do you think the posibilities of Microsoft for fixing that really >> are? Unlikely. But give it a shot if you want :) > Ah okey, it's outlook express. I searched for it and it looks like outl= ook > express generates those cid expressions to show attached images. Those > images are NOT part of the multipart/related mail. This means we can dr= op > the images. The view images option should take care of displaying attac= hed > images. > This strengten my opinion not to show those images as embedded images i= n > html. Then we got back to the position that "hey, all my other programs display it fine, just not squirrelmail... must be a bug there". I do agree that OE needs to fix it, but chances of that happening are... ooh... none... The code change I have put in isn't going to break anything else, and yet still allows the images to be display... There are times in our code wher= e we make exceptions to RFC incompliance in IMAP servers, like that code change I had to put in the other day... *shrugs*... What's the phrase, liberal in what you except, strict in what you send... :) --=20 Jonathan Angliss <jo...@sq...> |
From: Tomas K. <to...@us...> - 2005-02-07 16:08:48
|
... >>> While I don't disgree it'd be nice to drop it, it is Outlook Express, >>> what do you think the posibilities of Microsoft for fixing that really >>> are? Unlikely. But give it a shot if you want :) > >> Ah okey, it's outlook express. I searched for it and it looks like >> outlook >> express generates those cid expressions to show attached images. Those >> images are NOT part of the multipart/related mail. This means we can >> drop the images. The view images option should take care of displaying >> attached images. > >> This strengten my opinion not to show those images as embedded images in >> html. > > Then we got back to the position that "hey, all my other programs display > it fine, just not squirrelmail... must be a bug there". I do agree that > OE needs to fix it, but chances of that happening are... ooh... none... > The code change I have put in isn't going to break anything else, and yet > still allows the images to be display... There are times in our code where > we make exceptions to RFC incompliance in IMAP servers, like that code > change I had to put in the other day... *shrugs*... What's the phrase, > liberal in what you except, strict in what you send... :) Or create option $enable_workarounds_for_broken_messages=true and don't enable it by default. We are living in complex world and programs MUST follow the rules in order to communicate correctly with other programs. If we follow broken programs, these programs won't be fixed. They will ignore w3.org recommendations and own references in browsers, will continue production of programs that create "This message is in html formating and your email program is broken" messages with content-type: text/plain and find other ways to impose own monopolies. -- Tomas |
From: paultest <pau...@su...> - 2005-03-21 16:02:57
|
Hi All, Still an issue with Squirrelmail 1.4.4 Images view fine without logging out, but if I try to forward the email as an attachment or forward it at all in squirrelmail, nothing happens, no compose screen to forward email with. Is this a different bug or is it a bug no one knows about? PaulD |