Re: [SM-DEVEL] Re: [ 855320 ] invalid img html tag causes logout

[Marc G. K. <ma...@sq...>]

>>>> Here is the email as an attachment.
>>>>
>
>>> I've attached a test fix.  The fix code is against SM 1.4.4-cvs as of
>>>  about nowish, and will work against 1.4.4, and should be okay
>>> against 1.4.3a.
>>>
>
>> Okey, the problem is clear. The mime part containing the image does not
>>  have a content-id so there is no "body id" set in the bodystructure.
>
> That is part of the problem.  The other part is that the emails that have
>  this bug use a different kind of cid: string.  Normally this cid: string
>  looks like this:
>
> cid:myimage.jpg
>
>
> The ones from this look like this:
>
>
> cid:{some-guid}/myimage.png
>
>
> It includes the { }, so I stripped them out as they have no affect on the
>  actual finding of the image.

It doesn't matter in what format the cid is provided. As long as it match
the mime header Content-Id, it's detected by, and part of the
bodystructure. A cid in a bodystructure is inside double quotes so other
characters then a non escaped double quote has no effect on parsing.
In other words, If you added an content-id mimeheader which looked like this:

Content-id: <{some-guid}/myimage.png>

everything would have just worked fine.

If you strip them out then valid cid's with a matching content-id cannot
be found.
Unless you strip them out after you did the regular comparation and didn't
found a match.

>
>> Multipart/related html mail with embedded images must have mathching
>> cid <-> content-id values. In the problem mail case you match by looking
>> at the filename. It will work but it's not how multipart/related mail
>> work so I don't think we should try to find a match by looking at the
>> filename.
>
> Eh... guess that is what you'd say... in the meantime people complain
> that the images show up fine in other clients, but not squirrelmail so it
> must be a squirrelmail bug :)
>

There are not many people with this problem. We have millions of users and
looking at the mailinglists only 3 people has the same problem. It's a
problem because of the logout. Not displaying non compliant
multipart/related images is probably enough.
But hey, I like to follow rfc standard and if every client is tolerant in
displaying broken messages we never get rid of the broken email clients.

Marc.