From: Marc G. K. <ma...@it...> - 2002-10-18 12:00:03
|
Pontus Ullgren zei: > Hell, > > A suggestion is to implement it as a plugin with the core code changes > attached as a diff patch. (This was how the priority plugin started which > later went into the core.) > > It will enable the feature to the admins that like the feature but you > won't have to put a lot of effort into convincing the developers. Later > they may see that your diff is "a good idea"(TM) and Inc operate it into > the core. > > And yes it will add some overhead at upgrade (patch -p0 < patchfile.diff) > But I guess most ppl that have the knowledge to put up a squirrelmail > installation would be able to solve that. > > And once again ... please don't make this plugin it will only encourge > people to do dumb things (like sending HTML emails). ;-) > It's a waste of time to make patches for the core. Devel is moving fast and after 1.2.9 we are moving on with DEVEL 1.3.2. The only thing we need is a compose class and after that we can cleanly fit in html mail. It's up to local administrators to install the html plugin or to disable it. (The deliver class is already implemented in devel) Another thing, If we are ready for it, it should also support images. Otherwise it's useless because we can't reply to html messages with inline images. With the current magicHTML function we offer "save" HTML mail so the securityrisks aren't that big as some of us thinks. If we do it like that, the clean way, the core becomes less complex and is easier to adapt without consequentes for the rest of the code. Regards, Marc Groot Koerkamp. |