Menu
▾
▴
Re: [SM-I18N] iso-2022-jp subject line getting munged when using reply or forward
|
From: alan p. <al...@12...> - 2004-12-13 04:21:12
|
Just to answer my own email... I found out where the extra spaces were=20 being added (although i'm not sure why) and have attached a patch file. I'm curious why there are 5 spaces being padded into the subject (one=20 was after the \r\n and 4 additional spaces) during folding however. alan alan premselaar wrote: > Higashiyama-san, >=20 > that seems to have worked, although I'm still seeing about 5 spaces=20 > being inserted after the line-break causing the subject now to appear l= ike: >=20 > Re: =E6=B8=AC=E7=94=A8URL =E7=99=BA=E8=A1=8C=E3=81=AE=E5=BE=A1= =E9=A1=98=E3=81=84 >=20 > Subject: Re: > =3D?ISO-2022-JP?B?GyRCQixNURsoQg=3D=3D?=3DURL > =3D?ISO-2022-JP?B?GyRCSC85VCROOGY0aiQkGyhC?=3D >=20 > instead of: >=20 > Re: =E6=B8=AC=E7=94=A8URL=E7=99=BA=E8=A1=8C=E3=81=AE=E5=BE=A1=E9=A1=98=E3= =81=84 >=20 > Subject: Re: > =3D?ISO-2022-JP?B?GyRCQixNURsoQg=3D=3D?=3DURL > =3D?ISO-2022-JP?B?GyRCSC85VCROOGY0aiQkGyhC?=3D >=20 >=20 > Thanks for your help, >=20 > alan >=20 > HIGASHIYAMA Masato wrote: >=20 >> I think that this is a bug of foldLine function in Deliver.class.php. >> It is an issue that line feed is put after =3D when a message is >> transmitted. >> >> Please try to test a patch of attached file. >> >>> I'm using SquirrelMail 1.4.3a-1 on RedHat EL 3.0 in a Japanese langua= ge >>> environment. Mostly it is working without issue, however recently on= e >>> of my users pointed out that their subject was munged when replying. >>> >>> this is the comment from the user: (in japanese) >>> =E4=BB=B6=E5=90=8D=E3=81=8C=E3=82=82=E3=81=A8=E3=82=82=E3=81=A8=E3=81= =AF=E3=80=8C=E6=B8=AC=E7=94=A8URL=E7=99=BA=E8=A1=8C=E3=81=AE=E5=BE=A1=E9=A1= =98=E3=81=84=E3=80=8D=E3=81=AA=E3=81=AE=E3=81=AB=E3=80=81=E8=BF=94=E4=BF=A1= =E3=82=92=E3=81=99=E3=82=8B=E3=81=A8 >>> =E3=81=93=E3=81=AE=E3=82=88=E3=81=86=E3=81=AB=E5=8C=96=E3=81=91=E3=81= =A6=E3=81=97=E3=81=BE=E3=81=BE=E3=81=99=E3=80=82 >>> =E3=80=8CRe: =E6=B8=AC=E7=94=A8URL=3D ?ISO-2022-JP?B?GyRCSC85VCROOGY0= aiQkGyhC?=3D=E3=80=8D >>> >>> >>> >>> after doing some testing I've been able to reproduce a similar issue. >>> it appears that for some reason extra spaces and a carriage-return ar= e >>> being inserted into the Subject: header. I'm not a PHP programmer, b= ut >>> I've looked through the code and have yet to be able to determine whe= re >>> this is happening. In my test case, I used an email with the followi= ng >>> subject: >>> >>> WEB=E3=83=A1=E3=83=BC=E3=83=AB=E3=81=AE=E4=BB=B6=E5=90=8D=E3=81=8C=E5= =8C=96=E3=81=91=E3=81=BE=E3=81=99 >>> >>> during my reply / forwarding tests I've seen the following in the=20 >>> headers: >>> >>> Return-Path: <apr...@my...d> >>> Received: from mail.mydomain.tld (mail.mydomain.tld [xxx.xxx.xxx.25]) >>> by mojo.12inch.com (8.13.1/8.13.0) with ESMTP id iB818INF002655 >>> (version=3DTLSv1/SSLv3 cipher=3DDHE-RSA-AES256-SHA bits=3D256 ver= ify=3DFAIL) >>> for <al...@12...>; Wed, 8 Dec 2004 10:08:20 +0900 >>> Received: from mail.mydomain.tld (localhost.localdomain [127.0.0.1]) >>> by mail.mydomain.tld (8.13.1/8.13.1) with ESMTP id iB8166HS011355 >>> (version=3DTLSv1/SSLv3 cipher=3DDHE-RSA-AES256-SHA bits=3D256 ver= ify=3DNO) >>> for <al...@12...>; Wed, 8 Dec 2004 10:06:06 +0900 >>> Received: (from apache@localhost) >>> by mail.mydomain.tld (8.13.1/8.13.1/Submit) id iB81663u011354; >>> Wed, 8 Dec 2004 10:06:06 +0900 >>> Received: from 203.131.192.247 >>> (SquirrelMail authenticated user apremselaar); >>> by mail.mydomain.tld with HTTP; >>> Wed, 8 Dec 2004 10:06:06 +0900 (JST) >>> Message-ID: <51706.203.131.192.247.1102467966.squirrel@203.131.192.24= 7> >>> Date: Wed, 8 Dec 2004 10:06:06 +0900 (JST) >>> Subject: [Fwd: >>> WEB=3D?ISO-2022-JP?B?GyRCJWEhPCVrJE43b0w+JCwyPSQxJF4kORsoQg=3D=3D? = ] >>> From: apr...@my...d >>> To: al...@12... >>> User-Agent: SquirrelMail/1.4.3a-1 >>> X-Mailer: SquirrelMail/1.4.3a-1 >>> MIME-Version: 1.0 >>> Content-Type: text/plain;charset=3Diso-2022-jp >>> Content-Transfer-Encoding: 7bit >>> X-Priority: 3 (Normal) >>> Importance: Normal >>> X-Spam-Scanner: SpamAssassin 3.000001 (http://www.spamassassin.org/) = on >>> mojo.12inch.com >>> X-Spam-Score: -2.467 / 4.000: 22.533% >>> X-Spam-Tests: AWL(0.125),NO_REAL_NAME(0.007),BAYES_00(-2.599) >>> X-Scanned-By: MIMEDefang 2.49 on 64.7.201.48 >>> >>> >>> ** NOTE: when i look at the header in my mail client (thunderbird, or >>> Squirrelmail 1.4.3a-1) the Subject header does not have a CRLF before >>> the word "WEB" ... it appears to have line-wrapped when I pasted it. >>> the CRLF and spaces between the last character of the encoded subject >>> and the ']' are showing up in the header view or source view of my ma= il >>> client(s) >>> >>> I've changed the domain-name and IP address information for my compan= y's >>> mailserver but have made no other changes to the header information. >>> >>> >>> out-bound mail from the company network does not pass thru SpamAssass= in, >>> but is scanned with ClamAV 8.0 anti-virus software. I'm running Sendm= ail >>> 8.13.1 with MIMEDefang milter. I'm not doing any message rebuilding >>> within MIMEDefang. >>> >>> any assistance is greatly appreciated. >>> >>> Thank you, >>> >>> alan >>> >>> >>> ------------------------------------------------------- >>> SF email is sponsored by - The IT Product Guide >>> Read honest & candid reviews on hundreds of IT Products from real use= rs. >>> Discover which products truly live up to the hype. Start reading now. >>> http://productguide.itmanagersjournal.com/ >>> --=20 >>> squirrelmail-i18n mailing list >>> List Address: squ...@li... >>> List Info:=20 >>> https://lists.sourceforge.net/lists/listinfo/squirrelmail-i18n >>> http://squirrelmail.org/cvs >>> >> >> >> >> >> ----------------------------------------------------------------------= -- >> >> --- Deliver.class.php.orig 2004-06-18 01:20:20.000000000 +0900 >> +++ Deliver.class.php 2004-08-26 23:02:16.000000000 +0900 >> @@ -601,7 +603,10 @@ >> case ($iFoldPos =3D strrpos($line_tmp,'=3D')): br= eak; >> default: break; >> } >> - >> + + if (substr($line_tmp,=20 >> $iFoldPos, 2) =3D=3D '=3D?') { >> + $iFoldPos--; >> + } >> if (!$iFoldPos) { /* clean folding didn't work */ >> $iFoldPos =3D $length; >> } >=20 >=20 >=20 > ------------------------------------------------------- > SF email is sponsored by - The IT Product Guide > Read honest & candid reviews on hundreds of IT Products from real users. > Discover which products truly live up to the hype. Start reading now.=20 > http://productguide.itmanagersjournal.com/ > --=20 > squirrelmail-i18n mailing list > List Address: squ...@li... > List Info: https://lists.sourceforge.net/lists/listinfo/squirrelmail-i1= 8n > http://squirrelmail.org/cvs >=20 |