Re: [SM-PLUGINS] add_address plugin makes unnecessary ldap bind/unbind

[Paul L. <pa...@sq...>]

On Mon, Jul 2, 2012 at 1:58 PM, David Severance <se...@uc...> wrote:
>
> On 7/2/2012 12:15 PM, Tomas Kuliavas wrote:
>> Plugin has five addressbook_init(FALSE) calls. Two in add_addresses.php and
>> three in functions.php. Second function argument disables ldap address
>> books. If it is not set, function defaults to enabled ldap. Change those
>> calls to addressbook_init(FALSE,TRUE)
>
> I have applied this change and it works exactly as advertised. My ldap
> server administrator will be very happy indeed.

You do not need to change all the addressbook_init() calls as such.
You probably only want to disable the lookups that happen when
messages are displayed to reduce LDAP server load.  If you disable
LDAP lookups indiscriminately -- for example, when the user clicks the
"Add to Address Book" link, this can lead to users duplicating
addresses that are already in a centrally managed global address book
in their personal address books.  This creates problems if/when the
global one is updated.

The better solution is more fine-grained control over if and when
lookups happen.

If you want to help test a newer version of the plugin that has such
controls, ask me offlist for a copy.

-- 
Paul Lesniewski
SquirrelMail Team
Please support Open Source Software by donating to SquirrelMail!
http://squirrelmail.org/donate_paul_lesniewski.php