Re: [SM-USERS] [1.4.19] email-address from LDAP addressbook is not properly quoted

[Paul L. <pa...@sq...>]

On Tue, Sep 29, 2009 at 10:04 AM, Paul Lesniewski <pa...@sq...> wrote:
> On Tue, Sep 29, 2009 at 6:49 AM, Ralf Hildebrandt
> <Ral...@ch...> wrote:
>>> > When I'm retrieving an address from LDAP, then the realname containing an
>>> > Umlaut not being properly quoted.
>>>
>>> Please try the attached patch.  I'm not sure yet if this is a good
>>> fix, as it may affect other parts of the software.  If you are
>>> interested in helping, you can test this patch by using SquirrelMail
>>> as extensively as possible, and by also watching for my post about it
>>> on the development and/or i18n mailing lists a bit later today.
>>
>> This patch renders my server inoperable. It drives the load from 2.57
>> avg. up to 121 (!) in a few minutes.
>
> Huh.  Obviously more analysis is needed.  Are you absolutely sure this
> was the only thing you changed before the load skyrocketed?  If it
> caused this kind of load, it seems like you would have noticed a part
> of the software that became noticeably slower -- did you or your users
> notice anything like that?
>
>> Interestingly, it seems to work though :)

If you are willing to sacrifice usability of your machine for another
five minutes, you can try re-applying that patch, then changing the
following lines in functions/mime.php:

1) comment out line 792 so it looks like:

            //case '"':

2) change line 843 so it looks like:

                if ($k > 126 || $string{$i} == '"') {

I think this will have the same result, but having a real world test
to help verify would be a big help.  It seems that encoding quotes
makes too much use of this code, but the only other fix is to rewrite
the function parseAddress in the Rfc822Header class because it tries
to parse by and then strip out quotes regardless of if they are
embedded in an encoded part of the string.

-- 
Paul Lesniewski
SquirrelMail Team
Please support Open Source Software by donating to SquirrelMail!
http://squirrelmail.org/donate_paul_lesniewski.php