Re: [SM-DEVEL] SquirrelMail LDAP address book feature needs implementing/tweaking

[Paul L. <pa...@sq...>]

On Wed, Jul 2, 2008 at 12:25 AM, David Härdeman <da...@ha...> wrote:
> On Wed, July 2, 2008 05:30, Paul Lesniewski wrote:
>> I have a question about what $dn becomes in your patch as opposed to
>> what it was before.  Before your patch, there was a comma and
>> $this->basedn following the "cn=VALUE".  Your patch takes it out.  Is
>> this intentional or a bug?
>
> It was intentional but I was hesitant whether it should be done or not.

I don't use LDAP, so am not certain what the answer is here.  I
changed it back because it seemed to be unrelated to the needed
change(?).

> Note that the patch also changed the second arg when lookup called
> ldap_search from "true" to false.

This was addressed in my last email.  I changed it back in my proposed
patch because I think you misunderstood that we only need one result,
not more than that.

> BEFORE:
>
> basedn = 'cn=' . $SEARCH . ',' . $this->basedn;
> filter = objectClass=*
> scope  = base
>
> AFTER:
>
> basedn = $this->basedn
> filter = $attr . '=' . $SEARCH
> scope  = sub
>
>
> So the original method would do an exact match and the later method would
> do a subtree search for a match. The original method would be guaranteed
> to match an LDAP entry added using the SQ LDAP interface while the latter
> would match other entries as well (somewhere else in the hierarchy).

I see.

> It's probably better to leave that part as it was for now (as you did in
> your proposed patch which looks fine).

OK, thanks so very very very very very much for your help!

Did I mention thank you?