Re: [SM-CVS] SF.net SVN: squirrelmail: [13015] branches/SM-1_4-STABLE/squirrelmail/ plugins/fortune

[Paul L. <pa...@sq...>]

On Fri, Mar 7, 2008 at 11:05 AM, Paul Lesniewski <pa...@sq...> wrote:
> On Fri, Mar 7, 2008 at 9:08 AM, Jon Angliss <jo...@sq...> wrote:
>  > Paul Lesniewski wrote:
>  >
>  >  >>  You're forcing an include, and a
>  >  >>  getPref call, when you can get away with a single getPref call which
>  >  >>  would be handled by the original load_prefs hook, and no include if you
>  >  >>  don't enable the option.
>  >  >>
>  >  >
>  >  > Yes.  The reason is one of principal - we've routinely told everyone
>  >  > to get *everything* out of setup.php except pure function stubs.  We
>  >  > could change our minds when it is clearly, as in this case, a
>  >  > performance gain.
>  >  >
>  >
>  >  Does that imply you're going to roll the change back? ;)
>
>  No, but alright, then.

But the amount of code added back to setup makes me uneasy too.  :-(

Unfortunately, svn seems broken.  It started asking for my password,
then my username and password, then:

svn: Commit failed (details follow):
svn: MKACTIVITY of
'/svnroot/squirrelmail/!svn/act/e63415d5-c479-49c8-919c-1fa4da73e95b':
authorization failed (https://squirrelmail.svn.sourceforge.net)