Re: [SM-USERS] sThreadResponse error with SVN trunk

[Paul L. <pa...@sq...>]

On 7/29/07, James Pooton <ja...@mo...> wrote:
> Hello,
>
> I checked out the latest SVN trunk today and all looks good except for a seemingly
> random error that comes up during mail "searches":
>
> Category:  PHP
> Message:  Undefined variable: sThreadResponse
> FILE:  /var/www/html/mail.moonshineridge.com/squirrelmail/functions/imap_messages.php
> LINE:  398
>
> I'm using Cyrus and it has thread sorting, etc.  But even so, this looks more like
> a script problem where the variable hasn't been set.
>
> I'm on PHP 5.2 FWIW...
>
> Anyone else seeing this?

Not me, but this should fix it:

Index: functions/imap_messages.php
===================================================================
--- functions/imap_messages.php (revision 12567)
+++ functions/imap_messages.php (working copy)
@@ -335,6 +335,7 @@
     } elseif ($response == 'BAD') {
         sqm_trigger_imap_error('SQM_IMAP_NO_THREAD',$query,
$response, $message);
     }
+    $sThreadResponse = '';
     if (isset($sRead[0])) {
         for ($i=0,$iCnt=count($sRead);$i<$iCnt;++$i) {
             if (preg_match("/^\* THREAD (.+)$/", $sRead[$i], $aMatch)) {
@@ -342,8 +343,6 @@
                 break;
             }
         }
-    } else {
-        $sThreadResponse = "";
     }
     unset($sRead);

Thanks,
paul