Re: [SM-PLUGINS] sent_confirmation plugin

[Paul L. <pa...@sq...>]

On 2/22/07, Paul Lesniewski <pa...@sq...> wrote:
> On 2/22/07, BRUYET Xavier <xav...@c-...> wrote:
> > >> >>My message is about a bug in the sent_confirmation plugin.
> > >> >>
> > >> >>Squirrelmail 1.4.8
> > >> >>SentConfirmation 1.6
> > >> >>
> > >> >>If I compose a new mail, for example without receiver, and I try to
> > >> >>send
> > >> >>it, an error message is displayed (ok). Now I click on a folder in the
> > >> >>left tree and a sent confirmation is displayed (!)...
> > >> >
> > >> >
> > >> > Known issue (which I think is noted in plugin README).
> > >> >
> > >> >
> > >> >>I've corrected the bug like that :
> > >> >>
> > >> >>* in src/compose.php, line 450
> > >> >>
> > >> >>   - Header("Location:
> > >> >>$location/right_main.php?mailbox=$urlMailbox&sort=$sort".
> > >> >>   -        "&startMessage=$startMessage");
> > >> >>   + Header("Location:
> > >> >>$location/right_main.php?mailbox=$urlMailbox&sort=$sort".
> > >> >>   +        "&startMessage=$startMessage&mail_sent=yes");
> > >> >
> > >> >
> > >> > This is a good idea for a fix, but the issue is due more to the fact
> > >> > that SM STABLE does not allow changes that are not bug fixes, so the
> > >> > plugin was designed with that known issue and knowing that there is no
> > >> > such issue in the DEVEL branch because there is a new hook for it
> > >> > AFTER the message is actually sent.  However, this is simple enough
> > >> > that I would consider committing as a "mild" issue fix, but I don't
> > >> > think it's very complete -- what about for saved drafts, any other
> > >> > situations?  Look at the header() call above the one you found for
> > >> > drafts, then look at delete_message.php.
> > >>
> > >> I tested :
> > >> - send/reply/forward a mail
> > >> - send/reply/forward a draft
> > >> - reply/forward a deleted message
> > >> - within a new compose window or not
> > >> The patch seems to work in all these situations...
> > >
> > >
> > > Upon further review, I forgot that the architectural issue is resolved
> > > as of 1.4.6, so no such patching is necessary.  Please remove your
> > > custom patch and try the attached updated sent_confirmation plugin and
> > > let me know if it solves the issue.
> > >
> >
> > Ok, the version 1.7-beta1 of sent_confirmation corrects the bug I reported.

BTW, *THANK YOU* for following up.  Many people drop the ball unless
there is actually a problem.

 -paul

> > But with squirrelmail 1.4.8, I have the following errors :
> > - Call to undefined function get_current_hook_name() in
> > plugins/sent_confirmation/functions.php on line 52
> > - Call to undefined function is_plugin_enabled() in
> > plugins/sent_confirmation/functions.php on line 405
>
> Note the plugin's requirements include Compatibility 2.0.5+
>