Re: [SM-DEVEL] Alternative 'This image has been removed for security reasons.' graphic

[javier w. <jav...@gm...>]

On 8/31/07, Paul Lesniewski <pa...@sq...> wrote:
> On 8/22/07, javier wilson <jav...@gm...> wrote:
> > On 8/20/07, Norton, Ian <i.n...@la...> wrote:
> > > We had a fair number of complaints from our user base about the removed
> > > image.  Rather than using text we've switched to using a dynamically
> > > generated image of a red cross with a thin border around it which seems
> > > to have been well received.  It also has the added bonus of being
> > > language neutral!
> > >
> > > I suspect that it might not be good for everyone as it uses the GD
> > > graphics library, but here's a patch against 1.5.1 to provide the
> > > functionality and the PHP used to generate the image.
> >
> > Very nice! I had to make a few changes for 1.5.2 but it works great, I prefer
> > a small X in the top-left corner. So I use absolute (not relative) arguments
> > for imageline. Also, the black border seem too strong, I changed it a little.
> > I am sending my new version of sec_remove.php
> >
> > > Perhaps the image used for the removed image graphic could be a
> > > configuration option?  Sorry, I've not managed to look at how easy that
> > > would be to implement given the configuration script.
> >
> > Good idea, I always wanted to do this, thanks for taking the first step, I hope
> > the SM team will pick up on it.
>
> I took a look at this and think it could be a nice idea.  It not only
> requires GD but places extra load on the PHP server because every
> single image is dynamically built by PHP.  Why not a simple "X" png
> file that can be used instead?  I am attaching a revised patch
> (against 1.5.2) and sec_remove.php (note it goes in the /src directory
> instead), but I'd like to ask for someone to find a free (GPL/LGPL)
> "X" image that we can try instead to cut down on the need for
> dynamically generated images.
>
> Oh, if you want to control old/new functionality, add the boolean
> $show_sec_remove_image to your config/config.php file and turn it off
> and on.

Thanks Paul!
I haven't tried it yet, but I read the code, this sounds like the best
option. Could it be in 1.5.2svn?

javier