[SM-PLUGINS] Problems with Avel Sieve 1.9.6 and SM 1.4.3

[Alex S. <al...@ec...>]

I am running RHEL4 which has squirrelmail-1.4.3a-12 installed and
updated avelsieve to 1.9.6 from 1.0.1 and had a couple of weird problems:

1) AvelSieve did not display existing rule conditions
The condition field was empty and when I enabled debug I got the error
message "Something went wrong. Probably re-migrate." when displaying the
filters or editing them.

2) I tried creating new rules but the list of folders and sub-folders
was clearly jumbled.  For example, with IMAP folders A.1, A.2, B, the 1
and 2 subfolders of folder A were listed below folder B so they looked
like sub-folders of B, with folder A heading appearing in the middle of
the remaining folders without any subfolders.

I looked at the folder list and subscriptions under SM and changed some
subscriptions (unsubscribed from some folders), but when I returned to
the filters, the problem (1) disappeared.  Resubscribing to the folders
has not made the problem reappear.  Weird!

I have also managed to fix (2) by patching avelsieve, replacing all
calls to sqimap_mailbox_list_all() with calls to sqimap_mailbox_list().
 The IMAP directory list in both edit and add rules is now sorted in
alphabetic order and has subfolders in their correct locations.

I dont know anything about SM internals so dont know what the difference
is between these two functions. I know just enough to compare 1.0.1 with
1.9.6 to see what the diffs were and play (switch to the old call and
see what happens).  I did notice that in 1.9.6 sqimap_mailbox_list() was
used by avelsieve for SM 1.5 instead of sqimap_mailbox_list_all() with
the following comment:
  In Squirrelmail 1.5.x, use sqimap_mailbox_list() with
  $show_only_subscribed_folders flag off. Thanks to Simon Matter

If anyone encounters the same problem, just run the following command
from the plugins directory:
  perl -pi.orig -e 's/sqimap_mailbox_list_all/sqimap_mailbox_list/g' \
    `find avelsieve -name '*.php'`

It will do the search/replace on all .php files, keeping original files
with the extension .orig

-- Alex