From: Marc G. K. <ma...@sq...> - 2006-11-03 21:05:04
|
On Fri, November 3, 2006 9:07 pm, Thijs Kinkhorst wrote: > Marc Groot Koerkamp wrote: > >>> It is not a critical problem, and one that I think is quite hard to >>> fix. >> >> Very easy to fix, alter the function prepareRFC822_Header in >> deliver.class.php and make the message_id a static var. If it isn't set >> then create it and otherwise fallback to the static message_id with as >> result that the message_id is the same on both messages. > > This sounds a bit risky for me: there might be cases where one sends out > different messages in one page request, and wouldn't those messages also > get the same message ID? That is of course a bad thing. > I have to make a correction, the solution i came with is incorrect because we create two different deliver objects, one for sending the mail and one for appending the mail in the sent folder so the static idea does not work. But sending out multiple messages in one page request is something that, as far as i can see, does not happen/ is impossible so the situation you describe does not happen. What we should do is create the message-id in compose.php and store it in the message object we hand over to the deliver class. Over there we can check if the message-id is set and if yes then use the provided message-id instead of generating a new one. Marc. |