From: Marc G. K. <ma...@sq...> - 2006-11-02 17:07:52
|
On Thu, November 2, 2006 5:58 pm, Cor Bosman wrote: > Hi all, i recently noticed an obscure problem with message-ids in 1.4.x > by accident. In compose.php several calls are made to the mail() function > to delivery emails. Normally at least one is made to actually deliver the > email, but the same function is used to deliver to for instance the Sent > folder. > > When this is done, a -new- object is made, which recreates the necessary > headers. This means that the message-id is actually recomputed, and i can > tell you that in practice this means they actually differ in a significant > percentage of the emails. > > <438...@we...> in email > <438...@we...> in sent > folder ^ > > > I suppose it took 2 seconds for this email to be delivered, which can > easily be the case when large attachments are added and virus and > spamfiltering is applied. > > It is not a critical problem, and one that I think is quite hard to fix. Very easy to fix, alter the function prepareRFC822_Header in deliver.class.php and make the message_id a static var. If it isn't set then create it and otherwise fallback to the static message_id with as result that the message_id is the same on both messages. Regards, Marc Groot Koerkamp. |