From: <ja...@qv...> - 2005-09-02 10:27:04
|
Thank you very much for your input Tomas - I'll update the plugin package asap following your guidelines. [snip] >> Please remark, that there is a missing plugin hook call in >> src/folders.php: >> for ($p = 0, $cnt = count($boxes); $p < $cnt; $p++) { >> if >> (boolean_hook_function('special_mailbox',$boxes[$p]['unformatted'],1)) { >> $skip_folders[] = $boxes[$p]['unformatted']; >> } >> } >> (see sub-directory patch in the archive). From my point of view, the boolean_hook_function() should be called to sort out any special folder defined (preventing them from being accidentally being >> deleted/renamed/moved). >> Am I wrong, or is this a small bug in SM? Who'll take about this? > > special_mailbox hook is in functions/imap_mailbox.php. > > http://www.squirrelmail.org/docs/phpdoc/squirrelmail/imap/_functions_imap_mailbox_php.html#functionisSpecialMailbox > Please let me clarify. I know special_mailbox hook is called were you mentioned it. But... To get the plugin to work, there's a need for an call to the hook also in src/folders.php. If you install the plugin and defines special system mailboxes (e.g. "Spam") users still can move/delete the folder in the "Folder menu" accidentially. I would expect them to be hidden (like SMs special folder INBOX). Do you know a way to get them hidden in the folder menu without patching SM? Regards Jam [snip] |