Re: [SM-DEVEL] Bugfix for imap_general.php (get onetimepad from $_SESSION)

[Jonathan A. <ja...@ce...>]

Hello Jonathan,
On Monday, December 09, 2002, Jonathan Angliss wrote...

>> OK, this thing baffled me all day. :)
>> So I think it would be overall better to substitute line 238:
>>     $password = OneTimePadDecrypt($password, $onetimepad);
>> with:
>>     $password = OneTimePadDecrypt($password, $_SESSION['onetimepad']);
>> or use the usual hacks to bring $onetimepad to the function/global
>> context.

> Or do as every other login is done, and set $onetimepad before the
> sqimap_login function is called. Changing that now would break a lot
> of the calls in many places inside SM, as well as break a number of
> plugins. For example:

You'll have to excuse me... my mind was in 500 places when I replied
to this. Putting the $onetimepad setup inside sqimap_login is a good
idea, I agree. For some reason I thought the passwords were decrypted
before passed to sqimap_login, this is why I thought it'd break stuff,
otherwise you'd be trying to decrypt a decrypted password, and you'd
end up with a mess of characters. Sorry about that :)
  

-- 
Jonathan Angliss
(ja...@ce...)