Re: [SM-DEVEL] 1.2.5 bug: HTML/plain text mixed mails PATCH

SourceForge Headquarters 225 Broadway Suite 1600 San Diego, CA 92101 +1 (858) 454-5900

Rene,

In that case it's wrong behaviour of the other end mail-client. When a
mail-client replies a html composed mail and don't understand html-mail,
it should throw away the HTML entity. (Also with forwarding I think. SM
does this wrong)

The patch I suggested fixed the behaviour of SM in case of attached
HTML-messages. Sm goes looking for a HTML entity in the message and
doesn't care if it's an attached HTML-message. (an attached message has a
content-type "message/rfc822" ) That's wrong. That's why the patch does an
extra check on the entity to avoid that kind of behaviour.

But I'm glad you told me your problems because now my SM version does
support viewing attached HTML-messages. It even support viewing attached
HTML messages with attached HTML messages with HTML attached messages
..... .

Marc.

>
> Marc,
>
> I've just installed your patch ... unfortunately it doesn't seem to fix
> this particular problem.
>
> Basically if I go view the text in "view message details" it starts out
> like
>
> [general headers]
> MIME-Version: 1.0
> Content-Type: multipart/mixed;
> boundary="----=____1015244139381_y4BeNyGNVi" Message-Id:
> <200...@mt...>
>
> This is a multi-part message in MIME format.
>
> ------=____1015244139381_y4BeNyGNVi
> Content-Type: text/plain; charset=ISO-8859-1
> Content-Transfer-Encoding: 8bit
>
> [text version yadayada then goes on to]
>
> ------=____1015244139381_y4BeNyGNVi
> Content-Type: text/html;
> name="reply"
> Content-Disposition: inline;
> filename="reply"
>
> <!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.0 Transitional//EN">
>
> [ more html gobble ... ]
>
> If it is any help I might be able to convince the user with the
> offending mail client to generate test mail to test it on?
>
> Rene
>
>
>
>> Oke here is the patch to avoid showing html entities in attached
>> messages (message/rfc822).
>>
>> There is something else wrong with SM. Correct behaviour should be
>> that SM only shows one attachment, the attached message. Instead of
>> showing the attached message, SM shows al the individual attached
>> inline images as separate attachements. Maybe I manage to fix this
>> also.
>>
>> Marc Groot Koerkamp
>>
>> --- ./functions/mime.php Mon Mar  4 16:51:29 2002
>> +++ ./functions/mime.php Mon Mar  4 16:53:46 2002
>> @@ -587,6 +587,11 @@
>>         return $message->header->entity_id;
>>     }
>>     for ($i = 0; isset($message->entities[$i]); $i ++) {
>> +        if ( $message->header->type0 == 'message' &&
>> +            $message->header->type1 == 'rfc822' &&
>> +            isset($message->header->entity_id)) {
>> +            return 0;
>> +        }
>>         $entity = findDisplayEntityHTML($message->entities[$i]); if
>>         ($entity != 0) {
>>             return $entity;
>>
>>
>>>
>>> Thanks man! Don't ya just love open source software :-)
>>>
>>>> I'm working on it right now :-)
>>>>
>>>>> Ahem, cool... Is there a solution to the problem?
>>>
>>>
>>>
>>>
>>> --
>>> squirrelmail-devel mailing list
>>> List Address: squ...@li...
>>> List Info:
>>> https://lists.sourceforge.net/lists/listinfo/squirrelmail-devel
>>> http://squirrelmail.org/cvs