RE: [SM-PLUGINS] "New Window" Plugin not working in RH9!

[David M. <da...@dm...>]

On Fri, 18 Apr 2003 23:22:13 -0700, p dont think wrote:
>>  There was a change to the core code during the final days prior to the
>>  release that was accidentally not included in the final release that
> is
>>  needed to make new_window 1.1 work with SM 1.4.  Attached is a unified
>>  diff from CVS that should make the new_window plugin work like it
>>  should.
> 
> The change in the core code was unfortunate (it was accidental), but
> what is also strange to me is that looking at the plugin version 1.1, it
> would not have worked anyway.  Did someone attempt to downgrade it when
> the SM source changed?  

You were looking at a slightly different plugin.

> 
> Also, please pay attention to your diffs; the required change was just a
> single statement, but your diff was huge, a large portion of which was
> generated due to only spacing differences, although it also appeared
> that you had a somewhat dated version of that file.

I don't profess to being a master of creating patches.  That diff was 
from the cvs archive and was diff'd against the release version.  The 
consensus from #squirrelmail was to use that when I asked.

> 
> Anyhow, people please note that what you should do instead is download
> the most recent SquirrelMail cvs snapshot, where the problem has been
> fixed, as well as the new version of this plugin, which also has some
> other fixes that it was in need of.
> 

The plugin you fixed, "Windows" id=72 now has the exact same 
functionality as the plugin this user was asking about "New Window" 
id=13.  One should probably be eliminated.