|
From: Colin B. <col...@bi...> - 2002-04-03 22:05:26
|
Hi Henner, I've finally applied your "hierachical table display" to CVS. I've modified SQLConnection::getTables() to make the JDBC 3.0 call via reflection so that Squirrel can still be compiled with JDK1.3 but I can't test the mod as I don't have a driver that supports hierarchical tables. When you have the time could you please test it against your JDBC driver and if you have to fix it please send me the diff. Once its okay I intend to release it as part of 1.1beta3. Thanks Col -----Original Message----- From: squ...@li... [mailto:squ...@li...]On Behalf Of Henner Zeller Sent: Monday, 18 February 2002 7:59 PM To: SQuirreL list Subject: [Squirrel-sql-develop] Update Feature Patch: hierachical table display .. Hi, In the former patch to this topic I replaced the ArrayList to store the table infos with a HashSet - this was because its O(n) to remove from an ArrayList but only O(1) from an HashSet. Unfortunatly, this destroys the order of the tables, sine the hash function has no order .. .. so now I implemented this with a TreeSet that orders the tables alphabetically (for this, I made the IDatabaseObjectInfo extend Comparable and compare the qualified names in DatabaseObjectInfo). This has the nice side-effect, that table names are always sorted, even if JDBC-drivers fail so return them sorted. See attached patch. This is a patch agains current CVS. ciao, -hen |
