|
From: Colin B. <Col...@as...> - 2002-03-19 05:00:48
|
Hi Wayne,
"Done in haste" describes it perfectly. The magic numbers refer to the
columns in the information retrieved from the metadata. We've display only
the "relevant" information. In the future this is going to be configurable
in the session properties dialog.
I don't have your problem with Oracle via the ODBC driver. I'm using Oracle
8.1.6 with version 2.573.4202.00 of the Microsoft Oracle ODBC driver. Are
you using an older version of the driver?
In any case I'm probably going to rip out the "magic numbers" in the next
release and just display all columns.
Col
-----Original Message-----
From: Rogers,Wayne [mailto:way...@CH...]
Sent: Tuesday, 19 March 2002 8:34
To: 'squ...@li...'
Subject: [Squirrel-sql-develop] Array of magic numbers in several
TablePanel load routines
IRT
com.bigfoot.colbell.squirrel.sessionsheet.objectstree.TablePanel
I notice that several of the load methods in MyBaseViewer derived classes do
something like this:
show(new ResultSetDataSet(rs, new int[]
{4,5,6,7,9,10,11,12,13,14,15,16,17,18}), getSession().getMessageHandler());
In my case, these methods throw an error and show no data. If I change the
method to use the constructor without the int array, it seems to work. Is
this an optimization of some kind or simply something done in haste? Also, I
personally prefer to define constants for each of the column indices that I
hope to retrieve. (readability issue)
Any thoughts?
Wayne
p.s.
using Microsoft ODBC for Oracle driver, no known problems with other
clients
_______________________________________________
Squirrel-sql-develop mailing list
Squ...@li...
https://lists.sourceforge.net/lists/listinfo/squirrel-sql-develop
|
