|
From: Johan C. <jco...@j-...> - 2002-03-12 13:51:26
|
> It must be very late for you there! Good to see you're working on Squirrel > into the wee small hours. Thats what I call dedication <grin/>. sunday it was 2:30 i believe!! (AM) > <snip> > If i did a refresh pressing the button then the cursor did stay wrong > i added a _cursor.restore() after i do the refresh now just to be sure. > </snip> > > Peculiar, now its not showing the wait cursor for me at all. _However_ I > must say that the refresh seems to be running a lot faster now than it was > previously so it may not have time to show the cursor. at this time the refresh is being done in the main thread i believe! this should be altered. But some other small modifications has to be done then, but this isn't to hard. > It is convienient to expand them. The previous behaviour was an irritation > when something externally has changed the structure of a table or added a > table, you do a refresh and then you had to expand the tree to find where > you were. I much prefer your new behaviour. me to i will leave it for now. (or maybe one other thing: trying to select the selected again) > One peculiarity. When you first open a database it expands the database tab > showing all schemas/catalogs and selects the datbase node for display > (exactly what it should do) but if you then Refresh it, it expands all the > schema/catalog tabs but doesn't remember the node that was selected. selecting the selected is a feature that should be done yes. > In fact refresh _always_ expands the schema/catalog tabs even if they weren't > expanded. Yes i have tested this and it does happen because a Catalog Tree node has build in children i believe. And i do the testing what i have to expand again on if they have children or not. (that's why it always expand also the ones that where onces expanded.) This should be altered i believe but the current way was the fasted wat to do it at this time. i updated just the cvs tree so that this does not happen anymore. > It would be nice if you could take the code you have written > saving/restoring the expansion state of a tree and abstract it out into a > separate class (like SavedExpansionState). A component that you could use to > save and restore the state of any JTree would be very convienient. it is a separate class, It is the basenode :-) it needs to have access to the internals of all the nodes (like children array) johan |
