Re: [Squirrel-sql-develop] Alt-Forward Arrow Key

[Johnathan J. <ha...@gm...>]

I don't think were on exactly the same page.. you should only have a SQL tab
in the Session created at Step 1 (this is the SessionInternalFrame). In Step
2, by hitting ctrl-n, you create a window that has no tabs, only an area to
enter SQL (this is SQLInternalFrame). From this point on, if you hit
Alt-RightArrow (or Alt-LeftArrow), if the target window has a SQL text entry
area, that area should get focus. The bug is that it leaves focus in the
previous SQL text entry area, not the one made current by Alt-RightArrow.
Then when you type, the text appears in the previous window, not the one
that is Active. If what you happen to type is a CTRL-Enter and the cursor
happens to be on an unfortunate query, that could present a problem.

Off hand, I'd say the correct behavior is that whenever the user switches,
by whatever means, to a different Session window, if the SQL text entry area
of that different window is active, it should get the focus.

On Tue, Aug 26, 2008 at 5:20 AM, Robert Manning
<rob...@gm...>wrote:

> I think I see what's happening. The reason that I was unable to reproduce
> the problem yesterday is because
> I had the SQL tab selected in the main session window (the one with the
> object tree).  If the SQL tab is open
> in both session windows, the cursor will move when the selected window
> changes - at least for me.  But, if
> the object tree tab is selected in the main session window, then the cursor
> never moves from the other SQL
> tab in the other session window.  If that accurately describes the bug,
> what should the correct behavior be?
>
> Rob
>
>
> On Tue, Aug 26, 2008 at 12:01 AM, Johnathan James <ha...@gm...>wrote:
>
>> Rob, et al..
>>
>> I was on JDK 1.5.09 this morning, but I have since upgraded and rebuilt
>> the project under JDK 1.6.0-b105. I am running Ubuntu.
>>
>> I am still able to reproduce the error.
>>
>> 1. Open a session from the Aliases window.
>> 2. Hit Ctrl-N. You should have two session windows.
>> 3. Hit Alt-RightArrow. The cursor's focus should be in the first window
>> you opened.
>> 4. Hit Alt-RightArrow again, cursor focus will be in the second window.
>> 5. Hit Alt-RightArrow again, cursor focus will still be in the second
>> window.
>>
>> I am still debugging but hope to have a patch for you soon!
>>
>> Johnathan
>>
>> On Mon, Aug 25, 2008 at 9:45 AM, Robert Manning <
>> rob...@gm...> wrote:
>>
>>>
>>>
>>> On Mon, Aug 25, 2008 at 10:36 AM, Johnathan James <ha...@gm...>wrote:
>>>
>>>> Hello all..
>>>>
>>>> I have been trying to work with the source this weekend to fix a bug
>>>> that
>>>> has been bugging me. Basically, if you open a new Session from the
>>>> Aliases
>>>> window, then CTRL-N to create a new window, if you press
>>>> ALT-ForwardArrow,
>>>> usually the focus will remain in the second window, when it should have
>>>> moved to the second. So if you type, it will affect the window just
>>>> hidden,
>>>> not the one you just made visible.
>>>>
>>>> Anyway, my question is where is the KeyListener for ALT-ForwardArrow?
>>>> When I
>>>> press that key, what code runs to process it?
>>>
>>>
>>> All of the key accelerator mappings are found at the bottom of :
>>>
>>>
>>> sql12/app/src/net/sourceforge/squirrel_sql/client/resources/squirrel.properties
>>>
>>> These are translated to KeyStrokes and assigned to the appropriate action
>>> in :
>>>
>>> sql12/fw/src/net/sourceforge/squirrel_sql/fw/util/Resources.java
>>>
>>> The accelerator you are referring to is defined by the mapping:
>>>
>>> menuitem.net.sourceforge.squirrel_sql.client.session.action.NextSessionAction.accelerator=alt
>>> RIGHT
>>>
>>> So the code that gets executed is found in :
>>>
>>>
>>> sql12/app/src/net/sourceforge/squirrel_sql/client/session/action/NextSessionAction.java
>>>
>>> Incidentally, I tried the series of events you described and the cursor
>>> is consistently correctly moved
>>> to the window that has focus.  I wonder if this is related to platform /
>>> java version.  I'm using Sun Java
>>> 1.6.0_05-ea-b05 on Ubuntu Linux.  How about you ?
>>>
>>> Rob
>>>
>>>
>>
>