[Squirrel-sql-commits] sql12/fw/src/net/sourceforge/squirrel_sql/fw/datasetviewer/cellcomponent Da
A Java SQL client for any JDBC compliant database
Brought to you by:
colbell,
gerdwagner
From: Rob M. <man...@us...> - 2007-08-10 00:08:16
|
Update of /cvsroot/squirrel-sql/sql12/fw/src/net/sourceforge/squirrel_sql/fw/datasetviewer/cellcomponent In directory sc8-pr-cvs8.sourceforge.net:/tmp/cvs-serv11436/fw/src/net/sourceforge/squirrel_sql/fw/datasetviewer/cellcomponent Modified Files: DataTypeInteger.java Log Message: Use valueOf instead of Integer constructor. Findbugs says it's more efficient. Index: DataTypeInteger.java =================================================================== RCS file: /cvsroot/squirrel-sql/sql12/fw/src/net/sourceforge/squirrel_sql/fw/datasetviewer/cellcomponent/DataTypeInteger.java,v retrieving revision 1.26 retrieving revision 1.27 diff -C2 -d -r1.26 -r1.27 *** DataTypeInteger.java 21 Apr 2007 12:05:42 -0000 1.26 --- DataTypeInteger.java 10 Aug 2007 00:08:10 -0000 1.27 *************** *** 381,385 **** if (rs.wasNull()) return null; ! else return new Integer(data); } --- 381,385 ---- if (rs.wasNull()) return null; ! else return Integer.valueOf(data); } *************** *** 441,445 **** // field is not nullable, so create a reasonable default value ! return new Integer(0); } --- 441,445 ---- // field is not nullable, so create a reasonable default value ! return Integer.valueOf(0); } |