Re: [Sqlrelay-discussion] Bug report, open client connections not freed, with code to reproduce problem

[David M. <dav...@fi...>]

Hey Ingmar,

Sorry for the delayed response (and to others as well), I've been very,
very busy for the past few weeks, and was sick for a little while too.

But, yes, using your code I was recently able to track down the problem
and I think I have a solution for it.  An sqlr-connection-oracle8
process was crashing each time the script would run.  New ones might be
spawned to take the place of the crashed one, but the crash caused the
connection counter to miscount.

A quick fix is to edit src/connection/sqlrconnection/handlequery.C, go
to line 137 and change:

cursor->cleanUpData(false,true);

to:

cursor->cleanUpData(true,true);

If you trace down what would happen with "false,true", some column
definition pointers could be stale on the second iteration and when they
finally got around to being freed later, who knows what they were
pointing to.  This is the kind of bug that might not fail with a
different usage pattern, or might fail with certain versions of Oracle
but not others.

The only problem is that I can't remember why I wrote the code to use
"false,true" parameters in the first place.  It doesn't make any obvious
sense to me now, but clearly I intended to do it that way.  So either I
made a mistake before or I'm just not thinking correctly about it now.

At any rate, give it a try, let me know how it goes

Dave
dav...@fi...

On Wed, 2007-10-24 at 18:02 +0200, Ingmar Brouns wrote:
> 
> 
> Hi Dave,
> 
> I was just curious whether you've succeeded in reproducing the bug.
> 
> 
> Friendly greetings,
> 
> Ingmar
> 
> -------------------------------------------------------------------------
> This SF.net email is sponsored by: Splunk Inc.
> Still grepping through log files to find problems?  Stop.
> Now Search log events and configuration files using AJAX and a browser.
> Download your FREE copy of Splunk now >> http://get.splunk.com/
> _______________________________________________ Sqlrelay-discussion mailing list Sql...@li... https://lists.sourceforge.net/lists/listinfo/sqlrelay-discussion