Re: [Sqlrelay-discussion] Patch: Fix pkg-config .pc file for rudiments and sqlrelay

[David M. <dav...@fi...>]

Thanks Mark,

I'll check out these patches and if all goes well, include them in the
next release.

David Muse
dav...@fi...


On Thu, 2008-01-31 at 13:41 -0800, Mark Doliner wrote:
> I noticed that the rudiments.pc, sqlrelay-c.pc and sqlrelay-c++.pc files that are installed to /usr/lib64/pkgconfig/ by the RPMs are invalid (on my CentOS 5 Linux machine anyway--I guess it's possible they would work correctly elsewhere).
> 
> The first line of each .pc file is "prefix=${DESTDIR}/usr/local/firstworks", which is incorrect and causes pkg-config to give the following error:
> Variable 'DESTDIR' not defined in './sqlrelay-c++.pc'
> 
> This happens because of a chunk of configure.in which prepends DESTDIR to a bunch of autoconf variables, which in turn get substituted into sqlrelay-c++.pc.in.
> 
> I feel that the best fix is to remove this chunk from configure.in and instead change the install and uninstall targets of all Makefiles to prepend DESTDIR where needed.  This appears to be roughly how automake handles DESTDIR.  It also seems incorrect to me to change things like 'bindir' and 'libdir' in configure.in.
> 
> The attached patches make those changes.  I don't believe they will cause any negative side effects, but I'm not incredibly familiar with your build process.  The patches do not include the modified configure script, but you can just run autoconf to regenerate it.
> 
> There is a little information about the purpose of DESTDIR here:
> http://www.gnu.org/prep/standards/html_node/DESTDIR.html
> http://www.gnu.org/software/automake/manual/html_node/DESTDIR.html
> 
> Thanks,
> Mark
> 
> __________________________________________________
> D O T E A S Y - "Join the web hosting revolution!"
>              http://www.doteasy.com
> -------------------------------------------------------------------------
> This SF.net email is sponsored by: Microsoft
> Defy all challenges. Microsoft(R) Visual Studio 2008.
> http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
> _______________________________________________ Sqlrelay-discussion mailing list Sql...@li... https://lists.sourceforge.net/lists/listinfo/sqlrelay-discussion



__________________________________________________
D O T E A S Y - "Join the web hosting revolution!"
             http://www.doteasy.com