sqlobject-cvs — CVS notification

[SQL-CVS] [ sqlobject-Bugs-1539927 ] Cannot create column with reserved word

[SourceForge.net <no...@so...>]

Bugs item #1539927, was opened at 2006-08-14 15:04
Message generated for change (Comment added) made by phd
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=540672&aid=1539927&group_id=74338

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: None
Group: None
>Status: Closed
>Resolution: Wont Fix
Priority: 5
Submitted By: Nobody/Anonymous (nobody)
Assigned to: Nobody/Anonymous (nobody)
Summary: Cannot create column with reserved word

Initial Comment:
It's a complement to #1533607

You can't create columns with reserved words, like
`natural`, `index`. Column names should get a backtick.

If anyone's interested, I'm making a patch. Mail-me at
bernardojts AT gmail DOT com

----------------------------------------------------------------------

>Comment By: Oleg Broytmann (phd)
Date: 2006-08-22 18:56

Message:
Logged In: YES 
user_id=4799

They shouldn't. Different backends use different rules for
quoting. Some backends never allow reserved words however
you quote them.

But please submit your patch to the patch tracker for review.

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=540672&aid=1539927&group_id=74338

[SQL-CVS] [ sqlobject-Bugs-1533607 ] cannot create table with reserved word

[SourceForge.net <no...@so...>]

Bugs item #1533607, was opened at 2006-08-03 07:00
Message generated for change (Comment added) made by phd
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=540672&aid=1533607&group_id=74338

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: MySQL
Group: SQLObject release (specify)
>Status: Closed
>Resolution: Wont Fix
Priority: 5
Submitted By: Adam Young (youngad6)
Assigned to: Nobody/Anonymous (nobody)
Summary: cannot create table with reserved word

Initial Comment:
Examples would be "group" or "order". All table names
should be encased in backticks.


----------------------------------------------------------------------

>Comment By: Oleg Broytmann (phd)
Date: 2006-08-22 18:55

Message:
Logged In: YES 
user_id=4799

They shouldn't. Different backends use different rules for
quoting. Some backends never allow reserved words however
you quote them.

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=540672&aid=1533607&group_id=74338

[SQL-CVS] [ sqlobject-Bugs-1523898 ] wrong parameter 'connect_time' of MySQLConnection

[SourceForge.net <no...@so...>]

Bugs item #1523898, was opened at 2006-07-17 19:02
Message generated for change (Comment added) made by phd
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=540672&aid=1523898&group_id=74338

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: None
Group: None
>Status: Closed
>Resolution: Fixed
Priority: 5
Submitted By: Lutz Paelike (tremolo)
>Assigned to: Oleg Broytmann (phd)
Summary: wrong parameter 'connect_time' of MySQLConnection

Initial Comment:
Due to a documentation bug of the MySQLdb project,
sqlobject as inherited the following bug:

The keyword parameter 'connect_timeout' of the
constructor of the class MySQLConnection is wrongly
documented as 'connect_time' in the docstring of
MySQLdb.connections.MySQLConnection.
The docstring of the C-Extension correctly documents it
as 'connect_timeout' though.

As a result the parameter is not correctly extracted
from the keyword arguments dict and passed to MySQLdb.

Fix: rename the parameter 'connect_time' to
'connect_timeout' in mysqlconnection.py (line 30)

----------------------------------------------------------------------

>Comment By: Oleg Broytmann (phd)
Date: 2006-08-22 18:53

Message:
Logged In: YES 
user_id=4799

Fixed in the revision 1878 in the trunk, 1879 in the
0.7-branch. Thank you!

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=540672&aid=1523898&group_id=74338

[SQL-CVS] r1879 - SQLObject/branches/0.7-bugfix/sqlobject/mysql

[<sub...@co...>]

Author: phd
Date: 2006-08-22 08:53:23 -0600 (Tue, 22 Aug 2006)
New Revision: 1879

Modified:
   SQLObject/branches/0.7-bugfix/sqlobject/mysql/mysqlconnection.py
Log:
Fixed the bug 1523898: wrong parameter 'connect_time' of MySQLConnection.


Modified: SQLObject/branches/0.7-bugfix/sqlobject/mysql/mysqlconnection.py
===================================================================
--- SQLObject/branches/0.7-bugfix/sqlobject/mysql/mysqlconnection.py	2006-08-22 14:53:09 UTC (rev 1878)
+++ SQLObject/branches/0.7-bugfix/sqlobject/mysql/mysqlconnection.py	2006-08-22 14:53:23 UTC (rev 1879)
@@ -29,7 +29,7 @@
                 "read_default_file", "read_default_group", "charset"):
             if key in kw:
                 self.kw[key] = col.popKey(kw, key)
-        for key in ("connect_time", "compress", "named_pipe", "use_unicode",
+        for key in ("connect_timeout", "compress", "named_pipe", "use_unicode",
                 "client_flag", "local_infile"):
             if key in kw:
                 self.kw[key] = int(col.popKey(kw, key))

[SQL-CVS] r1878 - SQLObject/trunk/sqlobject/mysql

[<sub...@co...>]

Author: phd
Date: 2006-08-22 08:53:09 -0600 (Tue, 22 Aug 2006)
New Revision: 1878

Modified:
   SQLObject/trunk/sqlobject/mysql/mysqlconnection.py
Log:
Fixed the bug 1523898: wrong parameter 'connect_time' of MySQLConnection.


Modified: SQLObject/trunk/sqlobject/mysql/mysqlconnection.py
===================================================================
--- SQLObject/trunk/sqlobject/mysql/mysqlconnection.py	2006-08-22 14:48:47 UTC (rev 1877)
+++ SQLObject/trunk/sqlobject/mysql/mysqlconnection.py	2006-08-22 14:53:09 UTC (rev 1878)
@@ -33,7 +33,7 @@
                 "read_default_file", "read_default_group", "charset"):
             if key in kw:
                 self.kw[key] = col.popKey(kw, key)
-        for key in ("connect_time", "compress", "named_pipe", "use_unicode",
+        for key in ("connect_timeout", "compress", "named_pipe", "use_unicode",
                 "client_flag", "local_infile"):
             if key in kw:
                 self.kw[key] = int(col.popKey(kw, key))

[SQL-CVS] [ sqlobject-Bugs-1519914 ] Documentation error: DateTime should be DateTimeCol

[SourceForge.net <no...@so...>]

Bugs item #1519914, was opened at 2006-07-10 16:36
Message generated for change (Comment added) made by phd
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=540672&aid=1519914&group_id=74338

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: General
Group: None
>Status: Closed
>Resolution: Fixed
Priority: 5
Submitted By: Nobody/Anonymous (nobody)
>Assigned to: Oleg Broytmann (phd)
Summary: Documentation error: DateTime should be DateTimeCol

Initial Comment:

On page:

 http://www.sqlobject.org/SQLObject.html

under the heading:

 Col Class: Specifying Columns

the text:

 DateTime.now

should be:

 DateTimeCol.now

----------------------------------------------------------------------

>Comment By: Oleg Broytmann (phd)
Date: 2006-08-22 18:49

Message:
Logged In: YES 
user_id=4799

Fixed in the revision 1875 in the trunk, 1876 in the
0.7-branch. Thank you!

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=540672&aid=1519914&group_id=74338

[SQL-CVS] r1877 - SQLObject/branches/0.7-bugfix/docs

[<sub...@co...>]

Author: phd
Date: 2006-08-22 08:48:47 -0600 (Tue, 22 Aug 2006)
New Revision: 1877

Modified:
   SQLObject/branches/0.7-bugfix/docs/SQLObject.txt
Log:
Fixed the bug 1519914: Documentation error: DateTime should be DateTimeCol.


Modified: SQLObject/branches/0.7-bugfix/docs/SQLObject.txt
===================================================================
--- SQLObject/branches/0.7-bugfix/docs/SQLObject.txt	2006-08-22 14:48:31 UTC (rev 1876)
+++ SQLObject/branches/0.7-bugfix/docs/SQLObject.txt	2006-08-22 14:48:47 UTC (rev 1877)
@@ -1019,7 +1019,7 @@
     The default value for this column.  Used when creating a new row.
     If you give a callable object or function, the function will be
     called, and the return value will be used.  So you can give
-    ``DateTime.now`` to make the default value be the current time.
+    ``DateTimeCol.now`` to make the default value be the current time.
     Or you can use ``sqlbuilder.func.NOW()`` to have the database use
     the ``NOW()`` function internally.  If you don't give a default
     there will be an exception if this column isn't specified in the

[SQL-CVS] r1876 - SQLObject/docs

[<sub...@co...>]

Author: phd
Date: 2006-08-22 08:48:31 -0600 (Tue, 22 Aug 2006)
New Revision: 1876

Modified:
   SQLObject/docs/SQLObject.txt
Log:
Fixed the bug 1519914: Documentation error: DateTime should be DateTimeCol.


Modified: SQLObject/docs/SQLObject.txt
===================================================================
--- SQLObject/docs/SQLObject.txt	2006-08-22 14:46:08 UTC (rev 1875)
+++ SQLObject/docs/SQLObject.txt	2006-08-22 14:48:31 UTC (rev 1876)
@@ -1020,7 +1020,7 @@
     The default value for this column.  Used when creating a new row.
     If you give a callable object or function, the function will be
     called, and the return value will be used.  So you can give
-    ``DateTime.now`` to make the default value be the current time.
+    ``DateTimeCol.now`` to make the default value be the current time.
     Or you can use ``sqlbuilder.func.NOW()`` to have the database use
     the ``NOW()`` function internally.  If you don't give a default
     there will be an exception if this column isn't specified in the

[SQL-CVS] [ sqlobject-Bugs-1512334 ] Missing character in 1421647 resolution

[SourceForge.net <no...@so...>]

Bugs item #1512334, was opened at 2006-06-26 06:14
Message generated for change (Settings changed) made by phd
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=540672&aid=1512334&group_id=74338

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: General
Group: SQLObject from repository
>Status: Closed
>Resolution: Fixed
Priority: 5
Submitted By: Roger Demetrescu (rogercd)
>Assigned to: Oleg Broytmann (phd)
Summary: Missing character in 1421647 resolution

Initial Comment:
In the patch proposed for ticket 1421647, there was a
missing "+" character... It's my fault.

Sorry for the inconvenience. The attached patch should
correct it.



This was reported in
http://trac.turbogears.org/turbogears/ticket/1010. As
you can see, the author is also mentioning this:

============
Similar missing-character problems on lines 1441 (join
with '\n' instead of ';\n') and 1423 (same problem),
which result in not having semicolons to end the
statements.
============

I think he is refering to all those:
<code>
return '\n'.join(sql)
</code>

It worths taking a look...


Thanks

Roger Demetrescu

PS: Is there a way of reopening a ticket ? I couldn't
find any, so that's why I'm opening a new one.


----------------------------------------------------------------------

>Comment By: Oleg Broytmann (phd)
Date: 2006-08-22 18:46

Message:
Logged In: YES 
user_id=4799

Fixed in thre revision 1874 in the trunk and 1875 in the
0.7-branch. Thank you!

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=540672&aid=1512334&group_id=74338

[SQL-CVS] r1875 - SQLObject/branches/0.7-bugfix/sqlobject

[<sub...@co...>]

Author: phd
Date: 2006-08-22 08:46:08 -0600 (Tue, 22 Aug 2006)
New Revision: 1875

Modified:
   SQLObject/branches/0.7-bugfix/sqlobject/main.py
Log:
Fixed the bug 1512334: Missing character in 1421647 resolution.


Modified: SQLObject/branches/0.7-bugfix/sqlobject/main.py
===================================================================
--- SQLObject/branches/0.7-bugfix/sqlobject/main.py	2006-08-22 14:45:56 UTC (rev 1874)
+++ SQLObject/branches/0.7-bugfix/sqlobject/main.py	2006-08-22 14:46:08 UTC (rev 1875)
@@ -1334,9 +1334,9 @@
         conn = connection or cls._connection
         sql = conn.createTableSQL(cls)
         if createJoinTables:
-            sql += '\n' + cls.createJoinTablesSQL(connection=conn)
+            sql += ';\n' + cls.createJoinTablesSQL(connection=conn)
         if createIndexes:
-            sql += '\n' + cls.createIndexesSQL(connection=conn)
+            sql += ';\n' + cls.createIndexesSQL(connection=conn)
         return sql
     createTableSQL = classmethod(createTableSQL)
 
@@ -1360,7 +1360,7 @@
                 # This join has requested not to be created
                 continue
             sql.append(conn._SO_createJoinTableSQL(join))
-        return '\n'.join(sql)
+        return ';\n'.join(sql)
     createJoinTablesSQL = classmethod(createJoinTablesSQL)
 
     def createIndexes(cls, ifNotExists=False, connection=None):
@@ -1378,7 +1378,7 @@
             if not index:
                 continue
             sql.append(conn.createIndexSQL(cls, index))
-        return '\n'.join(sql)
+        return ';\n'.join(sql)
     createIndexesSQL = classmethod(createIndexesSQL)
 
     def _getJoinsToCreate(cls):

[SQL-CVS] r1874 - SQLObject/trunk/sqlobject

[<sub...@co...>]

Author: phd
Date: 2006-08-22 08:45:56 -0600 (Tue, 22 Aug 2006)
New Revision: 1874

Modified:
   SQLObject/trunk/sqlobject/main.py
Log:
Fixed the bug 1512334: Missing character in 1421647 resolution.


Modified: SQLObject/trunk/sqlobject/main.py
===================================================================
--- SQLObject/trunk/sqlobject/main.py	2006-08-22 14:28:23 UTC (rev 1873)
+++ SQLObject/trunk/sqlobject/main.py	2006-08-22 14:45:56 UTC (rev 1874)
@@ -1415,7 +1415,7 @@
                 # This join has requested not to be created
                 continue
             sql.append(conn._SO_createJoinTableSQL(join))
-        return '\n'.join(sql)
+        return ';\n'.join(sql)
     createJoinTablesSQL = classmethod(createJoinTablesSQL)
 
     def createIndexes(cls, ifNotExists=False, connection=None):
@@ -1433,7 +1433,7 @@
             if not index:
                 continue
             sql.append(conn.createIndexSQL(cls, index))
-        return '\n'.join(sql)
+        return ';\n'.join(sql)
     createIndexesSQL = classmethod(createIndexesSQL)
 
     def _getJoinsToCreate(cls):

[SQL-CVS] [ sqlobject-Bugs-1517116 ] Multiple join of table with itself fails with Postgres

[SourceForge.net <no...@so...>]

Bugs item #1517116, was opened at 2006-07-04 22:55
Message generated for change (Comment added) made by phd
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=540672&aid=1517116&group_id=74338

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: Postgres
Group: SQLObject release (specify)
>Status: Closed
>Resolution: Wont Fix
Priority: 5
Submitted By: Henrik Weber (hweber)
>Assigned to: Oleg Broytmann (phd)
Summary: Multiple join of table with itself fails with Postgres

Initial Comment:
With SQLobject 0.7.0 using Postgres I have tried to 
join a table with itself more than once. The code 
looks something like this:

alias1 = Alias(Tbl, "T1")
alias2 = Alias(Tbl, "T2")

joins = [INNERJOINOn(Tbl, alias1, Tbl.q.tblid == 
alias1.q.tblid), INNERJOINOn(Tbl, alias2, Tbl.q.tblid 
== alias2.q.tblid)]

result = Tbl.select(somewherecrit, join=joins)

The resulting SQL statement looks like this:

SELECT Tbl.id, Tbl.tblid FROM Tbl INNER JOIN Tbl AS T1 
ON (Tbl.tblid = T2.tblid), Tbl INNER JOIN Tbl AS T2 ON 
(Tbl.tblid = T2.tblid)
WHERE ...

The resulting error message is:
psycopg2.ProgrammingError: table name "Tbl" specified 
more than once


The correct statement would actually have been:

SELECT Tbl.id, Tbl.tblid FROM Tbl INNER JOIN Tbl AS T1 
ON (Tbl.tblid = T2.tblid) INNER JOIN Tbl AS T2 ON 
(Tbl.tblid = T2.tblid)
WHERE ...

I tried defining the join recursively, but you can't 
use a Join object as parameter for a new join.

----------------------------------------------------------------------

>Comment By: Oleg Broytmann (phd)
Date: 2006-08-22 18:36

Message:
Logged In: YES 
user_id=4799

If you don't want the second Tbl, do not name it. Use None
instead:

INNERJOINOn(None, alias2...

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=540672&aid=1517116&group_id=74338

[SQL-CVS] [ sqlobject-Bugs-1510525 ] Missing self. in index.py

[SourceForge.net <no...@so...>]

Bugs item #1510525, was opened at 2006-06-22 14:45
Message generated for change (Comment added) made by phd
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=540672&aid=1510525&group_id=74338

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: General
Group: SQLObject from repository
>Status: Closed
>Resolution: Fixed
Priority: 5
Submitted By: Giuseppe Corbelli (cowo)
>Assigned to: Oleg Broytmann (phd)
Summary: Missing self. in index.py

Initial Comment:
In 
sqlobject/index.py 
DatabaseIndex._get_name

def _get_name(self):
    return kw['name']

must become

def _get_name(self):
    return self.kw['name']


----------------------------------------------------------------------

>Comment By: Oleg Broytmann (phd)
Date: 2006-08-22 18:28

Message:
Logged In: YES 
user_id=4799

Fixed in the revision 1872 in the trunk and r1873 in the
0.7-branch. Thank you!

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=540672&aid=1510525&group_id=74338

[SQL-CVS] r1873 - SQLObject/branches/0.7-bugfix/sqlobject

[<sub...@co...>]

Author: phd
Date: 2006-08-22 08:28:23 -0600 (Tue, 22 Aug 2006)
New Revision: 1873

Modified:
   SQLObject/branches/0.7-bugfix/sqlobject/index.py
Log:
Fixed the bug 1510525: Missing self. in index.py.


Modified: SQLObject/branches/0.7-bugfix/sqlobject/index.py
===================================================================
--- SQLObject/branches/0.7-bugfix/sqlobject/index.py	2006-08-22 14:27:24 UTC (rev 1872)
+++ SQLObject/branches/0.7-bugfix/sqlobject/index.py	2006-08-22 14:28:23 UTC (rev 1873)
@@ -133,7 +133,7 @@
         self.kw['name'] = value
 
     def _get_name(self):
-        return kw['name']
+        return self.kw['name']
 
     def _set_name(self, value):
         self.setName(value)

[SQL-CVS] r1872 - SQLObject/trunk/sqlobject

[<sub...@co...>]

Author: phd
Date: 2006-08-22 08:27:24 -0600 (Tue, 22 Aug 2006)
New Revision: 1872

Modified:
   SQLObject/trunk/sqlobject/index.py
Log:
Fixed the bug 1510525: Missing self. in index.py.


Modified: SQLObject/trunk/sqlobject/index.py
===================================================================
--- SQLObject/trunk/sqlobject/index.py	2006-08-22 14:21:53 UTC (rev 1871)
+++ SQLObject/trunk/sqlobject/index.py	2006-08-22 14:27:24 UTC (rev 1872)
@@ -156,7 +156,7 @@
         self.kw['name'] = value
 
     def _get_name(self):
-        return kw['name']
+        return self.kw['name']
 
     def _set_name(self, value):
         self.setName(value)

[SQL-CVS] r1871 - SQLObject/docs

[<sub...@co...>]

Author: phd
Date: 2006-08-22 08:21:53 -0600 (Tue, 22 Aug 2006)
New Revision: 1871

Modified:
   SQLObject/docs/News.txt
Log:
Update NEWS.


Modified: SQLObject/docs/News.txt
===================================================================
--- SQLObject/docs/News.txt	2006-08-22 14:20:43 UTC (rev 1870)
+++ SQLObject/docs/News.txt	2006-08-22 14:21:53 UTC (rev 1871)
@@ -89,6 +89,8 @@
 
 * Implemented ``RLIKE`` (reguluar expression LIKE).
 
+* Moved _idSequence to sqlmeta.idSequence.
+
 Small Features
 --------------
 

[SQL-CVS] [ sqlobject-Bugs-1380296 ] idSequence should be in sqlmeta

[SourceForge.net <no...@so...>]

Bugs item #1380296, was opened at 2005-12-14 13:17
Message generated for change (Comment added) made by phd
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=540672&aid=1380296&group_id=74338

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: Postgres
Group: SQLObject from repository
>Status: Closed
>Resolution: Fixed
Priority: 5
Submitted By: TH (therve)
>Assigned to: Oleg Broytmann (phd)
Summary: idSequence should be in sqlmeta

Initial Comment:
All is in title : to be consistent with the move of
table, idName etc. in sqlmeta, the idSequence attribute
should also be move there.

----------------------------------------------------------------------

>Comment By: Oleg Broytmann (phd)
Date: 2006-08-22 18:21

Message:
Logged In: YES 
user_id=4799

Fixed in the revision r1869 in the trunk and r1870 in the
0.7-branch.

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=540672&aid=1380296&group_id=74338

[SQL-CVS] r1870 - in SQLObject/branches/0.7-bugfix: docs sqlobject sqlobject/firebird sqlobject/postgres

[<sub...@co...>]

Author: phd
Date: 2006-08-22 08:20:43 -0600 (Tue, 22 Aug 2006)
New Revision: 1870

Modified:
   SQLObject/branches/0.7-bugfix/docs/News.txt
   SQLObject/branches/0.7-bugfix/sqlobject/firebird/firebirdconnection.py
   SQLObject/branches/0.7-bugfix/sqlobject/main.py
   SQLObject/branches/0.7-bugfix/sqlobject/postgres/pgconnection.py
Log:
Fixed the bug 1380296: idSequence should be in sqlmeta.


Modified: SQLObject/branches/0.7-bugfix/docs/News.txt
===================================================================
--- SQLObject/branches/0.7-bugfix/docs/News.txt	2006-08-22 14:19:20 UTC (rev 1869)
+++ SQLObject/branches/0.7-bugfix/docs/News.txt	2006-08-22 14:20:43 UTC (rev 1870)
@@ -29,6 +29,8 @@
 
 * Implemented ``RLIKE`` (reguluar expression LIKE).
 
+* Moved _idSequence to sqlmeta.idSequence.
+
 Small Features
 --------------
 

Modified: SQLObject/branches/0.7-bugfix/sqlobject/firebird/firebirdconnection.py
===================================================================
--- SQLObject/branches/0.7-bugfix/sqlobject/firebird/firebirdconnection.py	2006-08-22 14:19:20 UTC (rev 1869)
+++ SQLObject/branches/0.7-bugfix/sqlobject/firebird/firebirdconnection.py	2006-08-22 14:20:43 UTC (rev 1870)
@@ -89,8 +89,8 @@
         for each table this method to work."""
         table = soInstance.sqlmeta.table
         idName = soInstance.sqlmeta.idName
-        sequenceName = getattr(soInstance, '_idSequence',
-                               'GEN_%s' % table)
+        sequenceName = soInstance.sqlmeta.idSequence or \
+                               'GEN_%s' % table
         c = conn.cursor()
         if id is None:
             c.execute('SELECT gen_id(%s,1) FROM rdb$database'

Modified: SQLObject/branches/0.7-bugfix/sqlobject/main.py
===================================================================
--- SQLObject/branches/0.7-bugfix/sqlobject/main.py	2006-08-22 14:19:20 UTC (rev 1869)
+++ SQLObject/branches/0.7-bugfix/sqlobject/main.py	2006-08-22 14:20:43 UTC (rev 1870)
@@ -177,6 +177,7 @@
 
     table = None
     idName = None
+    idSequence = None
     # This function is used to coerce IDs into the proper format,
     # so you should replace it with str, or another function, if you
     # aren't using integer IDs
@@ -874,7 +875,7 @@
         """
         for attr in ['_table', '_lazyUpdate', '_style', '_idName',
                      '_defaultOrder', '_cacheValues', '_registry',
-                     '_idType', '_fromDatabase']:
+                     '_idType', '_fromDatabase', '_idSequence']:
             if new_attrs.has_key(attr):
                 new_name = attr[1:]
                 deprecated("%r is deprecated; please set the %r "

Modified: SQLObject/branches/0.7-bugfix/sqlobject/postgres/pgconnection.py
===================================================================
--- SQLObject/branches/0.7-bugfix/sqlobject/postgres/pgconnection.py	2006-08-22 14:19:20 UTC (rev 1869)
+++ SQLObject/branches/0.7-bugfix/sqlobject/postgres/pgconnection.py	2006-08-22 14:20:43 UTC (rev 1870)
@@ -119,8 +119,8 @@
     def _queryInsertID(self, conn, soInstance, id, names, values):
         table = soInstance.sqlmeta.table
         idName = soInstance.sqlmeta.idName
-        sequenceName = getattr(soInstance, '_idSequence',
-                               '%s_%s_seq' % (table, idName))
+        sequenceName = soInstance.sqlmeta.idSequence or \
+                               '%s_%s_seq' % (table, idName)
         c = conn.cursor()
         if id is None:
             c.execute("SELECT NEXTVAL('%s')" % sequenceName)

[SQL-CVS] r1869 - in SQLObject/trunk/sqlobject: . firebird postgres

[<sub...@co...>]

Author: phd
Date: 2006-08-22 08:19:20 -0600 (Tue, 22 Aug 2006)
New Revision: 1869

Modified:
   SQLObject/trunk/sqlobject/firebird/firebirdconnection.py
   SQLObject/trunk/sqlobject/main.py
   SQLObject/trunk/sqlobject/postgres/pgconnection.py
Log:
Fixed the bug 1380296: idSequence should be in sqlmeta.


Modified: SQLObject/trunk/sqlobject/firebird/firebirdconnection.py
===================================================================
--- SQLObject/trunk/sqlobject/firebird/firebirdconnection.py	2006-08-22 04:48:52 UTC (rev 1868)
+++ SQLObject/trunk/sqlobject/firebird/firebirdconnection.py	2006-08-22 14:19:20 UTC (rev 1869)
@@ -90,8 +90,8 @@
         for each table this method to work."""
         table = soInstance.sqlmeta.table
         idName = soInstance.sqlmeta.idName
-        sequenceName = getattr(soInstance, '_idSequence',
-                               'GEN_%s' % table)
+        sequenceName = soInstance.sqlmeta.idSequence or \
+                               'GEN_%s' % table
         c = conn.cursor()
         if id is None:
             c.execute('SELECT gen_id(%s,1) FROM rdb$database'

Modified: SQLObject/trunk/sqlobject/main.py
===================================================================
--- SQLObject/trunk/sqlobject/main.py	2006-08-22 04:48:52 UTC (rev 1868)
+++ SQLObject/trunk/sqlobject/main.py	2006-08-22 14:19:20 UTC (rev 1869)
@@ -180,6 +180,7 @@
 
     table = None
     idName = None
+    idSequence = None
     # This function is used to coerce IDs into the proper format,
     # so you should replace it with str, or another function, if you
     # aren't using integer IDs
@@ -879,7 +880,7 @@
         """
         for attr in ['_table', '_lazyUpdate', '_style', '_idName',
                      '_defaultOrder', '_cacheValues', '_registry',
-                     '_idType', '_fromDatabase']:
+                     '_idType', '_fromDatabase', '_idSequence']:
             if new_attrs.has_key(attr):
                 new_name = attr[1:]
                 deprecated("%r is deprecated; please set the %r "

Modified: SQLObject/trunk/sqlobject/postgres/pgconnection.py
===================================================================
--- SQLObject/trunk/sqlobject/postgres/pgconnection.py	2006-08-22 04:48:52 UTC (rev 1868)
+++ SQLObject/trunk/sqlobject/postgres/pgconnection.py	2006-08-22 14:19:20 UTC (rev 1869)
@@ -119,8 +119,8 @@
     def _queryInsertID(self, conn, soInstance, id, names, values):
         table = soInstance.sqlmeta.table
         idName = soInstance.sqlmeta.idName
-        sequenceName = getattr(soInstance, '_idSequence',
-                               '%s_%s_seq' % (table, idName))
+        sequenceName = soInstance.sqlmeta.idSequence or \
+                               '%s_%s_seq' % (table, idName)
         c = conn.cursor()
         if id is None:
             c.execute("SELECT NEXTVAL('%s')" % sequenceName)

[SQL-CVS] [ sqlobject-Bugs-1429248 ] tableExists query issues with uper case table names

[SourceForge.net <no...@so...>]

Bugs item #1429248, was opened at 2006-02-10 20:00
Message generated for change (Settings changed) made by phd
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=540672&aid=1429248&group_id=74338

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: Postgres
Group: None
>Status: Closed
Resolution: Wont Fix
Priority: 5
Submitted By: Hootbah (hootbah)
Assigned to: Oleg Broytmann (phd)
Summary: tableExists query issues with uper case table names

Initial Comment:
Its is possible for the tableExists query not to find a
table when it does actually exist. 

When using uppercase names e.g.

class sqlmeta:
    table = 'MYTABLE'


The tableExists query becomes:

SELECT COUNT(relname) FROM pg_class WHERE relname =
'MYTABLE'

This fails to find the table as the table names stored
within pg_class are all lower case.

I propose to change the query to be:

SELECT COUNT(relname) FROM pg_class WHERE relname =
lower('MYTABLE')


This would mean a change to pgconnection.py:

 result = self.queryOne("SELECT COUNT(relname) FROM
pg_class WHERE relname = lower(%s)" 
        % self.sqlrepr(tableName))

----------------------------------------------------------------------

Comment By: Oleg Broytmann (phd)
Date: 2006-03-27 18:51

Message:
Logged In: YES 
user_id=4799

The fix would break case-sensitive names. You don't want to
make this lowercase:

class sqlmeta:
   table = '"MYTABLE"'

Instead just write the name lower-cased:

class sqlmeta:
   table = 'mytable'

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=540672&aid=1429248&group_id=74338

[SQL-CVS] [ sqlobject-Bugs-1334786 ] infinitiv recursion in Transaction.__del__

[SourceForge.net <no...@so...>]

Bugs item #1334786, was opened at 2005-10-22 13:30
Message generated for change (Comment added) made by phd
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=540672&aid=1334786&group_id=74338

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: None
Group: None
>Status: Closed
>Resolution: Fixed
Priority: 5
Submitted By: M. Dietrich (mdt)
>Assigned to: Oleg Broytmann (phd)
Summary: infinitiv recursion in Transaction.__del__

Initial Comment:
using ThreadConnections i get a 

Exception exceptions.RuntimeError: 'maximum recursion
depth exceeded' in <bound method Transaction.__del__ of
<sqlobject.dbconnection.Transaction object at
0xaedb714c>> ignored

, commenting __del__() works in the first place. can't
figure out what this __del__ is for... 

----------------------------------------------------------------------

>Comment By: Oleg Broytmann (phd)
Date: 2006-08-22 17:53

Message:
Logged In: YES 
user_id=4799

That's been fixed in the revision 1838.

----------------------------------------------------------------------

Comment By: Nobody/Anonymous (nobody)
Date: 2006-03-11 04:16

Message:
Logged In: NO 

In my case, this was caused by an exception happening in the
__init__ method of Transaction.  The __del__ then tried to
use self._obsolete, which had not yet been defined causing
__getattr__ to be used which then tried to use more
undefined stuff.

--- sqlobject/dbconnection.py~  Thu Dec 23 11:52:32 2004
+++ sqlobject/dbconnection.py   Fri Mar 10 19:16:24 2006
@@ -473,11 +473,11 @@
 class Transaction(object):

     def __init__(self, dbConnection):
+        self.cache = CacheSet(cache=dbConnection.doCache)
+        self._obsolete = False
         self._dbConnection = dbConnection
         self._connection = dbConnection.getConnection()
         self._dbConnection._setAutoCommit(self._connection, 0)
-        self.cache = CacheSet(cache=dbConnection.doCache)
-        self._obsolete = False

     def assertActive(self):
         assert not self._obsolete, "This transaction has
already gone through COMMIT/ROLLBACK; create another
transaction"


----------------------------------------------------------------------

Comment By: Oleg Broytmann (phd)
Date: 2006-02-06 20:44

Message:
Logged In: YES 
user_id=4799

I cannot reproduce it. When Postgres is not started your
program is just reports

Traceback (most recent call last):
  File "./test1.py", line 10, in ?
    sqlhub.threadConnection = connection.transaction()
  File
"/usr/local/lib/python2.4/site-packages/SQLObject-0.7.1dev_r1534-py2.4.egg/sqlobject/dbconnection.py",
line 354, in transaction
    return Transaction(self)
  File
"/usr/local/lib/python2.4/site-packages/SQLObject-0.7.1dev_r1534-py2.4.egg/sqlobject/dbconnection.py",
line 731, in __init__
    self._connection = dbConnection.getConnection()
  File
"/usr/local/lib/python2.4/site-packages/SQLObject-0.7.1dev_r1534-py2.4.egg/sqlobject/dbconnection.py",
line 226, in getConnection
    conn = self.makeConnection()
  File
"/usr/local/lib/python2.4/site-packages/SQLObject-0.7.1dev_r1534-py2.4.egg/sqlobject/postgres/pgconnection.py",
line 108, in makeConnection
    raise self.module.OperationalError("%s; used connection
string %r" % (e, self.dsn))
psycopg.OperationalError: could not connect to server: @╠
	Is the server running locally and accepting
	connections on Unix domain socket
"/var/run/postgresql/.s.PGSQL.5432"?
; used connection string 'dbname=test'
Exception exceptions.AttributeError: "PostgresConnection
instance has no attribute '_connection'" in <bound method
Transaction.__del__ of <sqlobject.dbconnection.Transaction
object at 0xb7b6ddec>> ignored

----------------------------------------------------------------------

Comment By: Didrik Pinte (dpinte)
Date: 2006-01-24 12:20

Message:
Logged In: YES 
user_id=970259

Same here,

I can reproduce it. It happens when the database is not started.

Here is a test code :

Step 1 : 
Shut down you postgres server

Step 2 : Run the following 
-------------------------
import sqlobject

scheme = "postgres://myusername:mypassword@localhost/mydb"
connection = sqlobject.connectionForURI(scheme)
sqlobject.sqlhub.processConnection = connection
sqlhub.threadConnection = connection.transaction()
--------------------------


Didrik


----------------------------------------------------------------------

Comment By: xiao hai tong (haitong)
Date: 2005-12-04 20:35

Message:
Logged In: YES 
user_id=146934

I encount it too.

once is too many connection crash my pgsql server on 
windows, then may of such exceptions reported.

other time: 
a multi thread test program.

I want to retry my transaction when excecption occured  
during commit, I commet the threadConnection.rollback(), 
just set
threadConnection = g_conn.transaction(), and redo the 
transaction

after seconds, such exceptions occurred.

----------------------------------------------------------------------

Comment By: Oleg Broytmann (phd)
Date: 2005-10-25 20:12

Message:
Logged In: YES 
user_id=4799

Can you make a little test program that demonstrates the
problem?

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=540672&aid=1334786&group_id=74338

[SQL-CVS] Better Future, well-inaugurated

[Charlotte B. <Cha...@ma...>]

We sent you an email a while ago, because you qualified for a   
much lower rate based on our records from a national database.   
Why is this? Because currently it is a buyers market with the   
lowest rates in years.
   
You can now get $325,000 for as little as $709 a month at as low as 3.75%!   
We realize many homeowners struggle and that makes it difficult   
to maintain good credit. But we specialize in poor credit cases- helping you   
to refinance even with bad credt, helping you lower your monthly   
burden and build back your credt.   

You will receive the lowest rate possible in your special circumstance   
   
You can fill out this quick form and be approved within 24 hours:  

http://Z4I.perfecttimeforloans.com

==============================================
bed by the window. Guta woke up, too, and took Redrick's hand. He could feel
to drop the memory. He was repelled by the thought  and maybe that's  why he

[SQL-CVS] [ sqlobject-Bugs-1541095 ] Capital letters in table/column names

[SourceForge.net <no...@so...>]

Bugs item #1541095, was opened at 2006-08-16 00:19
Message generated for change (Comment added) made by nobody
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=540672&aid=1541095&group_id=74338

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: Postgres
Group: SQLObject release (specify)
Status: Open
Resolution: None
Priority: 5
Submitted By: Michel Albert (exhuma)
Assigned to: Nobody/Anonymous (nobody)
Summary: Capital letters in table/column names

Initial Comment:
Postgre requires table names, column names and so on 
to be enclosed in double quotes if they contain 
capital letters. Otherwise it assumes that they are 
all lower-case. In order to be more DBMS-agnostic, 
SQLObject should deal with that.

It is possible to do something like:
   lastName = StringCol(dbName='"lastName"')

It would be nicer to be able to do this:
   lastName = StringCol(dbName='lastName')

The current solution is error-prone. Also, when doing 
this, it get's a bit confusing as you have to leave 
out the quotes when doing joins:

   wrong:
      address = SingleJoin('"Address"')
   correct:
      address = SingleJoin('Address')

as the joins relate to Python objects, not directly to 
tables.

I have to deal with this, as I am migrating a web-
application from PHP to Python, and the database 
already exists and modifying it is not an option.


Best regards,

Michel Albert

----------------------------------------------------------------------

Comment By: Nobody/Anonymous (nobody)
Date: 2006-08-16 09:45

Message:
Logged In: NO 

This issue actually *breaks* postgres!:

--- In postgres: -----------------------------------
database=> SELECT NEXTVAL('"Hotel_idHotel_seq"');
 nextval
---------
       1
(1 row)
----------------------------------------------------


--- Using SQLObject --------------------------------
>>> x = Hotel(name="foo", address=None, owner=None, 
establishment=None)
Traceback (most recent call last):
  File "<console>", line 1, in ?
  File "/usr/lib/python2.4/site-packages/SQLObject-
0.7.1dev_r1675-py2.4.egg/sqlobject/declarative.py", line 
92, in _wrapper
    return_value = fn(self, *args, **kwargs)
  File "/usr/lib/python2.4/site-packages/SQLObject-
0.7.1dev_r1675-py2.4.egg/sqlobject/main.py", line 1197, in 
__init__
    self._create(id, **kw)
  File "/usr/lib/python2.4/site-packages/SQLObject-
0.7.1dev_r1675-py2.4.egg/sqlobject/main.py", line 1224, in 
_create
    self._SO_finishCreate(id)
  File "/usr/lib/python2.4/site-packages/SQLObject-
0.7.1dev_r1675-py2.4.egg/sqlobject/main.py", line 1248, in 
_SO_finishCreate
    id, names, values)
  File "/usr/lib/python2.4/site-packages/SQLObject-
0.7.1dev_r1675-py2.4.egg/sqlobject/dbconnection.py", line 
759, in queryInsertID
    return self._dbConnection._queryInsertID(
  File "/usr/lib/python2.4/site-packages/SQLObject-
0.7.1dev_r1675-py2.4.egg/sqlobject/postgres/
pgconnection.py", line 126, in _queryInsertID
    c.execute("SELECT NEXTVAL('%s')" % sequenceName)
ProgrammingError: ERROR:  invalid name syntax

SELECT NEXTVAL('"Hotel"_"idHotel"_seq')
----------------------------------------------------

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=540672&aid=1541095&group_id=74338

[SQL-CVS] [ sqlobject-Bugs-1541095 ] Capital letters in table/column names

[SourceForge.net <no...@so...>]

Bugs item #1541095, was opened at 2006-08-16 09:19
Message generated for change (Tracker Item Submitted) made by Item Submitter
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=540672&aid=1541095&group_id=74338

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: Postgres
Group: SQLObject release (specify)
Status: Open
Resolution: None
Priority: 5
Submitted By: Michel Albert (exhuma)
Assigned to: Nobody/Anonymous (nobody)
Summary: Capital letters in table/column names

Initial Comment:
Postgre requires table names, column names and so on 
to be enclosed in double quotes if they contain 
capital letters. Otherwise it assumes that they are 
all lower-case. In order to be more DBMS-agnostic, 
SQLObject should deal with that.

It is possible to do something like:
   lastName = StringCol(dbName='"lastName"')

It would be nicer to be able to do this:
   lastName = StringCol(dbName='lastName')

The current solution is error-prone. Also, when doing 
this, it get's a bit confusing as you have to leave 
out the quotes when doing joins:

   wrong:
      address = SingleJoin('"Address"')
   correct:
      address = SingleJoin('Address')

as the joins relate to Python objects, not directly to 
tables.

I have to deal with this, as I am migrating a web-
application from PHP to Python, and the database 
already exists and modifying it is not an option.


Best regards,

Michel Albert

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=540672&aid=1541095&group_id=74338

[SQL-CVS] [ sqlobject-Patches-1539325 ] fromDatabase and delColumn for sqlite

[SourceForge.net <no...@so...>]

Patches item #1539325, was opened at 2006-08-13 01:42
Message generated for change (Comment added) made by phd
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=540674&aid=1539325&group_id=74338

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: None
Group: None
Status: Open
Resolution: None
Priority: 5
Submitted By: Arlo Belshee (abelcodemonk)
>Assigned to: Oleg Broytmann (phd)
Summary: fromDatabase and delColumn for sqlite

Initial Comment:
This patch implements both fromDatabase and delColumn 
for sqlite. I added sqlite to the appropriate 
existing tests; it passes them.

fromDatabase is done by parsing the table creation 
sql from the sqlite_master table. This will work with 
any sqlite 3, and I think dates back into sqlite 2, 
but I'm not sure.

delColumn is implemented by renaming the table, 
creating a new table without the one column, then 
copying all the data over. This is obviously not as 
efficient as on DBs that support drop column 
directly, but it works.

This implementation of dropColumn does deal correctly 
with triggers, foreign keys, and indices that 
reference the table whose column is being dropped. It 
does not deal correctly with triggers & indices 
attached directly to the table being altered. 
Attached items will be lost. Extending the 
implementation to support re-creating those indices & 
triggers should be straightforward, but is beyond my 
needs. You are welcome to do so.

Finally, this patch slightly improves the 
implementation of addColumn for sqlite. It performs a 
vacuum operation after each column add. See the 
sqlite documentation for why this is a good idea.


----------------------------------------------------------------------

>Comment By: Oleg Broytmann (phd)
Date: 2006-08-15 17:08

Message:
Logged In: YES 
user_id=4799

Thank you very much! recreateTableWithoutColumn() is an
excellent solution!

I have some questions about the patch. Why have you added
semicolons? I think they are not needed.

Why VACUUM after addColumn()? It is more logical to do
VACUUM after delColumn(), I suppose. And, BTW, "This command
will fail if there is an active transaction." (from the
SQLite documentation).

Your patch deletes .delColumn(). But I have a number of
programs that relies on a presence of the method (even if
it's empty). I think you could just call
recreateTableWithoutColumn() from delColumn() or raise a
warning or an exception.

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=540674&aid=1539325&group_id=74338