[SQL-CVS] r1870 - in SQLObject/branches/0.7-bugfix: docs sqlobject sqlobject/firebird sqlobject/postgres

[<sub...@co...>]

Author: phd
Date: 2006-08-22 08:20:43 -0600 (Tue, 22 Aug 2006)
New Revision: 1870

Modified:
   SQLObject/branches/0.7-bugfix/docs/News.txt
   SQLObject/branches/0.7-bugfix/sqlobject/firebird/firebirdconnection.py
   SQLObject/branches/0.7-bugfix/sqlobject/main.py
   SQLObject/branches/0.7-bugfix/sqlobject/postgres/pgconnection.py
Log:
Fixed the bug 1380296: idSequence should be in sqlmeta.


Modified: SQLObject/branches/0.7-bugfix/docs/News.txt
===================================================================
--- SQLObject/branches/0.7-bugfix/docs/News.txt	2006-08-22 14:19:20 UTC (rev 1869)
+++ SQLObject/branches/0.7-bugfix/docs/News.txt	2006-08-22 14:20:43 UTC (rev 1870)
@@ -29,6 +29,8 @@
 
 * Implemented ``RLIKE`` (reguluar expression LIKE).
 
+* Moved _idSequence to sqlmeta.idSequence.
+
 Small Features
 --------------
 

Modified: SQLObject/branches/0.7-bugfix/sqlobject/firebird/firebirdconnection.py
===================================================================
--- SQLObject/branches/0.7-bugfix/sqlobject/firebird/firebirdconnection.py	2006-08-22 14:19:20 UTC (rev 1869)
+++ SQLObject/branches/0.7-bugfix/sqlobject/firebird/firebirdconnection.py	2006-08-22 14:20:43 UTC (rev 1870)
@@ -89,8 +89,8 @@
         for each table this method to work."""
         table = soInstance.sqlmeta.table
         idName = soInstance.sqlmeta.idName
-        sequenceName = getattr(soInstance, '_idSequence',
-                               'GEN_%s' % table)
+        sequenceName = soInstance.sqlmeta.idSequence or \
+                               'GEN_%s' % table
         c = conn.cursor()
         if id is None:
             c.execute('SELECT gen_id(%s,1) FROM rdb$database'

Modified: SQLObject/branches/0.7-bugfix/sqlobject/main.py
===================================================================
--- SQLObject/branches/0.7-bugfix/sqlobject/main.py	2006-08-22 14:19:20 UTC (rev 1869)
+++ SQLObject/branches/0.7-bugfix/sqlobject/main.py	2006-08-22 14:20:43 UTC (rev 1870)
@@ -177,6 +177,7 @@
 
     table = None
     idName = None
+    idSequence = None
     # This function is used to coerce IDs into the proper format,
     # so you should replace it with str, or another function, if you
     # aren't using integer IDs
@@ -874,7 +875,7 @@
         """
         for attr in ['_table', '_lazyUpdate', '_style', '_idName',
                      '_defaultOrder', '_cacheValues', '_registry',
-                     '_idType', '_fromDatabase']:
+                     '_idType', '_fromDatabase', '_idSequence']:
             if new_attrs.has_key(attr):
                 new_name = attr[1:]
                 deprecated("%r is deprecated; please set the %r "

Modified: SQLObject/branches/0.7-bugfix/sqlobject/postgres/pgconnection.py
===================================================================
--- SQLObject/branches/0.7-bugfix/sqlobject/postgres/pgconnection.py	2006-08-22 14:19:20 UTC (rev 1869)
+++ SQLObject/branches/0.7-bugfix/sqlobject/postgres/pgconnection.py	2006-08-22 14:20:43 UTC (rev 1870)
@@ -119,8 +119,8 @@
     def _queryInsertID(self, conn, soInstance, id, names, values):
         table = soInstance.sqlmeta.table
         idName = soInstance.sqlmeta.idName
-        sequenceName = getattr(soInstance, '_idSequence',
-                               '%s_%s_seq' % (table, idName))
+        sequenceName = soInstance.sqlmeta.idSequence or \
+                               '%s_%s_seq' % (table, idName)
         c = conn.cursor()
         if id is None:
             c.execute("SELECT NEXTVAL('%s')" % sequenceName)