|
From: SourceForge.net <no...@so...> - 2006-11-10 15:08:23
|
Patches item #1592104, was opened at 2006-11-07 19:44 Message generated for change (Comment added) made by phd You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=540674&aid=1592104&group_id=74338 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: None Group: None >Status: Closed >Resolution: Accepted Priority: 5 Private: No Submitted By: Luke Opperman (luke_opperman) >Assigned to: Oleg Broytmann (phd) Summary: sqlbuilder.Select with JOINs Initial Comment: Attacking the "dbconnection.queryForSelect / sresults.SelectResults don't use sqlbuilder.Select" issue a piece at a time, and I needed this for a simpler purpose: sqlbuilder.Select does not know how to handle sqlbuilder.SQLJoin instances. This diff adds the logic from dbconnection._fixTablesForJoins and dbconnection._addJoins to Select, taking a "join" parameter as SQLObject.select/sresults.SelectResults does. Trivial test added to the other tests of sqlbuilder.Select, not a realistic use of a SQLJoin however. ---------------------------------------------------------------------- >Comment By: Oleg Broytmann (phd) Date: 2006-11-10 18:08 Message: Logged In: YES user_id=4799 Very nice! Applied and committed in the revisions 2069-2071. Thank you! ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=540674&aid=1592104&group_id=74338 |
