|
From: SourceForge.net <no...@so...> - 2006-06-07 12:37:46
|
Patches item #1496016, was opened at 2006-05-27 18:49 Message generated for change (Comment added) made by phd You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=540674&aid=1496016&group_id=74338 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: None Group: None Status: Open Resolution: None Priority: 5 Submitted By: Neil Muller (nitwit) Assigned to: Nobody/Anonymous (nobody) Summary: Encode queries to unicode for MySQLdb 1.2.1 Initial Comment: MySQLdb 1.2.1 assumes that queries will be unicode objects rather than string objects. The attached patch aims to do the right thing. The assumption about alwasy encoding using the charset specified in the mysql URI is somewhat questionable, and it may be better to try and infer self.encoding from the locale instead. ---------------------------------------------------------------------- >Comment By: Oleg Broytmann (phd) Date: 2006-06-07 16:37 Message: Logged In: YES user_id=4799 Your patch starts with "if MySQLdb.version_info[0]>0...". You probably want "if MySQLdb.version_info[0]>1..."? Your patch adds "use_unicode"... which is already there. ;) BTW, in case of MySQLbd 1.2.1+ where self.need_unicode=True you probbaly wants to always set use_unicode to 1, no? What if the user sets use_unicode=False? Would MySQLdb revert to ascii queries and responces? Infering self.encoding from the environment is the application's task, I think. Let's the user decide what encoding (s)he wants. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=540674&aid=1496016&group_id=74338 |
